Bug 1367527 - core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)
Summary: core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1368423
TreeView+ depends on / blocked
 
Reported: 2016-08-16 16:14 UTC by Kaleb KEITHLEY
Modified: 2017-01-03 11:19 UTC (History)
2 users (show)

Fixed In Version: 3.9.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1368423 (view as bug list)
Environment:
Last Closed: 2017-01-03 11:19:50 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2016-08-16 16:14:21 UTC
Description of problem:

gnu glibc (libc) in Fedora 26 (rawhide) has turned off "compat" for makedev(), major(), and minor(3) decls.

3.8.2 on F26 built with warnings, see: https://kojipkgs.fedoraproject.org//packages/glusterfs/3.8.2/1.fc26/data/logs/x86_64/build.log

More recent builds of other packages (namely nfs-ganesha) indicate that these warnings would now be errors, and, e.g. will be errors when 3.8.3 is released and built.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-08-16 16:17:01 UTC
REVIEW: http://review.gluster.org/15182 (core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Vijay Bellur 2016-08-16 18:09:07 UTC
REVIEW: http://review.gluster.org/15182 (core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Vijay Bellur 2016-08-19 10:58:43 UTC
COMMIT: http://review.gluster.org/15182 committed in master by Niels de Vos (ndevos) 
------
commit c441a0ae5aca1f2977961afecb3236f90eb5b672
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Tue Aug 16 12:14:43 2016 -0400

    core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)
    
    gnu glibc (libc) in Fedora 26 (rawhide) has turned off "compat" for
    makedev(), major(), and minor(3) decls.
    
    3.8.2 on F26 built with warnings, see:
    https://kojipkgs.fedoraproject.org//packages/glusterfs/3.8.2/1.fc26/data/logs/x86_64/build.log
    
    More recent builds of other packages (namely nfs-ganesha) indicate
    that these warnings would now be errors, and, will be errors when
    3.8.3 is released and built.
    
    Change-Id: I3caa0d05f5de695818753e40e754da8b40d2011c
    BUG: 1367527
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/15182
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>


Note You need to log in before you can comment on or make changes to this bug.