Please review branch bg/libnm-activation-stuck-rh1367752.

>> libnm: make waiting objects fail when an object initialization fails
    

+              priv->waiters = g_slist_remove (priv->waiters, odata);

g_slist_delete_link?



NM_OBJECT_GET_PRIVATE (odata->self)->reload_error = g_error_copy (error);

are we sure, that this doesn't leak a possible previously set error? Maybe:

  if (!odata_priv->reload_error)
     ...



rest lgtm

(In reply to Thomas Haller from comment #3)
> +              priv->waiters = g_slist_remove (priv->waiters, odata);
> 
> g_slist_delete_link?

I prefer to leave it similar to the code few lines below.


> NM_OBJECT_GET_PRIVATE (odata->self)->reload_error = g_error_copy (error);
> 
> are we sure, that this doesn't leak a possible previously set error? Maybe:
> 
>   if (!odata_priv->reload_error)

Fixed, thanks!

Looks fine to me.

Branch merged to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=aae26ebed31a8195f8b11b015ae77a45c753e5d3

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2299