Bug 1368034 - "openshift.common.version_gte_3_3_or_1_3" would be set to false due to "openshift_image_tag=v3.3" was set in inventory hosts.
Summary: "openshift.common.version_gte_3_3_or_1_3" would be set to false due to "opens...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Devan Goodwin
QA Contact: Johnny Liu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-18 07:44 UTC by Gan Huang
Modified: 2017-08-25 15:51 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-25 15:51:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Gan Huang 2016-08-18 07:44:43 UTC
Description of problem:
If i set "openshift_image_tag=v3.3" in inventory hosts, openshift-ansible would mistakely set "openshift.common.version_gte_3_3_or_1_3" to false by "version_gte_3_3_or_1_3 = LooseVersion(version) >= LooseVersion('3.3.0')". Thus master.yaml.v1.j2, node.yaml.v1.j2 and registry_config.j2 including "version_gte_3_3_or_1_3" will get in trouble.

Version-Release number of selected component (if applicable):
openshift-ansible-3.3.12-1.git.0.b26c8c2.el7.noarch.rpm

How reproducible:
always

Steps to Reproduce:
1.cat inventory_hosts
<--snip-->
openshift_image_tag=v3.3
<--snip-->

2.Trigger the installation
3.

Actual results:
Some values in master/node/registry_config including "version_gte_3_3_or_1_3" will set to a wrong value.

Expected results:


Additional info:

Comment 1 Devan Goodwin 2016-08-19 13:35:32 UTC
Moving to upcoming release as this is technically a misuse of the inventory variables. openshift_image_tag should just be for advanced users now, arguably the new v3.3 tags *should* be usable here but there is a very bad possible consequence of that where in as you scale up your environment, other nodes could end up with a newer v3.3 image than you have when you initially setup the cluster.

Intended usage is openshift_release=v3.3, and if using openshift_image_tag it should be very precise. 

Regardless it should probably error out in this configuration, so keeping the bug open.


Note You need to log in before you can comment on or make changes to this bug.