Bug 1368099 - Upgrade incorrect from build1 to other two new build2 and build3
Summary: Upgrade incorrect from build1 to other two new build2 and build3
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-node
Classification: oVirt
Component: Installation & Update
Version: 4.0
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ovirt-4.2.0
: 4.2
Assignee: Yuval Turgeman
QA Contact: Huijuan Zhao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-18 12:12 UTC by Huijuan Zhao
Modified: 2017-12-20 11:01 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-20 11:01:25 UTC
oVirt Team: Node
Embargoed:
rule-engine: ovirt-4.2+
rule-engine: planning_ack+
fdeutsch: devel_ack+
cshao: testing_ack+


Attachments (Terms of Use)
All logs (6.17 MB, application/x-gzip)
2016-08-18 12:12 UTC, Huijuan Zhao
no flags Details
For comment 6: imgbased.log and /var/log from host (8.58 MB, application/x-gzip)
2017-08-07 02:45 UTC, Huijuan Zhao
no flags Details
For comment 12: sosreport, imgbased.log, and all files in /var/log from host (10.98 MB, application/x-gzip)
2017-08-08 02:14 UTC, Huijuan Zhao
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 79107 0 master MERGED osupdater: migrating from current running layer 2017-07-21 12:27:45 UTC

Description Huijuan Zhao 2016-08-18 12:12:59 UTC
Created attachment 1191863 [details]
All logs

Description of problem:
Upgrade from build1 to build2, than upgrade from build1 to build3, it is actually upgrade from build2 to build3.
It should upgrade from build1 to build3.


Version-Release number of selected component (if applicable):
redhat-virtualization-host-4.0-20160817.0.x86_64
imgbased-0.8.4-1.el7ev.noarch
redhat-release-virtualization-host-4.0-2.el7.x86_64
redhat-virtualization-host-image-update-placeholder-4.0-2.el7.noarch

How reproducible:
100%

Steps to Reproduce:
1. Install RHVH rhvh-4.0-0.20160803.0.x86_64
2. Login RHVH and setup local repos, touch new file1 in /etc
3. Upgrade RHVH from rhvh-4.0-0.20160803.0.x86_64 to rhvh-4.0-0.20160812.0.x86_64
4. Reboot and login second build RHVH rhvh-4.0-0.20160812.0.x86_64, there is new file1 in /etc. Then touch another new file2 in /etc
5. Reboot and login first build rhvh-4.0-0.20160803.0.x86_64, check there is only one new file1 in /etc. Setup local repos
6. Upgrade from first build rhvh-4.0-0.20160803.0.x86_64 to redhat-virtualization-host-4.0-20160817.0.x86_64
7. Reboot and login the third build redhat-virtualization-host-4.0-20160817.0.x86_64
8. Check files in /etc

Actual results:
After step8, there are two new files in /etc: file1 and file2. so it seems like update from build2 to build3 

Expected results:
After step8, there should be only one new file in /etc: file1. It should be update from build1 to build3

Additional info:
# cat /var/log/yum.log 
Aug 18 05:49:21 Installed: redhat-virtualization-host-image-update-4.0-20160812.0.el7_2.noarch
Aug 18 05:49:21 Erased: redhat-virtualization-host-image-update-placeholder-4.0-0.26.el7.noarch
Aug 18 06:44:49 Updated: redhat-virtualization-host-image-update-4.0-20160817.0.el7_2.noarch

Comment 1 Fabian Deutsch 2016-08-18 12:20:04 UTC
This flow will happen if the intermediate buld is broken, and a rollback is required.

There is a workaround for this case, but also it's not to common, thus moving it out for now.

Comment 4 Huijuan Zhao 2017-08-03 10:20:24 UTC
Test failed with upstream ovirt node 4.2, missing new layer ovirt node 4.2 boot entry.


Test version:
Build 1: rhvh-4.0-20170307.1
Build 2: rhvh-4.1-20170706.0
Build 3: http://jenkins.ovirt.org/job/ovirt-node-ng_master_build-artifacts-el7-x86_64/lastSuccessfulBuild/artifact/exported-artifacts/ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm


Test steps:
1. Install build 1 rhvh-4.0-20170307.1
2. Upgrade build 1 to build 2 rhvh-4.1-20170706.0
3. Reboot and login build 1
4. Upgrade build 1 to build 3 ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm
   # yum install ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm


Actual results:
After step 4, missing build 3(ovirt-node-4.2.0-0.5.master.20170803000145) boot entry.


Expected results:
After step 4, there should be newest build 3 boot entry


So I think this bug is not fixed in ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm.
Change the status to ASSIGNED.

Comment 5 Red Hat Bugzilla Rules Engine 2017-08-03 10:20:31 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Yuval Turgeman 2017-08-06 14:00:03 UTC
Hi Huijuan, is there a /tmp/imgbased.log for the last test ?

Comment 7 Huijuan Zhao 2017-08-07 01:55:21 UTC
(In reply to Yuval Turgeman from comment #6)
> Hi Huijuan, is there a /tmp/imgbased.log for the last test ?

The ENV is destroyed, let me reproduce it and upload the /tmp/imgbased.log once done.

Comment 8 Huijuan Zhao 2017-08-07 02:45:25 UTC
Created attachment 1309858 [details]
For comment 6: imgbased.log and /var/log from host

Comment 9 Huijuan Zhao 2017-08-07 03:27:59 UTC
(In reply to Huijuan Zhao from comment #4)
> Test failed with upstream ovirt node 4.2, missing new layer ovirt node 4.2
> boot entry.
> 
> 
> Test version:
> Build 1: rhvh-4.0-20170307.1
> Build 2: rhvh-4.1-20170706.0
> Build 3:
> http://jenkins.ovirt.org/job/ovirt-node-ng_master_build-artifacts-el7-x86_64/
> lastSuccessfulBuild/artifact/exported-artifacts/ovirt-node-ng-image-update-4.
> 2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm
> 
> 
> Test steps:
> 1. Install build 1 rhvh-4.0-20170307.1
> 2. Upgrade build 1 to build 2 rhvh-4.1-20170706.0
> 3. Reboot and login build 1
> 4. Upgrade build 1 to build 3
> ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.
> centos.noarch.rpm
>    # yum install
> ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.
> centos.noarch.rpm
> 
> 
> Actual results:
> After step 4, missing build 3(ovirt-node-4.2.0-0.5.master.20170803000145)
> boot entry.
> 
> 
> Expected results:
> After step 4, there should be newest build 3 boot entry
> 
> 
> So I think this bug is not fixed in
> ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.
> centos.noarch.rpm.
> Change the status to ASSIGNED.

Update:

In step4, there is failed info during upgrade:

# yum install ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm
Loaded plugins: imgbased-warning, product-id, search-disabled-repos, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Warning: yum operations are not persisted across upgrades!
Examining ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm: ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch
Marking ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm to be installed
Resolving Dependencies
--> Running transaction check
---> Package ovirt-node-ng-image-update.noarch 0:4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos will be installed
--> Finished Dependency Resolution

Dependencies Resolved

======================================================================================================================================================================
 Package  Arch   Version                                               Repository                                                                                Size
======================================================================================================================================================================
Installing:
 ovirt-node-ng-image-update
          noarch 4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos /ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch 527 M

Transaction Summary
======================================================================================================================================================================
Install  1 Package

Total size: 527 M
Installed size: 527 M
Is this ok [y/d/N]: y
Downloading packages:
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch                                                            1/1 
warning: %post(ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch) scriptlet failed, exit status 1
Non-fatal POSTIN scriptlet failure in rpm package ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch
  Verifying  : ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch                                                            1/1 

Installed:
  ovirt-node-ng-image-update.noarch 0:4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos                                                                           

Complete!

Comment 12 Huijuan Zhao 2017-08-08 02:12:10 UTC
Yuval, you are right, it's my mistake. Thanks for your reminder.

I tested with ovirt-node-ng, the upgrade issue is gone, but when login system after upgrade, there is error info. Below is detail info.


Test version:
Build 1: ovirt-node-ng-installer-ovirt-4.1-2017060104.iso
Build 2: ovirt-node-ng-image-update-4.1.2-1.el7.centos.noarch.rpm
Build 3: http://jenkins.ovirt.org/job/ovirt-node-ng_master_build-artifacts-el7-x86_64/lastSuccessfulBuild/artifact/exported-artifacts/ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm 


Test steps:
1. Install build 1 ovirt-node-ng-installer-ovirt-4.1-2017060104.iso
2. Login build 1, touch file /etc/test1
#cat /etc/test1
test 0601
3. Upgrade build 1 to build 2 ovirt-node-ng-image-update-4.1.2-1.el7.centos.noarch.rpm
# yum install ovirt-node-ng-image-update-4.1.2-1.el7.centos.noarch.rpm
4. Reboot and login build 2, modify file /etc/file1
#cat /etc/test1
test 0601
test 0607
5. Reboot and login build 1, upgrade build 1 to build 3 ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm
   # yum install ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm
6. Reboot and focus on the boot entry
7. Login build 3, check the /etc/test1
8. When login build 3, focus on the login info


Test results:
1. After step 6, there are only two layers boot entry(build 1 and build 3)
2. After step 7, the content of /etc/test1 if correct.
#cat /etc/test1
test 0601

3. After step 8, there is error info:
$ ssh root.130.225
Warning: Permanently added '10.73.130.225' (ECDSA) to the list of known hosts.
root.130.225's password: 
Last login: Tue Aug  8 01:54:45 2017 from 10.66.10.3
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/nodectl/__main__.py", line 42, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/nodectl/__init__.py", line 200, in CliApplication
    return cmdmap.command(args)
  File "/usr/lib/python2.7/site-packages/nodectl/__init__.py", line 118, in command
    return self.commands[command](**kwargs)
  File "/usr/lib/python2.7/site-packages/nodectl/__init__.py", line 102, in motd
    machine_readable=True).output, self.machine).write()
  File "/usr/lib/python2.7/site-packages/nodectl/status.py", line 51, in __init__
    self._update_info(status)
  File "/usr/lib/python2.7/site-packages/nodectl/status.py", line 78, in _update_info
    if "ok" not in status.lower():
AttributeError: Status instance has no attribute 'lower'



Expected results:
3. After step 8, there should be no error info.


So I think this upgrade issue is fixed in ovirt-node-ng-image-update-4.2.0-0.5.master.20170803000145.git85abc0e.el7.centos.noarch.rpm.

But what about the login error info?

Comment 13 Huijuan Zhao 2017-08-08 02:14:49 UTC
Created attachment 1310393 [details]
For comment 12: sosreport, imgbased.log, and all files in /var/log from host

Comment 14 Ryan Barry 2017-08-08 02:15:34 UTC
See https://bugzilla.redhat.com/show_bug.cgi?id=1478731

Comment 15 Huijuan Zhao 2017-08-08 02:26:51 UTC
Thanks Ryan.

So this login issue is traced by Bug 1478731. I will change the status to VERIFIED when the status is ON_QA.

Comment 16 Yuval Turgeman 2017-08-08 06:05:22 UTC
Thanks :)

Comment 17 Huijuan Zhao 2017-08-10 06:33:14 UTC
Change the status to VERIFIED according to Comment 12, Comment 14 and Comment 15.

Comment 18 Sandro Bonazzola 2017-12-20 11:01:25 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.