Description of problem: local configuration files in /etc/vdsm.conf.d are not overriding settings from main configuration file /etc/vdsm.conf Version-Release number of selected component (if applicable): vdsm-4.18.11-1.el7ev.x86_64 How reproducible: always Steps to Reproduce: 1. save file /etc/vdsm/vdsm.conf.d/test.conf [vars] ssl = false 2. run vdsm-tool validate-config 3. ssl is set to true Actual results: command prints SUCCESS: ssl configured to true. No conflicts Expected results: command should print FAILED: conflicting vdsm and libvirt-qemu tls configuration. vdsm.conf with ssl=False requires the following changes: libvirtd.conf: listen_tcp=1, auth_tcp="none", listen_tls=0 qemu.conf: spice_tls=0. Modules libvirt contains invalid configuration Error: Config is not valid. Check conf files Additional info: if I comment in /etc/vdsm.conf #ssl = true ssl is then set to false from test.conf
I tried to reproduce the bug with vdsm-4.18.11-1.el7.centos.x86_64 and this is the output I got: [root@lochte ~]# vdsm-tool configure --force /usr/lib/python2.7/site-packages/vdsm/tool/dump_volume_chains.py:28: DeprecationWarning: vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use vdsm.jsonrpcvdscli from vdsm import vdscli Checking configuration status... multipath requires configuration libvirt is not configured for vdsm yet FAILED: conflicting vdsm and libvirt-qemu tls configuration. vdsm.conf with ssl=True requires the following changes: libvirtd.conf: listen_tcp=0, auth_tcp="sasl", listen_tls=1 qemu.conf: spice_tls=1. Running configure... Reconfiguration of certificates is done. Reconfiguration of sebool is done. Reconfiguration of multipath is done. Reconfiguration of passwd is done. Reconfiguration of sanlock is done. Reconfiguration of libvirt is done. Done configuring modules to VDSM. ---- here I changed the configuration to ssl = false: [root@lochte ~]# vim /etc/vdsm/vdsm.conf.d/test.conf --- [root@lochte ~]# vdsm-tool validate-config /usr/lib/python2.7/site-packages/vdsm/tool/dump_volume_chains.py:28: DeprecationWarning: vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use vdsm.jsonrpcvdscli from vdsm import vdscli FAILED: conflicting vdsm and libvirt-qemu tls configuration. vdsm.conf with ssl=False requires the following changes: libvirtd.conf: listen_tcp=1, auth_tcp="none", listen_tls=0 qemu.conf: spice_tls=0. Modules libvirt contains invalid configuration Error: Config is not valid. Check conf files It looks alright to me. Can you try it again and if it reproduces, please attach /var/log/vdsm.log and /var/log/messages?
Tomas, does the migration policies are using this feature for custom vdsm parameters.
@Moran: the migration policies are an another layer above this overriding both the /etc/vdsm.conf.d/ and the /etc/vdsm.conf, but only for couple of parameters (not the ssl for example), so they are not related to this BZ. But if the migration policy does not send anything (e.g. the fallback policy is used) than the standard vdsm mechanism is used to get the property, so should work as expected. Honestly, never tried it, but if it does not work, than no property will work, not just the migration ones.
Created attachment 1193547 [details] vdsm.log
Created attachment 1193548 [details] messages.log
I have the main installation without any changes in config files # cat vdsm.conf [vars] ssl = true [addresses] management_port = 54321 and ssl = false in test.conf # vdsm-tool configure --force /usr/lib/python2.7/site-packages/vdsm/tool/dump_volume_chains.py:28: DeprecationWarning: vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use vdsm.jsonrpcvdscli from vdsm import vdscli Checking configuration status... Current revision of multipath.conf detected, preserving libvirt is already configured for vdsm FAILED: conflicting vdsm and libvirt-qemu tls configuration. vdsm.conf with ssl=True requires the following changes: libvirtd.conf: listen_tcp=0, auth_tcp="sasl", listen_tls=1 qemu.conf: spice_tls=1. Running configure... Reconfiguration of libvirt is done. Done configuring modules to VDSM. logs attached
verified in vdsm-4.18.13-1.el7ev.x86_64