Bug 1369129 - Documentation of conditional packages
Summary: Documentation of conditional packages
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: comps
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dennis Gilmore
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1336879
TreeView+ depends on / blocked
 
Reported: 2016-08-22 14:20 UTC by Michal Luscon
Modified: 2018-05-29 11:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-05-29 11:47:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michal Luscon 2016-08-22 14:20:14 UTC
According to discussion in #1336879, the documentation of conditional packages at https://pagure.io/fedora-comps is not correct. Please provide us an updated documentation in order to proceed further with #1336879.

Comment 1 Kevin Fenzi 2016-08-23 22:23:51 UTC
Well, looking at the blocking bug the question here is more a clarification right? 

IMHO, if the required packages is currently installed or in the current proposed group transaction then the conditional package should also be installed.

Comment 2 Michal Luscon 2016-09-09 10:14:31 UTC
Yes, first of all it's about clarification. On the other hand, this turned out to be quite important feature which can't stay undocumented.

> IMHO, if the required packages is currently installed or in the current
> proposed group transaction then the conditional package should also be
> installed.

So you basically mean that during the installation of group A and B the group members are checked for presence of required pkgs. And conditional packages are consequently added into transaction if some other group in transaction contains their requirements, right? Please be aware that this happens before resolving and does not take into account mixing group and pkg installation (dnf install pkg @group).

Comment 3 Dennis Gilmore 2016-09-10 01:56:24 UTC
Lets take an example from comps
<packagereq type="conditional" requires="xorg-x11-server-Xorg">ibus-m17n</packagereq>

I have rread through yum/comps.py for some background knowledge 

yum/__init__.py has 
            if not lupgrade and group_conditionals:
                for condreq, cond in thisgroup.conditional_packages.iteritems():
                    if self.isPackageInstalled(cond):
                        try:
                            txmbrs = self.install(name = condreq)
                        except Errors.InstallError:
                            # we don't care if the package doesn't exist
                            continue
                        else:
                            if cond not in self.tsInfo.conditionals:
                                self.tsInfo.conditionals[cond]=[]


which I read as if group_conditionals is enabled, it can be enabled or not.
if xorg-x11-server-Xorg is in the transaction then we should try and install ibus-m17n

I did not dig into the code to see if txmbrs is only packages in the transaction or includes packages that are already installed. but I am assuming the former.


Fully documenting comps will take a lot of work and effort that is useful but I do not know of many people with the knowledge of it or the time to do the work. It does need to be done but it will involve digging throough yum's code to document all the corner cases. If you have some resources to do that work it would be appreciated.

Comment 4 Adam Williamson 2016-09-10 05:53:42 UTC
notting would be the obvious person to ask, since comps was always his baby...

Comment 5 Adam Williamson 2016-09-10 06:00:33 UTC
my understanding of 'conditional' for comps, FWIW, is this. If a package 'foo' is in comps group 'A' and it is marked as 'conditional' for package 'bar', that means that 'foo' should also be installed if *both* group 'A' is selected for install *and* package 'bar' is selected for install (or already installed).

Comment 6 Fedora End Of Life 2017-02-28 10:08:20 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 7 Fedora End Of Life 2018-05-03 08:02:58 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 8 Fedora End Of Life 2018-05-29 11:47:58 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.