Bug 1369227 - Review Request: pcollections - A Persistent Java Collections Library
Summary: Review Request: pcollections - A Persistent Java Collections Library
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alexander Kurtakov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-JAVASIG 1369232
TreeView+ depends on / blocked
 
Reported: 2016-08-22 17:51 UTC by gil cattaneo
Modified: 2016-08-23 08:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
akurtako: fedora-review?


Attachments (Terms of Use)

Description gil cattaneo 2016-08-22 17:51:38 UTC
Spec URL: https://gil.fedorapeople.org/pcollections.spec
SRPM URL: https://gil.fedorapeople.org/pcollections-2.1.2-1.fc24.src.rpm
Description:
PCollections serves as a persistent and immutable analogue of the
Java Collections Framework. This includes efficient, thread-safe,
generic, immutable, and persistent stacks, maps, vectors, sets, and
bags, compatible with their Java Collections counterparts.
Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15339948

Comment 1 Alexander Kurtakov 2016-08-23 07:46:03 UTC
I'll do this one.

Comment 2 Alexander Kurtakov 2016-08-23 08:13:12 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
    32 files have   unknown license. Practically all files in src/main have no license header is what is important. Please contact upstream to fix that.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: pcollections-2.1.2-1.fc26.noarch.rpm
          pcollections-javadoc-2.1.2-1.fc26.noarch.rpm
          pcollections-2.1.2-1.fc26.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
2 packages and 0 specfiles checked; 0 errors, 0 warnings.



Requires
--------
pcollections (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools

pcollections-javadoc (rpmlib, GLIBC filtered):
    javapackages-tools



Provides
--------
pcollections:
    mvn(org.pcollections:pcollections)
    mvn(org.pcollections:pcollections:pom:)
    pcollections

pcollections-javadoc:
    pcollections-javadoc



Source checksums
----------------
https://github.com/pcollections/pcollections/archive/v2.1.2/pcollections-2.1.2.tar.gz :
  CHECKSUM(SHA256) this package     : 05148c95b3aa10af3eae275e5fbb3fabe3199eb02bed22c0cbde3ee9ce2b3911
  CHECKSUM(SHA256) upstream package : 05148c95b3aa10af3eae275e5fbb3fabe3199eb02bed22c0cbde3ee9ce2b3911

ISSUES remaining:
* Missing license headers in source files. Please contact upstream to get that fixed.

Comment 3 gil cattaneo 2016-08-23 08:26:04 UTC
(In reply to Alexander Kurtakov from comment #2)

> [!]: License field in the package spec file matches the actual license.
>     32 files have   unknown license. Practically all files in src/main have
> no license header is what is important. Please contact upstream to fix that.

> ISSUES remaining:
> * Missing license headers in source files. Please contact upstream to get
> that fixed.

Open https://github.com/hrldcpr/pcollections/issues/42
and commented in the spec file

Spec URL: https://gil.fedorapeople.org/pcollections.spec
SRPM URL: https://gil.fedorapeople.org/pcollections-2.1.2-1.fc24.src.rpm


Note You need to log in before you can comment on or make changes to this bug.