Bug 1369235 - main/sub tab action buttons added by UI plugins are not shown
Summary: main/sub tab action buttons added by UI plugins are not shown
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: future
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.4
: 4.0.4
Assignee: Vojtech Szocs
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-22 18:53 UTC by Vojtech Szocs
Modified: 2016-09-26 12:41 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-09-26 12:41:43 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
oourfali: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)
Test UI plugin (458 bytes, application/octet-stream)
2016-08-22 19:02 UTC, Vojtech Szocs 		no flags Details
button UI plugin (16.31 KB, image/png)
2016-09-06 16:09 UTC, Pavel Novotny 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 62289 0 master MERGED webadmin: Bind PluginActionButtonHandler as eager singleton 2016-08-25 08:43:39 UTC
oVirt gerrit 62819 0 ovirt-engine-4.0 MERGED webadmin: Bind PluginActionButtonHandler as eager singleton 2016-08-26 07:38:56 UTC

Description Vojtech Szocs 2016-08-22 18:53:44 UTC 
Description of problem:

With recent changes in oVirt UI plugin infra [1], there seems to be an issue where main/sub tab action buttons added by UI plugins are not shown at all.

[1] https://gerrit.ovirt.org/#/c/60666/

Steps to Reproduce:
1. Write a UI plugin that calls api.addMainTabActionButton() and/or api.addSubTabActionButton() within its UiInit callback.
2. Open WebAdmin UI and switch to the relevant main/sub tab.

Actual results:

Custom action buttons are not shown.

Expected results:

Custom action buttons should be shown.
Comment 1 Vojtech Szocs 2016-08-22 19:02:32 UTC 
Created attachment 1193066 [details]
Test UI plugin
Comment 2 Vojtech Szocs 2016-08-22 19:03:31 UTC 
Attached test UI plugin that adds "Click me!" button on "Data Center" main tab.
Comment 3 Vojtech Szocs 2016-08-22 19:05:22 UTC 
The fix is trivial and should be backported into 4.0 as well.
Comment 4 Pavel Novotny 2016-09-06 16:08:02 UTC 
Verified in
ovirt-engine-webadmin-portal-4.0.4-0.1.el7ev.noarch
rhevm-4.0.4-0.1.el7ev.noarch

Verification steps:
1. Install Vojta's test UI plugin from attachment 1193066 [details].
2. Open or reload Webadmin page and go to Data Centers tab.

Result: "Click me!" action button is shown on the main tab. 
See screenshot attached.
Comment 5 Pavel Novotny 2016-09-06 16:09:00 UTC 
Created attachment 1198342 [details]
button UI plugin
Note You need to log in before you can comment on or make changes to this bug.