Spec URL: https://gil.fedorapeople.org/jackson-datatype-jdk8.spec SRPM URL: https://gil.fedorapeople.org/jackson-datatype-jdk8-2.7.6-1.fc24.src.rpm Description: Project for Jackson module that adds supports for JDK datatypes included in version 8 which can not be directly supported by core databind due to baseline being JDK 6, excluding following: * New Date types are supported by JSR-310 module * Support for parameter names is via Parameter Names module Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15340854 Wildfly 10+ dependency
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ------ - The same problem with license and URL as in #1369244 ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 31 files have unknown license. Detailed output of licensecheck in /home/msimacek/reviews/1369248-jackson- datatype-jdk8/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jackson- datatype-jdk8-javadoc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jackson-datatype-jdk8-2.7.6-1.fc26.noarch.rpm jackson-datatype-jdk8-javadoc-2.7.6-1.fc26.noarch.rpm jackson-datatype-jdk8-2.7.6-1.fc26.src.rpm jackson-datatype-jdk8.noarch: W: spelling-error %description -l en_US datatypes -> datatype, data types, data-types jackson-datatype-jdk8.noarch: W: spelling-error %description -l en_US databind -> data bind, data-bind, database jackson-datatype-jdk8.noarch: W: invalid-url URL: http://wiki.fasterxml.com/JacksonHome <urlopen error [Errno 111] Connection refused> jackson-datatype-jdk8-javadoc.noarch: W: invalid-url URL: http://wiki.fasterxml.com/JacksonHome <urlopen error [Errno 111] Connection refused> jackson-datatype-jdk8.src: W: spelling-error %description -l en_US datatypes -> datatype, data types, data-types jackson-datatype-jdk8.src: W: spelling-error %description -l en_US databind -> data bind, data-bind, database jackson-datatype-jdk8.src: W: invalid-url URL: http://wiki.fasterxml.com/JacksonHome <urlopen error [Errno 111] Connection refused> 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- jackson-datatype-jdk8-javadoc.noarch: W: invalid-url URL: http://wiki.fasterxml.com/JacksonHome HTTP Error 503: Service Unavailable jackson-datatype-jdk8.noarch: W: spelling-error %description -l en_US datatypes -> datatype, data types, data-types jackson-datatype-jdk8.noarch: W: spelling-error %description -l en_US databind -> data bind, data-bind, database jackson-datatype-jdk8.noarch: W: invalid-url URL: http://wiki.fasterxml.com/JacksonHome HTTP Error 503: Service Unavailable 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- jackson-datatype-jdk8-javadoc (rpmlib, GLIBC filtered): javapackages-tools jackson-datatype-jdk8 (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.fasterxml.jackson.core:jackson-core) mvn(com.fasterxml.jackson.core:jackson-databind) Provides -------- jackson-datatype-jdk8-javadoc: jackson-datatype-jdk8-javadoc jackson-datatype-jdk8: jackson-datatype-jdk8 mvn(com.fasterxml.jackson.datatype:jackson-datatype-jdk8) mvn(com.fasterxml.jackson.datatype:jackson-datatype-jdk8:pom:) osgi(com.fasterxml.jackson.datatype.jackson-datatype-jdk8) Source checksums ---------------- https://github.com/FasterXML/jackson-datatype-jdk8/archive/jackson-datatype-jdk8-2.7.6.tar.gz : CHECKSUM(SHA256) this package : f1a2deaeed15f79328b9affd740d35ba12b2c41262aa88add0acab587e6fc8bb CHECKSUM(SHA256) upstream package : f1a2deaeed15f79328b9affd740d35ba12b2c41262aa88add0acab587e6fc8bb Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1369248 Buildroot used: rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
(In reply to Michael Simacek from comment #1) > Issues: > ------ > - The same problem with license and URL as in #1369244 unfortunately, even for this package: Upstream it does not provide the original ASL license because as already said several times to (Tatu S.) do not want to increase the size of their libraries in Android environment Spec URL: https://gil.fedorapeople.org/jackson-datatype-jdk8.spec SRPM URL: https://gil.fedorapeople.org/jackson-datatype-jdk8-2.7.6-1.fc24.src.rpm - fix URL field
(In reply to gil cattaneo from comment #2) > (In reply to Michael Simacek from comment #1) > > > Issues: > > ------ > > - The same problem with license and URL as in #1369244 > > > unfortunately, even for this package: > Upstream it does not provide the original ASL license because as already > said several times to (Tatu S.) do not want to increase the size of their > libraries in Android environment Include it as Source1.
Spec URL: https://gil.fedorapeople.org/jackson-datatype-jdk8.spec SRPM URL: https://gil.fedorapeople.org/jackson-datatype-jdk8-2.7.6-1.fc24.src.rpm - add original ASL 20 txt file
Looks ok now, APPROVED
Thanks for the review! create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/7417
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/jackson-datatype-jdk8
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15364584
jackson-datatype-jdk8-2.7.6-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-eb91de5d24
jackson-datatype-jdk8-2.7.6-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-eb91de5d24
jackson-datatype-jdk8-2.7.6-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.