Bug 1369495 - rh-redis32 doesn't implement some LSB functions
Summary: rh-redis32 doesn't implement some LSB functions
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Software Collections
Classification: Red Hat
Component: redis
Version: rh-redis32
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 2.3
Assignee: Remi Collet
QA Contact: Jan Houska
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-23 14:49 UTC by Jakub Prokes
Modified: 2016-11-15 10:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-15 10:16:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:2745 0 normal SHIPPED_LIVE new packages: rh-redis32 2016-11-15 14:57:04 UTC

Description Jakub Prokes 2016-08-23 14:49:18 UTC
Description of problem:
action reload return exit code 1, when redis is running.
and
action force-reload isn't implemented properly or return exit code 3

Version-Release number of selected component (if applicable):
rh-redis32-redis-3.2.1-1.el6.x86_64

How reproducible:
service rh-redis32-redis reload
and
service rh-redis32-redis force-reload

Actual results:
[0 root@qeos-180 init-script-LSB]# service rh-redis32-redis status
redis-server (pid  3510) is running...
[0 root@qeos-180 init-script-LSB]# service rh-redis32-redis reload; echo $?
1
[0 root@qeos-180 init-script-LSB]# service rh-redis32-redis status

[0 root@qeos-180 init-script-LSB]# service rh-redis32-redis force-reload
/etc/init.d/rh-redis32-redis: line 84: force_reload: command not found

Expected results:


Additional info:
http://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

Comment 1 Remi Collet 2016-09-08 09:54:33 UTC
Indeed, redis have no way to be "reload".

What is the better way, remove the option  from the ini script ? (so you will get the "Usage" error message ?

Comment 10 Jan Houska 2016-10-25 09:47:48 UTC
The collection-redis package on rhel-6.7.z and rhel-6.8.z is getting still  wrong error message after calling   "service rh-redis32-redis reload" and  "service rh-redis32-redis force-reload" commands.  


Package version:
:: [ 19:58:20 ] ::   rh-redis32-redis-3.2.3-3.el6.x86_64



Rhel:  6.7.z  and  6.8.z


Test log:
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: implemented operations
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

....

:: [   PASS   ] :: Service have to implement try-restart function (Expected 0,3, got 0)
:: [  BEGIN   ] :: Service have to implement reload function :: actually running 'service rh-redis32-redis reload'
Usage: /etc/init.d/rh-redis32-redis {start|stop|status|restart|condrestart|try-restart}
:: [   FAIL   ] :: Service have to implement reload function (Expected 0,3, got 2)
./runtest.sh: line 56: [: missing `]'
:: [  BEGIN   ] :: Service have to implement force-reload function :: actually running 'service rh-redis32-redis force-reload'
Usage: /etc/init.d/rh-redis32-redis {start|stop|status|restart|condrestart|try-restart}
:: [   FAIL   ] :: Service have to implement force-reload function (Expected 0,3, got 2)
./runtest.sh: line 56: [: missing `]'
'88e51302-9a87-49ab-b603-c4fcd5da63e8'
implemented-operations result: FAIL
   metric: 2
   Log: /var/tmp/beakerlib-47164481/journal.txt
    Info: Searching AVC errors produced since 1477331910.27 (Mon Oct 24 19:58:30 2016)
     Searching logs...
     Info: No AVC messages found.
 Writing to /mnt/testarea/tmp.FGlnRY
:
   AvcLog: /mnt/testarea/tmp.FGlnRY

...

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: TEST PROTOCOL
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   LOG    ] :: Test run ID   : 47164481
:: [   LOG    ] :: Package       : rh-redis32
:: [   LOG    ] :: Installed:    : rh-redis32-2.3-1.el6.x86_64 
:: [   LOG    ] :: Installed:    : rh-redis32-redis-3.2.3-3.el6.x86_64 
:: [   LOG    ] :: Installed:    : rh-redis32-runtime-2.3-1.el6.x86_64 
:: [   LOG    ] :: Installed:    : rh-redis32-scldevel-2.3-1.el6.x86_64 
:: [   LOG    ] :: beakerlib RPM : beakerlib-1.11-1.el6
:: [   LOG    ] :: bl-redhat RPM : beakerlib-redhat-1-16.el6eso
:: [   LOG    ] :: Test started  : 2016-10-24 19:58:15 CEST
:: [   LOG    ] :: Test finished : 2016-10-24 19:58:55 CEST
:: [   LOG    ] :: Test name     : /CoreOS/rh-redis32/Sanity/init-script-LSB
:: [   LOG    ] :: Distro:       : Red Hat Enterprise Linux Server release 6.7 (Santiago)
:: [   LOG    ] :: Hostname      : sheep-22.lab.eng.brq.redhat.com
:: [   LOG    ] :: Architecture  : x86_64

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: Test description
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

PURPOSE of /CoreOS/rh-redis32/Sanity/init-script-LSB
Description: Test for BZ#1353983 (RFE add collection for Redis 3.2)
Author: Jakub Prokes <jprokes>
Bug summary: RFE: add collection for Redis 3.2
Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1353983

Comment 13 Jan Houska 2016-10-31 15:24:21 UTC
Verified.

Component Packages:
rh-redis32-redis-3.2.4-1.el6.x86_64
rh-redis32-redis-3.2.4-1.el7.x86_64

Product versions:
RHEL-6.8 Server x86_64
RHEL-6.7 Server x86_64
RHEL-7.2 Server x86_64


LOG:
:: [   PASS   ] :: Service have to implement try-restart function (Expected 0,3, got 0)
:: [   PASS   ] :: Service have to implement reload function (Expected 0,3, got 3)
:: [   PASS   ] :: Service have to implement force-reload function (Expected 0,3, got 3)
:: [   LOG    ] :: Duration: 21s
:: [   LOG    ] :: Assertions: 8 good, 0 bad
:: [   PASS   ] :: RESULT: implemented operations

Comment 15 errata-xmlrpc 2016-11-15 10:16:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2745.html


Note You need to log in before you can comment on or make changes to this bug.