Bug 1369524 - segment fault while join thread reaper_thr in fini()
Summary: segment fault while join thread reaper_thr in fini()
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: upcall
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ryan Ding
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1371194 1371196 1384460
TreeView+ depends on / blocked
 
Reported: 2016-08-23 16:23 UTC by Ryan Ding
Modified: 2017-03-27 18:22 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.9.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1371194 1371196 (view as bug list)
Environment:
Last Closed: 2017-03-27 18:22:53 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Ryan Ding 2016-08-23 16:23:42 UTC
Description of problem:

reaper_thr thread may not be started according to option 'cache-invalidation', if it's not started, the following code in fini() will cause segment fault:

        priv->fini = 1; 

        pthread_join (priv->reaper_thr, NULL);

Comment 1 Worker Ant 2016-08-23 16:30:26 UTC
REVIEW: http://review.gluster.org/15298 (features/upcall: segment fault while join thread reaper_thr in fini()) posted (#1) for review on master by Anonymous Coward

Comment 2 Worker Ant 2016-08-25 20:50:09 UTC
REVIEW: http://review.gluster.org/15298 (features/upcall: segment fault while join thread reaper_thr in fini()) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 3 Worker Ant 2016-08-29 12:13:54 UTC
COMMIT: http://review.gluster.org/15298 committed in master by Jeff Darcy (jdarcy) 
------
commit 7f0042dce94edb58c92662d9e4f852ba006d12dc
Author: Ryan Ding <ryan.ding>
Date:   Wed Aug 24 00:24:30 2016 +0800

    features/upcall: segment fault while join thread reaper_thr in fini()
    
    reaper_thr thread may not be started according to option
    'cache-invalidation', if it's not started, join it in fini will cause a
    segment fault.
    
    Change-Id: I1c145a5feb137767880a08e79f810537283fb6b9
    BUG: 1369524
    Signed-off-by: Ryan Ding <ryan.ding>
    [ndevos: check .reaper_init_done and make it a boolean]
    Reviewed-on: http://review.gluster.org/15298
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>

Comment 4 Shyamsundar 2017-03-27 18:22:53 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.