Bug 1369714 - nfs-server-generator segfaults when /etc/fstab does not exist
Summary: nfs-server-generator segfaults when /etc/fstab does not exist
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nfs-utils
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Steve Dickson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-24 08:31 UTC by Yu Watanabe
Modified: 2016-09-04 22:51 UTC (History)
5 users (show)

Fixed In Version: nfs-utils-1.3.4-1.rc2.fc24 nfs-utils-1.3.4-1.rc2.fc25 nfs-utils-1.3.4-1.rc2.fc23
Clone Of:
Environment:
Last Closed: 2016-08-29 18:52:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
generator-fix-segfault-when-fstab-does-not-exist.patch (453 bytes, patch)
2016-08-24 08:31 UTC, Yu Watanabe
no flags Details | Diff

Description Yu Watanabe 2016-08-24 08:31:56 UTC
Created attachment 1193520 [details]
generator-fix-segfault-when-fstab-does-not-exist.patch

Description of problem:

if /etc/fstab does not exist, nfs-server-generator crashes.
=====
kernel: nfs-server-gene[599]: segfault at 0 ip 00007f135061018b sp 00007ffc41ff7ad0 error 4 in libc-2.23.so[7f135059a000+1b9000]
systemd[589]: /usr/lib/systemd/system-generators/nfs-server-generator terminated by signal SEGV.
=====

Version-Release number of selected component (if applicable):

nfs-utils-1.3.4-1.rc1.fc24.x86_64

How reproducible:

always

Steps to Reproduce:
1. boot system which does not have /etc/fstab.
2.
3.

Actual results:

nfs-server-generator segfaults.

Expected results:

nfs-server-generator run as expected.

Additional info:

I think this bug can be fixed by the attached patch.

Comment 1 Steve Dickson 2016-08-24 13:58:56 UTC
The upstream commit:

commit 21c3ca72fb1b3b4aea30b7cc4989b23daf6bd2dd
Author: Yu Watanabe <watanabe.yu+redhat.bugzilla>
Date:   Wed Aug 24 09:15:34 2016 -0400

    nfs-server-generator: Fix segfault when /etc/fstab does not exist
    
    Added a couple checks to handle failures correctly
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1369714
    Signed-off-by: Steve Dickson <steved>

Comment 2 Fedora Update System 2016-08-26 12:08:53 UTC
nfs-utils-1.3.4-1.rc2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a94a72af2b

Comment 3 Fedora Update System 2016-08-26 12:09:22 UTC
nfs-utils-1.3.4-1.rc2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5f19497102

Comment 4 Fedora Update System 2016-08-26 12:09:45 UTC
nfs-utils-1.3.4-1.rc2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a8cab6d575

Comment 5 Fedora Update System 2016-08-27 12:53:35 UTC
nfs-utils-1.3.4-1.rc2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a8cab6d575

Comment 6 Fedora Update System 2016-08-27 21:50:29 UTC
nfs-utils-1.3.4-1.rc2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5f19497102

Comment 7 Fedora Update System 2016-08-27 22:22:16 UTC
nfs-utils-1.3.4-1.rc2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a94a72af2b

Comment 8 Fedora Update System 2016-08-29 18:52:14 UTC
nfs-utils-1.3.4-1.rc2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-08-30 18:17:22 UTC
nfs-utils-1.3.4-1.rc2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-09-04 22:51:31 UTC
nfs-utils-1.3.4-1.rc2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.