Bug 1369716 – Checkpoint/rollback improvements

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1369716 - Checkpoint/rollback improvements

Summary:	Checkpoint/rollback improvements

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	NetworkManager (Show other bugs)
Sub Component:
Version:	7.4
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	rc
Target Release:	---
Assigned To:	Beniamino Galvani
QA Contact:	Desktop QE
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-08-24 04:36 EDT by Beniamino Galvani
Modified:	2017-08-01 05:17 EDT (History)
CC List:	9 users (show)

See Also:
Fixed In Version:	NetworkManager-1.8.0-0.2.git20170215.1d40c5f4.el7
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-08-01 05:17:07 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
GNOME Bugzilla	770315	None	None	None	2016-08-24 04:36 EDT
Red Hat Product Errata	RHSA-2017:2299	normal	SHIPPED_LIVE	Moderate: NetworkManager and libnl3 security, bug fix and enhancement update	2017-08-01 08:40:28 EDT

Groups: None (edit)

Description Beniamino Galvani 2016-08-24 04:36:10 EDT

Better handle unrealized/unmanaged devices. See the upstream bugzilla for more details.

https://bugzilla.gnome.org/show_bug.cgi?id=770315

Comment 2 Beniamino Galvani 2016-09-27 05:31:09 EDT

Merged upstream:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=d27ae4a8fec0c8f21a7171e01535f8beb8e5b105

Comment 5 Beniamino Galvani 2017-03-20 10:38:44 EDT

The rollback now restores the previous unmanaged status of a
device. For example, if you perform a checkpoint on eth0, then set
'nmcli device modify eth0 managed no', the rollback should make it
managed again.

The branch also fixes the case in which a software device is
snapshotted and then removed. The rollback now should recreate the
device.

Also, passing an empty list to the snapshot functionality is
equivalent to passing all devices (including unmanaged ones).

There are a lot possible scenarios and so testing everything is
probably difficult. Here is a list in non-increasing importance order
of what could be tested:

 - checkpoint with no timeout, manual rollback
 - checkpoint with timeout, automatic rollback
 - checkpoint/rollback of multiple devices
 - global checkpoint (all devices)
 - check that the explicitly-unmanaged status of a device is restored
   upon rollback
 - check that software devices are recreated on rollback
 - checkpoint flags [1]

[1] https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/libnm-core/nm-dbus-interface.h?id=714504faf27c74a9b26e0f1d4f8bdaff7bb24181#n807

Comment 6 errata-xmlrpc 2017-08-01 05:17:07 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:2299

Note You need to log in before you can comment on or make changes to this bug.