Bug 1371036 - pronterface UI is badly mangled / Gtk warnings about negative sizes
Summary: pronterface UI is badly mangled / Gtk warnings about negative sizes
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: printrun
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-29 08:38 UTC by Klaus Pedersen
Modified: 2017-08-08 16:53 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-08 16:53:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Screenshot of pronterface with clean .rc file (76.04 KB, image/jpeg)
2016-08-29 08:38 UTC, Klaus Pedersen
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kliment Printrun issues 768 0 None None None 2016-08-29 08:38:12 UTC

Description Klaus Pedersen 2016-08-29 08:38:12 UTC
Created attachment 1195213 [details]
Screenshot of pronterface with clean .rc file

Description of problem:

Fedora 24: pronterface UI is badly mangled / Gtk warnings about negative sizes.

Both printrun git and the version in F24 (2015.03.10-4.fc24) have a seriously mangled UI (to the point of being unusable).

The program continuously spew gtk messages about unexpected negative values.



How reproducible:

Always


Steps to Reproduce:
1. Launch program and enjoy


Actual results:

Seriously mangled UI and continuous spew of the following Gtk messages:

(pronterface.py:1793): Gtk-CRITICAL **: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkSpinButton
(pronterface.py:1793): Gtk-WARNING **: Negative content width -12 (allocation 22, extents 17x17) while allocating gadget (node button, owner GtkButton)
(pronterface.py:1793): Gtk-WARNING **: Negative content width -15 (allocation 19, extents 17x17) while allocating gadget (node button, owner GtkButton)
(pronterface.py:1793): Gtk-WARNING **: Negative content width -17 (allocation 1, extents 9x9) while allocating gadget (node entry, owner GtkEntry)




Additional info:

Reported upstream in: https://github.com/kliment/Printrun/issues/768

Comment 1 Miro Hrončok 2016-08-31 13:16:51 UTC
Scott, could you please help?

Comment 2 Scott Talbert 2016-08-31 13:20:28 UTC
Sure, I will take a look tonight.

Comment 3 Scott Talbert 2016-09-04 02:39:26 UTC
I can understand the Gtk errors.  Can you explain in more detail what you mean by 'mangled UI?'  What specifically is mangled?

Comment 4 Klaus Pedersen 2016-09-04 16:07:21 UTC
As you can see on the attached screenshot:

* up/down buttons to the right of input fields overlap with other content.
* There are 3 unmarked blank boxes, at seemingly random positions.


Compare to:

https://github.com/kliment/Printrun/blob/master/screenshots/pronterface.png

Comment 5 Scott Talbert 2016-09-04 17:43:37 UTC
(In reply to Klaus Pedersen from comment #4)
> As you can see on the attached screenshot:
> 
> * up/down buttons to the right of input fields overlap with other content.
> * There are 3 unmarked blank boxes, at seemingly random positions.
> 
> 
> Compare to:
> 
> https://github.com/kliment/Printrun/blob/master/screenshots/pronterface.png

Are you running with the Fedora patch?  The SpinCtrl boxes should be sized correctly with the Fedora patch.

Also, I don't understand what is meant by "3 unmarked blank boxes."  Can you point them out by circling them on a screenshot?

Comment 6 markusN 2016-11-05 17:24:16 UTC
(In reply to Scott Talbert from comment #5)
> Are you running with the Fedora patch?  The SpinCtrl boxes should be sized
> correctly with the Fedora patch.

What is this Fedora patch? We have a similar problem in GRASS GIS - g.gui - 3D viewer.

Comment 7 Scott Talbert 2016-11-06 02:23:46 UTC
(In reply to markusN from comment #6)
> (In reply to Scott Talbert from comment #5)
> > Are you running with the Fedora patch?  The SpinCtrl boxes should be sized
> > correctly with the Fedora patch.
> 
> What is this Fedora patch? We have a similar problem in GRASS GIS - g.gui -
> 3D viewer.

It's a pronterface specific patch, mainly to make the SpinButtons bigger:
http://pkgs.fedoraproject.org/cgit/rpms/printrun.git/tree/printrun-gtk3.patch

Comment 8 markusN 2016-11-07 10:36:36 UTC
It seems that the solution for GRASS GIS would be the same, to make the SpinButtons bigger: 
https://trac.osgeo.org/grass/attachment/ticket/3201/spinctrl.diff

The issue is: if all projects using SpinCtrl have to change their button sizes, wouldn't it be better to fix Fedora's wxPython3 package? Our developers on Ubuntu do not have such issues.

(I can also open a separate bug report for this if better)

Comment 9 Scott Talbert 2016-11-07 14:00:21 UTC
(In reply to markusN from comment #8)
> It seems that the solution for GRASS GIS would be the same, to make the
> SpinButtons bigger: 
> https://trac.osgeo.org/grass/attachment/ticket/3201/spinctrl.diff
> 
> The issue is: if all projects using SpinCtrl have to change their button
> sizes, wouldn't it be better to fix Fedora's wxPython3 package? Our
> developers on Ubuntu do not have such issues.
> 
> (I can also open a separate bug report for this if better)

The SpinButton sizing thing cannot be fixed in wxPython - it has to be fixed in individual applications.  This is really a problem because the underlying GTK SpinButton widget is much wider in GTK+3 than it is in GTK+2.

Compare these two and you will see the problem:
https://developer.gnome.org/gtk2/stable/GtkSpinButton.html
https://developer.gnome.org/gtk3/stable/GtkSpinButton.html

The reason you do not see it under Ubuntu is that Ubuntu's wxPython package still uses GTK+2.

Comment 10 markusN 2016-11-08 21:55:00 UTC
Thanks for your explanations, we have now fixed it in GRASS GIS.

Comment 11 markusN 2016-11-08 22:47:11 UTC
(In reply to markusN from comment #10)
> Thanks for your explanations, we have now fixed it in GRASS GIS.

For the record: the related update (maybe of use elsewhere):
https://trac.osgeo.org/grass/browser/grass/branches/releasebranch_7_2/gui/wxpython/gui_core/wrap.py

Comment 12 Fedora End Of Life 2017-07-25 22:43:26 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 13 Fedora End Of Life 2017-08-08 16:53:51 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.