Spec URL: https://free-astro.org/download/fedora/SPECS/siril.spec SRPM URL: https://free-astro.org/download/fedora/SRPMS/siril-0.9.4-1.fc24.src.rpm Description: Siril is an image processing tool specially tailored for noise reduction and improving the signal/noise ratio of an image from multiple captures, as required in astronomy. It depends on ffms2 library which is not in fedora repositories but can be found here: http://koji.russianfedora.pro/koji/buildinfo?buildID=3691 An old and unmaintained version of siril is always here: https://www.rpmfind.net/linux/RPM/fedora/23/i386/s/siril-0.8-20.fc23.i686.html. This version should be removed or at least updated to the new one.
Unfortunately ffms2 can't be put into fedora as it requires ffmpeg. Hence I'm closing this review request. Feel free to submit this package to Russian Fedora or RPM Fusion! I would be happy to help.
Where can I submit to RPM Fusion ?
Is ffms2 really required? We have this old version 0.8 in offifial repo, would be nice if it could be updated… But as Igor mentioned: ffmpeg would be a blocker
Seems to be possible to build without ffms2 => I'll investigate for an update
(In reply to Christian Dersch from comment #4) > Seems to be possible to build without ffms2 => I'll investigate for an update Too late, I'll ask to https://bugzilla.rpmfusion.org/show_bug.cgi?id=4224 I'm one of the developer, and YES ffms2 is needed even if we can compile without it. Moreover, next release will use ffmpeg libraries for some features. So the best thing to do now, is to orphan this old, very old 0.8 version.
Well, according to http://free-astro.org/index.php/Siril:install#Dependencies ffms2 is optional? I can do the rework and update for Fedora, but only without problematic stuff. In this way it can pe part of Fedora Astronomy Spin, otherwise I have to remove it from there… Adding the nonfree extensions as some kind of plugin as rpmfusion package is not possible?
(In reply to Christian Dersch from comment #6) > Well, according to > http://free-astro.org/index.php/Siril:install#Dependencies ffms2 is > optional? > > I can do the rework and update for Fedora, but only without problematic > stuff. In this way it can pe part of Fedora Astronomy Spin, otherwise I have > to remove it from there… Sure, it is optional for compilation. When compiling, user can choose which part he wants in order to optimize the software. But for packages I want the whole piece. > Adding the nonfree extensions as some kind of > plugin as rpmfusion package is not possible? I don't think it's possible without changing to much code. I really understand that ffms2 is a problematic stuff, but as I said, it is getting worst in next release with new dependencies with ffmpeg libraries. And without ffms2, user can't open planetary avi file to work with. So, I think that the best way is to try to review the package in rpm fusion and to remove the 0.8 version from Fedora. Indeed, this version is not really usable and should not be downloadable in modern distribution.
I'm sorry for that by the way, but i did not know that before asking for the package review.
(In reply to cyril from comment #7) > > So, I think that the best way is to try to review the package in rpm fusion > and to remove the 0.8 version from Fedora. Indeed, this version is not > really usable and should not be downloadable in modern distribution. Well, I think there should be an up to date version in official Fedora, even if it misses some features. I'm really happy to see that siril is alive and IMHO it is a great software for astronomical image processing, especially for amateur astronomers. Thats why I want to have it in Fedora Astronomy as an official feature. IMHO the best solution would be siril in Fedora and siril-freeworld in rpmfusion providing the problematic stuff too. We are not the first packagers in that situation, confirm https://pkgs.rpmfusion.org/cgit/free/audacity-freeworld.git/tree/ vs You can also add an advice at your homepage then that users should get that package instead of Fedoras siril to get all functions. I can also add a hint to package description in our package that the Fedora version misses some features due to Fedora guidelines (to make clear it is not your fault). Win-Win situation IMHO, you can provide a full featured version via repositories and we have a free version in Fedora to provide a nice Fedora Astronomy experience (and siril there would be also an advertisement for your project).
Hello Christian. You convinced me. Let's do it. However, current code does not permit to add a plugin in RPM Fusion. We will think about that on next release (0.9.5). So could you do rework and update for Fedora the current version (0.9.4) ?
Yes, I'll take care of that, nice!
(In reply to Christian Dersch from comment #11) > Yes, I'll take care of that, nice! Thank you so much. What is the url where I can check the status ?
Done, as you can see here I mostly used your spec to rework the package :) http://pkgs.fedoraproject.org/cgit/rpms/siril.git/tree/siril.spec Builds are running, I'll submit updates for Fedora 24 and 25 to get 0.9.4 there :)
https://bodhi.fedoraproject.org/updates/FEDORA-2016-99c6b31855 https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4a425ce77
siril-0.9.4-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4a425ce77
siril-0.9.4-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-99c6b31855
siril-0.9.4-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
siril-0.9.4-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Hello Christian. There is a new upstream version: https://free-astro.org/download/siril-0.9.5.tar.bz2 Dependency to libgif has been removed but new dependencies to libffmpeg has been added. But do not worry, these dependencies are not mandatory. Should I open a new issue when update is necessary ? Best regards,
Yes, please open new issues for new updates, thanks :) 0.9.5 will be imported today.