Bug 1371761 - sfdisk return code breaks growpart
Summary: sfdisk return code breaks growpart
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: util-linux
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karel Zak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1374968 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-31 03:23 UTC by Ian Wienand
Modified: 2016-09-13 22:23 UTC (History)
3 users (show)

Fixed In Version: util-linux-2.28.2-1.fc25 util-linux-2.28.2-1.fc24
Clone Of:
Environment:
Last Closed: 2016-09-13 22:23:29 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Ian Wienand 2016-08-31 03:23:46 UTC 
The change "sfdisk: exit with error if rereading partition table fails" [1] appears to have broken the growpart utility from cloud-init [2].  This utility checks the return value of sfdisk when growing the root partition and the change in status makes it error out and revert the change, hence not growing the disk.

This change was reverted with [3] but is not in the current 2.28.1 release

I've made a custom build in copr with this patch [4] and growpart does work with this to expand the root partition.

[1] https://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/disk-utils/sfdisk.c?id=14f644f386a1708483ed446e983c0976e3976a9d
[2] http://pkgs.fedoraproject.org/cgit/rpms/cloud-init.git/
[3] https://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/disk-utils/sfdisk.c?id=78e7f78896f2c9cf1b2615c8c555a64dcd9d2642
[4] https://copr.fedorainfracloud.org/coprs/iwienand/util-linux/
Comment 1 Karel Zak 2016-08-31 09:15:35 UTC 
Ah... this is stupid mistake that we have the patch in 2.28.1. Sorry.

I'm going to revert and release version 2.28.2 ASAP (next week).
Comment 2 Fedora Update System 2016-09-08 08:50:27 UTC 
util-linux-2.28.2-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6eccd2007b
Comment 3 Fedora Update System 2016-09-08 14:40:49 UTC 
util-linux-2.28.2-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-231848214c
Comment 4 Fedora Update System 2016-09-09 06:25:00 UTC 
util-linux-2.28.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-231848214c
Comment 5 Dusty Mabe 2016-09-11 04:44:14 UTC 
*** Bug 1374968 has been marked as a duplicate of this bug. ***
Comment 6 Fedora Update System 2016-09-12 13:17:52 UTC 
util-linux-2.28.2-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2016-09-12 15:28:02 UTC 
util-linux-2.28.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6eccd2007b
Comment 8 Fedora Update System 2016-09-13 22:23:27 UTC 
util-linux-2.28.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.