Bug 1371893 - sparkline for CPU shows some changes, but tooltip says 0%
Summary: sparkline for CPU shows some changes, but tooltip says 0%
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dashboard
Classification: oVirt
Component: General
Version: unspecified
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.0.6
: 1.0.6
Assignee: Scott Dickerson
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
: 1371919 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-31 11:43 UTC by Lucie Leistnerova
Modified: 2017-01-18 07:25 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-18 07:25:29 UTC
oVirt Team: UX
rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
oourfali: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)
sparkline CPU (182.41 KB, image/png)
2016-08-31 11:43 UTC, Lucie Leistnerova
no flags Details
still_0 (17.67 KB, image/png)
2016-10-27 08:09 UTC, Lucie Leistnerova
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 63508 0 master MERGED update percent and number formatting to use Intl API 2016-10-10 15:51:18 UTC
oVirt gerrit 65316 0 ovirt-engine-dashboard-1.0 MERGED update percent and number formatting to use Intl API 2016-10-10 16:03:15 UTC
oVirt gerrit 65925 0 master POST Tooltip for sparkline chart handle values (0 .. 0.1%] 2016-11-01 13:07:38 UTC
oVirt gerrit 66059 0 ovirt-engine-dashboard-1.0 POST Tooltip for sparkline chart handle values (0 .. 0.1%] 2016-11-03 20:50:33 UTC

Description Lucie Leistnerova 2016-08-31 11:43:55 UTC
Created attachment 1196323 [details]
sparkline CPU

Description of problem:
on sparkline for CPU are drawn some changes, but the tooltip says 0%

Version-Release number of selected component (if applicable):
ovirt-engine-dashboard-1.0.3-1.el7ev.x86_64

How reproducible: always


Steps to Reproduce:
1. install new engine or stop all VM for some time (for few hours)
2. create new VM with no OS, assign a disk and run it
3. wait 15-20 minutes and reload the Dashboard

Actual results: sparkline changes and tooltip shows 0%


Expected results: tooltip shows 0.x% or <1%


Additional info:
I assume that the last day values are counted as avarage for sample values for every X minutes and so that is not equal to 1, but its confusing to see always 0%, even if the sparkline changes

Comment 1 Pavel Novotny 2016-08-31 13:59:12 UTC
*** Bug 1371919 has been marked as a duplicate of this bug. ***

Comment 2 Lucie Leistnerova 2016-10-27 08:07:48 UTC
for cpu usage lower than 1 still shows 0.0%

in ovirt-engine-dashboard-1.0.5-1.el7ev.x86_64

Comment 3 Red Hat Bugzilla Rules Engine 2016-10-27 08:07:54 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 4 Lucie Leistnerova 2016-10-27 08:09:11 UTC
Created attachment 1214501 [details]
still_0

Comment 5 Oved Ourfali 2016-10-27 09:51:23 UTC
Greg, can you take a look?

Comment 6 Greg Sheremeta 2016-10-28 05:33:30 UTC
Yes sir

Comment 7 Scott Dickerson 2016-10-31 21:23:17 UTC
The second patch (65925) tests if the percent to be rendered will be greater then 0% but less then 0.1%.  If it is in this range, "<0.1%" will be shown.  If the percent is 0, "0.0%" will be shown.  

This change allows easy differentiation between 0 and a value smaller then the smallest formatted value of "0.1".

Comment 9 Lucie Leistnerova 2016-12-01 13:01:04 UTC
values in cpu tooltips are OK

verified in ovirt-engine-dashboard-1.1.0-0.4.20161128git5ed6f96.el7.centos.noarch


Note You need to log in before you can comment on or make changes to this bug.