Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1371960

Summary:	When extending a storage domain with a new lun, the old information of the lun is saved in the db
Product:	[oVirt] ovirt-engine	Reporter:	Idan Shaby <ishaby>
Component:	BLL.Storage	Assignee:	Idan Shaby <ishaby>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	future	CC:	amureini, bugs, ishaby
Target Milestone:	ovirt-4.1.0-alpha	Flags:	rule-engine: ovirt-4.1+ rule-engine: planning_ack+ amureini: devel_ack+ acanan: testing_ack+
Target Release:	4.1.0.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Previously, when extending a block domain with a new lun, wrong information about this lun was saved in the DB. Thus, when editing the storage domain, the new lun's information that was shown in the view was incorrect. Now we save the right information, and therefore the new lun's information that is shown in the luns view when editing the domain is correct.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-01 14:56:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Idan Shaby 2016-08-31 14:24:03 UTC

Description of problem:
When extending a storage domain with a lun that has an old pv on it, the information of the old pv is saved in the db instead of the information of the new pv.

Version-Release number of selected component (if applicable):
a3d282f36d2a1fd9f8295d9d492f43109c7ef9c5

How reproducible:
100%

Steps to Reproduce:
1. Have an iSCSI target of at least two luns and create a storage domain from the whole target.
2. Destroy the storage domain.
3. Create a storage domain from one of the luns.
4. Extend the storage domain with the other lun.

Actual results:
The other lun's information in the db is not the same as the new lun's information but as the old one's. For example, the physical volume id is the old lun's pv id and not the new one.

Expected results:
The information in the db should be identical to the information in the storage.

Comment 1 Idan Shaby 2016-09-01 10:27:32 UTC

What I explained in the "Description of problem" was only partially right.

When extending a storage domain with ANY lun, we save the old lun's information in the db. So this bug occurs not only with luns that previously had a pv on them.
That is, if a lun had no pv on it before, we will save its pv id as null.

Comment 2 Allon Mureinik 2016-09-12 07:25:01 UTC

Idan, please add some doctext to this BZ.

Comment 3 Sandro Bonazzola 2016-12-12 14:00:40 UTC

The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 4 Kevin Alon Goldblatt 2016-12-14 14:04:43 UTC

Verified with the following code:
---------------------------------------
ovirt-engine-4.1.0-0.2.master.20161212172238.gitea103bd.el7.centos.noarch
vdsm-4.18.999-1147.git951e122.el7.centos.x86_64



Verified with the following scenario:
---------------------------------------
Steps to Reproduce:
1. Have an iSCSI target of at least two luns and create a storage domain from the whole target.
2. Destroy the storage domain.
3. Create a storage domain from one of the luns.
4. Extend the storage domain with the other lun.

Actual results:
All information is updated for the new LUN


Expected results:


Moving to VERIFIED!