RDO tickets are now tracked in Jira https://issues.redhat.com/projects/RDO/issues/
Bug 1372016 - Review Request: openstack-murano-ui - horizon plugin for OpenStack murano
Summary: Review Request: openstack-murano-ui - horizon plugin for OpenStack murano
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: trunk
Assignee: Javier Peña
QA Contact: hguemar
URL:
Whiteboard:
Depends On:
Blocks: RDO-NEWTON
TreeView+ depends on / blocked
 
Reported: 2016-08-31 17:37 UTC by Igor Yozhikov
Modified: 2017-06-18 13:53 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-06-18 13:53:59 UTC
Embargoed:
jpena: rdo-review+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
RDO 2265 0 None None None 2016-09-15 10:59:52 UTC

Description Igor Yozhikov 2016-08-31 17:37:14 UTC
Description of problem:
OpenStack murano dashboard project has not been packaged in rpm for RDO,
but murano services like python-muranoclient, openstack-murano-{engine,api,cf-api}
- are packaged and presented in package repositories.

Version-Release number of selected component (if applicable):
Project git repository: https://github.com/openstack/murano-dashboard 
git tag 3.0.0.0b2
rpm version 3.0.0~b2
Spec URL: https://raw.githubusercontent.com/Iyozhikov/RPMs/master/openstack-murano-ui/openstack-murano-ui-3.0.0~b2.spec
SRPM URL: https://github.com/Iyozhikov/RPMs/raw/master/openstack-murano-ui/openstack-murano-ui-3.0.0~b2-1.el7.centos.src.rpm

Description for packaged project:
Murano Dashboard is an extension for OpenStack Dashboard that provides a UI for Murano. With murano-dashboard, a user is able to easily manage and control an application catalog, running applications and created environments alongside with all other OpenStack resources.

Additional info:
Package built and tested on CentOS7 using next repositories:
 1) http://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-master-tested/
 2) http://buildlogs.centos.org/centos/7/cloud/x86_64/openstack-newton/
 3) http://dl.fedoraproject.org/pub/epel/7/x86_64/

Comment 1 Javier Peña 2016-09-12 10:46:58 UTC
Hi Igor,

- Use of tilde is not allowed in the Fedora Packaging Guidelines (https://fedoraproject.org/wiki/Packaging:Versioning). So Version should be 3.0.0 and Release 0.1.b2%{?dist}. DLRN will replace these tags during build, anyway, but we should keep that in mind.

- To simplify later import of the spec into CBS, please set the Source0 URL to ttp://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{upstream_version}.tar.gz

- Same as above for %prep, please use %setup -q -n %{pypi_name}-%{upstream_version}

- The Summary for the doc subpackage has a wrong text.

- License must be included in the main and -doc subpackages.

- I think the following line has a typo:

 sed -i '$aMETADATA_CACHE_DIR="/

$aMETADATA_CACHE_DIR should be $METADATA_CACHE_DIR

Thanks!

Comment 3 Javier Peña 2016-09-13 16:36:54 UTC
Hi Igor,

Just a couple things to be fixed, as reported by the fedora-review tool (full report below):

- There is one file with a GPLv3 license, while everything else is Apache 2.0 -> tools/rfc.sh. To simplify the package licensing, could you edit the spec and make sure the file is not packaged?

- The %clean section should be removed.

fedora-review is also complaining about the spec file name, it should not include the version number in the name.

With those fixes, it should be good to go.

Thanks!


-----------------------

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package contains BR: python2-devel or python3-devel
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  Note: Upstream MD5sum check error, diff is in /tmp/1372016-openstack-
  murano-ui-3.0.0.0b2/diff.txt
  See: http://fedoraproject.org/wiki/Packaging/SourceURL
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file _app_license.html is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: openstack-murano-ui-3.0.0.0b2.spec should be openstack-murano-
  ui.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Apache (v2.0)", "GPL (v3 or
     later)", "Unknown or generated", "*No copyright* Apache (v2.0)". 27
     files have unknown license. Detailed output of licensecheck in
     /tmp/1372016-openstack-murano-ui-3.0.0.0b2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/openstack-
     dashboard/openstack_dashboard/local/enabled, /usr/share/openstack-
     dashboard/openstack_dashboard/local, /usr/share/openstack-
     dashboard/openstack_dashboard, /usr/share/openstack-dashboard
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/openstack-
     dashboard, /usr/share/openstack-dashboard/openstack_dashboard/local,
     /usr/share/openstack-dashboard/openstack_dashboard, /usr/share
     /openstack-dashboard/openstack_dashboard/local/enabled
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python

===== SHOULD items =====

Generic:
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     openstack-murano-ui-doc
[x]: Package functions as described.
[-]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Bad spec filename: /tmp/1372016-openstack-murano-ui-3.0.0.0b2
     /srpm-unpacked/openstack-murano-ui-3.0.0.0b2.spec
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: openstack-murano-ui-3.0.0-0.1.b2.el7.centos.noarch.rpm
          openstack-murano-ui-doc-3.0.0-0.1.b2.el7.centos.noarch.rpm
          openstack-murano-ui-3.0.0-0.1.b2.el7.centos.src.rpm
openstack-murano-ui.noarch: W: incoherent-version-in-changelog 3.0.0~b2-1 ['3.0.0-0.1.b2.el7.centos', '3.0.0-0.1.b2.centos']
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/de/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/en_GB/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/fr/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/djangojs.mo
openstack-murano-ui.src: E: invalid-spec-name
openstack-murano-ui.src: W: file-size-mismatch murano-dashboard-3.0.0.0b2.tar.gz = 257629, http://tarballs.openstack.org/murano-dashboard/murano-dashboard-3.0.0.0b2.tar.gz = 258006
3 packages and 0 specfiles checked; 1 errors, 17 warnings.




Rpmlint (installed packages)
----------------------------
openstack-murano-ui.noarch: W: incoherent-version-in-changelog 3.0.0~b2-1 ['3.0.0-0.1.b2.el7.centos', '3.0.0-0.1.b2.centos']
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/de/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/en_GB/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/fr/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/djangojs.mo
2 packages and 0 specfiles checked; 0 errors, 16 warnings.



Requires
--------
openstack-murano-ui (rpmlib, GLIBC filtered):
    /bin/sh
    PyYAML
    openstack-dashboard
    python(abi)
    python-babel
    python-beautifulsoup4
    python-django
    python-django-babel
    python-django-formtools
    python-iso8601
    python-muranoclient
    python-oslo-log
    python-semantic-version
    python-six
    python-yaql

openstack-murano-ui-doc (rpmlib, GLIBC filtered):



Provides
--------
openstack-murano-ui:
    openstack-murano-ui

openstack-murano-ui-doc:
    openstack-murano-ui-doc



Source checksums
----------------
http://tarballs.openstack.org/murano-dashboard/murano-dashboard-3.0.0.0b2.tar.gz :
  CHECKSUM(SHA256) this package     : 97749b6942a4769ec650163520d2cd4552a3e5bd6ca4c519c7c8849d8c9f61a1
  CHECKSUM(SHA256) upstream package : 8fd0bc7cdc5a6d72a1c1e0085057305fa2af741cb50949d1ecf168d140641c7a
diff -r also reports differences


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1372016 -m dlrn
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Igor Yozhikov 2016-09-13 17:32:24 UTC
Updated according to comments.
* Removed %clean section
* Removed version from spec file name
* Added patch which is removing outdated file with GPLv3 license.
Also murano dev team was informed about this issue and they already working on removing this file from repositories - https://review.openstack.org/#/c/369590/ .


Spec URL: https://github.com/Iyozhikov/RPMs/raw/master/openstack-murano-ui/openstack-murano-ui.spec

SRPM URL: https://github.com/Iyozhikov/RPMs/raw/master/openstack-murano-ui/openstack-murano-ui-3.0.0-0.1.b2.el7.centos.src.rpm

Comment 5 Javier Peña 2016-09-14 08:37:47 UTC
Thanks for the quick update Igor.

The package is APPROVED, please go on with step 2 from https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk

Please keep in mind the following when opening the spec review:

- On a DLRN spec, Version and Spec must be XXX, and %changelog must be empty
- Since DLRN packages the latest version from the GitHub repo, some of the workarounds in the spec may not be needed (e.g. there is already a LICENSE file)

Thanks!


--------------------

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file _app_license.html is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 28 files have unknown license. Detailed output of
     licensecheck in /tmp/1372016-openstack-murano-ui/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/openstack-
     dashboard/openstack_dashboard/local/enabled, /usr/share/openstack-
     dashboard/openstack_dashboard/local, /usr/share/openstack-
     dashboard/openstack_dashboard, /usr/share/openstack-dashboard
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/openstack-
     dashboard, /usr/share/openstack-dashboard/openstack_dashboard/local,
     /usr/share/openstack-dashboard/openstack_dashboard, /usr/share
     /openstack-dashboard/openstack_dashboard/local/enabled
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     openstack-murano-ui-doc
[x]: Package functions as described.
[-]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: openstack-murano-ui-3.0.0-0.1.b2.el7.centos.noarch.rpm
          openstack-murano-ui-doc-3.0.0-0.1.b2.el7.centos.noarch.rpm
          openstack-murano-ui-3.0.0-0.1.b2.el7.centos.src.rpm
openstack-murano-ui.noarch: W: incoherent-version-in-changelog 3.0.0~b2-1 ['3.0.0-0.1.b2.el7.centos', '3.0.0-0.1.b2.centos']
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/de/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/en_GB/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/fr/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/djangojs.mo
3 packages and 0 specfiles checked; 0 errors, 16 warnings.




Rpmlint (installed packages)
----------------------------
openstack-murano-ui.noarch: W: incoherent-version-in-changelog 3.0.0~b2-1 ['3.0.0-0.1.b2.el7.centos', '3.0.0-0.1.b2.centos']
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/cs/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/de/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/en_GB/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/fr/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ja/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ko_KR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/pt_BR/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/ru/LC_MESSAGES/djangojs.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/django.mo
openstack-murano-ui.noarch: W: file-not-in-%lang /usr/lib/python2.7/site-packages/muranodashboard/locale/zh_CN/LC_MESSAGES/djangojs.mo
2 packages and 0 specfiles checked; 0 errors, 16 warnings.



Requires
--------
openstack-murano-ui (rpmlib, GLIBC filtered):
    /bin/sh
    PyYAML
    openstack-dashboard
    python(abi)
    python-babel
    python-beautifulsoup4
    python-django
    python-django-babel
    python-django-formtools
    python-iso8601
    python-muranoclient
    python-oslo-log
    python-semantic-version
    python-six
    python-yaql

openstack-murano-ui-doc (rpmlib, GLIBC filtered):



Provides
--------
openstack-murano-ui:
    openstack-murano-ui

openstack-murano-ui-doc:
    openstack-murano-ui-doc



Source checksums
----------------
http://tarballs.openstack.org/murano-dashboard/murano-dashboard-3.0.0.0b2.tar.gz :
  CHECKSUM(SHA256) this package     : 8fd0bc7cdc5a6d72a1c1e0085057305fa2af741cb50949d1ecf168d140641c7a
  CHECKSUM(SHA256) upstream package : 8fd0bc7cdc5a6d72a1c1e0085057305fa2af741cb50949d1ecf168d140641c7a


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1372016 -m dlrn
Buildroot used: dlrn-centos7-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 6 Alan Pevec 2016-09-15 10:59:00 UTC
Step 2. done: https://review.rdoproject.org/r/2265
please proceed to step 3. by uploading the initial spec review to ssh://review.rdoproject.org:29418/openstack/murano-dashboard-distgit

https://www.rdoproject.org/documentation/rdo-packaging/#how-to-add-a-new-package-to-rdo-trunk

Comment 7 Igor Yozhikov 2016-09-15 16:44:19 UTC
Step 3. Spec file merged - https://review.rdoproject.org/r/#/c/2344/
Step 4. Proposed changes to rdoinfo - https://review.rdoproject.org/r/#/c/2360/

Comment 8 Alan Pevec 2016-09-16 22:30:33 UTC
Built in RDO Trunk

Comment 9 Christopher Brown 2017-06-18 13:53:59 UTC
Built so closing.


Note You need to log in before you can comment on or make changes to this bug.