Hide Forgot
Spec URL: https://raw.githubusercontent.com/junghans/fedora-review/master/cereal/cereal.spec SRPM URL: https://raw.githubusercontent.com/junghans/fedora-review/master/cereal/cereal-1.2.1-0.src.rpm Description: cereal is a header-only C++11 serialization library. cereal takes arbitrary data types and reversibly turns them into different representations, such as compact binary encodings, XML, or JSON. cereal was designed to be fast, light-weight, and easy to extend - it has no external dependencies and can be easily bundled with other code or used standalone. Fedora Account System Username: junghans
> BuildRoot: %{_tmppath}/%{name}-%{version}-build not needed > %global debug_package %{nil} BuildArch: noarch > Group: Development/Libraries/C and C++ not needed > License: BSD-3-Clause License: BSD > sed -i 's/-Werror//' CMakeLists.txt bad idea, better to fix real errors ;) > %doc LICENSE %license LICENSE > %{_includedir}/cereal %{_includedir}/%{name}/ > %{_datadir}/cmake/cereal %dir %{_datadir}/cmake %{_datadir}/cmake/%{name}/ > cd %{_target_platform} pushd %{_target_platform} > make %{?_smp_mflags} %make_build -C %{_target_platform} > make -C %{_target_platform} install DESTDIR=%{buildroot} %make_install -C %{_target_platform}
> Summary: Development headers and libraries for cereal library Summary: Development files for %{name} > #test_portable_binary_archive is broken it's better to also include link to upstream bugreport.
(In reply to Igor Gnatenko from comment #1) > > BuildRoot: %{_tmppath}/%{name}-%{version}-build > not needed Done > > > %global debug_package %{nil} > BuildArch: noarch Was already there! > > > Group: Development/Libraries/C and C++ > not needed Done > > > License: BSD-3-Clause > License: BSD Done > > > sed -i 's/-Werror//' CMakeLists.txt > bad idea, better to fix real errors ;) was report https://github.com/USCiLab/cereal/pull/337 Putting -Werror in by default is very bad. Nobody knows what warning future compilers will warn about! > > > %doc LICENSE > %license LICENSE Done > > > %{_includedir}/cereal > %{_includedir}/%{name}/ Done > > > %{_datadir}/cmake/cereal > %dir %{_datadir}/cmake > %{_datadir}/cmake/%{name}/ Done > > > cd %{_target_platform} > pushd %{_target_platform} Done > > > make %{?_smp_mflags} > %make_build -C %{_target_platform} Done > > > make -C %{_target_platform} install DESTDIR=%{buildroot} > %make_install -C %{_target_platform} Done (In reply to Igor Gnatenko from comment #2) > > Summary: Development headers and libraries for cereal library > Summary: Development files for %{name} Done > > > #test_portable_binary_archive is broken > it's better to also include link to upstream bugreport. Already reported https://github.com/USCiLab/cereal/issues/338 New SRPM URL: https://raw.githubusercontent.com/junghans/fedora-review/master/cereal/cereal-1.2.1-1.fc24.src.rpm
(In reply to Christoph Junghans from comment #3) > (In reply to Igor Gnatenko from comment #1) > > > %global debug_package %{nil} > > BuildArch: noarch > Was already there! No, spec still has %global debug_package %{nil} * %dir %{_datadir}/cmake still not there
(In reply to Igor Gnatenko from comment #4) > (In reply to Christoph Junghans from comment #3) > > (In reply to Igor Gnatenko from comment #1) > > > > %global debug_package %{nil} > > > BuildArch: noarch > > Was already there! > No, spec still has %global debug_package %{nil} Fixed. > * %dir %{_datadir}/cmake still not there Fixed. New SRPM URL: https://raw.githubusercontent.com/junghans/fedora-review/master/cereal/cereal-1.2.1-2.fc24.src.rpm
*** Bug 1126983 has been marked as a duplicate of this bug. ***
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/cereal