Bug 1372480 - Crawl always start in Wizard mode
Summary: Crawl always start in Wizard mode
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: crawl
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Antonio T. (sagitter)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-01 21:25 UTC by Guillaume Poirier-Morency
Modified: 2016-09-22 00:25 UTC (History)
2 users (show)

Fixed In Version: crawl-0.18.1-9.fc25 crawl-0.18.1-9.fc23 crawl-0.18.1-9.fc24
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-21 20:22:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Guillaume Poirier-Morency 2016-09-01 21:25:24 UTC
Description of problem:

Whether it's the console or tiles mode, crawl always start in Wizard mode. This is deeply annoying.

Version-Release number of selected component (if applicable):

crawl --version

Crawl version 0.18.1
Save file version 34.169
Compiled with GCC 6.1.1 20160621 (Red Hat 6.1.1-3) on Jul 15 2016 at 17:07:14
Build platform: x86_64-redhat-linux
Platform: x86_64-redhat-linux
CFLAGS: -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fPIC -ggdb -pipe -DUSE_SOUND -Wall -Wformat-security -Wundef -Wno-array-bounds -Wno-format-zero-length -Wmissing-declarations -Wredundant-decls -Wno-parentheses -Wwrite-strings -Wshadow -pedantic -Iutil -I. -isystem /usr/include/lua-5.1 -Irltiles -DFULLDEBUG -DDEBUG -DWIZARD -DASSERTS -DCLUA_BINDINGS -DSAVE_DIR_PATH="~/.crawl" -DSHARED_DIR_PATH="/usr/share/crawl/dat" -DDATA_DIR_PATH="/usr/share/crawl/" -D_GNU_SOURCE
LDFLAGS: -rdynamic -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fPIC -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -fPIC

Comment 1 Guillaume Poirier-Morency 2016-09-01 21:26:54 UTC
Just noticed that '-DWIZARD' is set in the build flags. It might be a better idea to create a release build.

Comment 2 Antonio T. (sagitter) 2016-09-02 09:51:44 UTC
Okay, i'm working on.
Thank you for reporting.

Comment 3 Guillaume Poirier-Morency 2016-09-02 14:43:00 UTC
(In reply to Antonio Trande from comment #2)
> Okay, i'm working on.
> Thank you for reporting.

Thanks to you, I really enjoy that game and I can't find any satisfaction to play that mode.

Comment 4 Antonio T. (sagitter) 2016-09-02 20:07:20 UTC
I have split Crawl w/o wizard mode.
Please, try this new packaging release:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15473215

Comment 5 Guillaume Poirier-Morency 2016-09-02 22:49:10 UTC
(In reply to Antonio Trande from comment #4)
> I have split Crawl w/o wizard mode.
> Please, try this new packaging release:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=15473215

There's a runtime flag for starting Crawl in Wizard mode, so I don't think it's relevant to provide a package. It's more like a handy flag for development and testing.

I'll test the package and give you feedback in a moment...

Comment 6 Guillaume Poirier-Morency 2016-09-02 23:25:12 UTC
It works.

However, I've been digging in the source code and figured that -DWIZARD does not do anything. In fact, when -DFULLDEBUG is set, additional macros are defined to start the game in Wizard mode. See here: 

https://github.com/crawl/crawl/blob/d3c2e7f83eef8ed54e865de4a63ac7700a4a7d68/crawl-ref/source/AppHdr.h#L313

Also, the specfile has a debug macro to trigger a debug build.

If that's okay, I think it's fine to push the package in updates-testing.

Comment 7 Antonio T. (sagitter) 2016-09-03 10:04:48 UTC
>There's a runtime flag for starting Crawl in Wizard mode, so I don't think it's >relevant to provide a package. It's more like a handy flag for development and >testing.

What is the runtime flag for starting Crawl in Wizard mode?
We can definitively build only with NOWIZARD=y option and use the runtime flag for starting the wizard.

Comment 8 Fedora Update System 2016-09-03 19:24:09 UTC
crawl-0.18.1-8.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a3a730e3e

Comment 9 Fedora Update System 2016-09-03 19:24:15 UTC
crawl-0.18.1-8.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-29751ab58d

Comment 10 Fedora Update System 2016-09-03 19:24:19 UTC
crawl-0.18.1-8.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5971161bd8

Comment 11 Guillaume Poirier-Morency 2016-09-03 23:09:38 UTC
(In reply to Antonio Trande from comment #7)
> >There's a runtime flag for starting Crawl in Wizard mode, so I don't think it's >relevant to provide a package. It's more like a handy flag for development and >testing.
> 
> What is the runtime flag for starting Crawl in Wizard mode?
> We can definitively build only with NOWIZARD=y option and use the runtime
> flag for starting the wizard.

I was mistaken with -wizard, but it only enables access to the Wizard mode if it's built with -DUSE_DGAMELAUNCH, which is basically a safety for the *multiplayer* mode.

Basically, I think that the issue is only with -DFULLDEBUG which is added if the %{with debug} macro is set while building the RPM.

Comment 12 Antonio T. (sagitter) 2016-09-04 10:15:48 UTC
In the end, can you run Crawl w/o wizard mode with latest release?

PS.
Sorry i can't try now.

Comment 13 Guillaume Poirier-Morency 2016-09-04 20:56:46 UTC
(In reply to Antonio Trande from comment #12)
> In the end, can you run Crawl w/o wizard mode with latest release?
> 
> PS.
> Sorry i can't try now.

Yes, everything is fine now from a end-user perspective. Thanks for the fix, I really appreciate.

Comment 14 Fedora Update System 2016-09-05 02:51:40 UTC
crawl-0.18.1-8.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-29751ab58d

Comment 15 Fedora Update System 2016-09-05 02:53:06 UTC
crawl-0.18.1-8.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a3a730e3e

Comment 16 Fedora Update System 2016-09-05 02:56:48 UTC
crawl-0.18.1-8.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5971161bd8

Comment 17 Quentin Tayssier 2016-09-06 11:49:22 UTC
With this fix, is it still possible to enter in wizard mode during the game?

I have read in crawl documentation that you can enter in wizard mode in the game by typing '&' inside the game.
http://crawl.chaosforge.org/Wizard_mode

In stable fc24 without the patch, game start directly in wizard mode and you can use Wizard command to add gold for example.
In fc24 with the patch, game start without Wizard mode as expected, but i am unable to enter in Wizard mode in game (and use Wizard command).

I have done this test on F24/f25 testing with this patch.

Comment 18 Antonio T. (sagitter) 2016-09-06 12:48:40 UTC
(In reply to tenk42 from comment #17)
> With this fix, is it still possible to enter in wizard mode during the game?
> 
> I have read in crawl documentation that you can enter in wizard mode in the
> game by typing '&' inside the game.
> http://crawl.chaosforge.org/Wizard_mode
> 
> In stable fc24 without the patch, game start directly in wizard mode and you
> can use Wizard command to add gold for example.
> In fc24 with the patch, game start without Wizard mode as expected, but i am
> unable to enter in Wizard mode in game (and use Wizard command).
> 
> I have done this test on F24/f25 testing with this patch.

I contacted upstream to clarify this issue.

Comment 19 Fedora Update System 2016-09-07 15:55:18 UTC
crawl-0.18.1-9.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-398fb6c542

Comment 20 Fedora Update System 2016-09-07 15:55:25 UTC
crawl-0.18.1-9.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-59b3060e7e

Comment 21 Fedora Update System 2016-09-07 15:55:30 UTC
crawl-0.18.1-9.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3da03788a9

Comment 22 Fedora Update System 2016-09-09 06:26:46 UTC
crawl-0.18.1-9.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-398fb6c542

Comment 23 Fedora Update System 2016-09-09 17:57:21 UTC
crawl-0.18.1-9.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-59b3060e7e

Comment 24 Fedora Update System 2016-09-12 13:19:26 UTC
crawl-0.18.1-9.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2016-09-12 15:28:47 UTC
crawl-0.18.1-9.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3da03788a9

Comment 26 Fedora Update System 2016-09-21 20:22:24 UTC
crawl-0.18.1-9.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 27 Fedora Update System 2016-09-22 00:25:26 UTC
crawl-0.18.1-9.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.