Bug 1373281 - [RFE] Support for more slashes in image tag names
Summary: [RFE] Support for more slashes in image tag names
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Image Registry
Version: 3.1.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: ---
Assignee: Alexey Gladkov
QA Contact: zhou ying
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-05 17:42 UTC by Steven Walter
Modified: 2020-04-24 20:57 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
This change allows to have multiple slashes in the Docker image name and allow to use external registries that does support them (such as Artifactory).
Clone Of:
Environment:
Last Closed: 2017-01-18 12:53:24 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0066 0 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.4 RPM Release Advisory 2017-01-18 17:23:26 UTC

Description Steven Walter 2016-09-05 17:42:49 UTC
1. Proposed title of this feature request
Support for more slashes in image tag names

3. What is the nature and description of the request?
When attempting to push an image with more slash-separated segments than the standard <docker registry ip or route>[:<port>]/<namespace>/<imagename>, it fails out with an error (as currently expected with the specifications for the docker push):

error: can't build "http://example.net/myproject/myapp.git": can't build "exampleregistry.net/project/subheading/image:tag": the docker pull spec "exampleregistry.net/project/subheading/image:tag" must be two or three segments separated by slashes
 

5. How would the customer like to achieve this? (List the functional requirements here)
Be able to tag and push to a subheading of a project. One possible way to do this would be to simply allow extra slashes but that are all part of the image name, or are otherwise simply subheadings (with the first one being the namespace and any extra "in-between" slashes just being metadata).
 

6. For each functional requirement listed in question 5, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.
Run docker push on a name like exampleregistry.net/project/subheading/image:tag

7. Is there already an existing RFE upstream or in Red Hat bugzilla?
Not that I could find

Comment 3 Steven Walter 2016-09-08 13:20:15 UTC
This also applies with pulls:

oc new-build ssh://my.example.net:22/subDir/anotherDir/_git/StevenExample
error: can't build "ssh://my.example.net:22/subDir/anotherDir/_git/StevenExample": can't build "docker-enterprise.example.net/imagedir/myimageproject/rhel/rhel7:2016": the docker pull spec "docker-enterprise.example.net/imagedir/myimageproject/rhel/rhel7:2016" must be two or three segments separated by slashes

Comment 9 Jim Minter 2016-09-27 13:28:11 UTC
https://github.com/openshift/source-to-image/pull/594 for s2i piece

Comment 10 Alexey Gladkov 2016-10-18 11:20:49 UTC
At the origin (master) added support of multi-segment names. You can import images and/or build them. The docker-registry still doesn't support such names (and not planned).

Please, verify.

Comment 12 Michal Fojtik 2016-10-31 11:40:39 UTC
QA ping?

Comment 13 Steven Walter 2016-10-31 15:06:35 UTC
(In reply to Alexey Gladkov from comment #10)
> At the origin (master) added support of multi-segment names. You can import
> images and/or build them. The docker-registry still doesn't support such
> names (and not planned).
> 
> Please, verify.

Sorry, I would like to clarify your meaning; OpenShift can now support using images with more segments, but the registry cannot store them? I.E. OpenShift can now process "external" images with that name format but our registry will continue to adhere to the standard?

Comment 14 Alexey Gladkov 2016-10-31 16:54:59 UTC
Openshift supports DockerReference with more segments. You can create an imagestream from the external docker registry and use it for builds, you can use multi-segment names in the build config.

See https://bugzilla.redhat.com/show_bug.cgi?id=1386543 for more info.

Comment 15 Steven Walter 2016-11-01 13:43:41 UTC
Ok, thanks, that makes sense. I am verifying with customer if this satisfies.

Comment 16 Steven Walter 2016-11-02 14:05:11 UTC
Hi,

Ok so as per comment 3 at https://bugzilla.redhat.com/show_bug.cgi?id=1386543#c3 we do not plan to support multi-segments in imagestream names, correct? All we will support is external images that have multi segments, but if they are imported as an IS they will take the 3-segment format? I would like to get final verification before passing this along to customer.

Comment 17 Alexey Gladkov 2016-11-02 14:53:48 UTC
> we do not plan to support multi-segments in imagestream names, correct?

Yes.

> All we will support is external images that have multi segments, but if they are imported as an IS they will take the 3-segment format?

The imagestream name will have just single segment, but the docker reference in the imagestream can have 3-segment format.

Comment 19 zhou ying 2016-11-08 09:47:39 UTC
Confirmed with latest OCP3.4 , the feature has supportted:

openshift v3.4.0.23+24b1a58
kubernetes v1.4.0+776c994
etcd 3.1.0-rc.0

[root@zhouy testjson]# oc describe is ruby-22-centos7
Name:			ruby-22-centos7
Namespace:		zhouy2
Created:		4 minutes ago
Labels:			<none>
Annotations:		openshift.io/image.dockerRepositoryCheck=2016-11-08T09:40:02Z
Docker Pull Spec:	172.30.196.46:5000/zhouy2/ruby-22-centos7
Unique Images:		1
Tags:			1

latest
  tagged from 073b6b6e.ngrok.io/test/centos/ruby-22-centos7

Comment 21 errata-xmlrpc 2017-01-18 12:53:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0066

Comment 22 hoqbet 2020-04-24 20:56:42 UTC
https://www.caradaftarsbobetterbaru.com/

Comment 23 hoqbet 2020-04-24 20:57:13 UTC
https://www.caradaftarsbobetterbaru.com/


Note You need to log in before you can comment on or make changes to this bug.