Bug 1373735 - Event pushed even if Answer is No in the Volume Stop and Delete prompt
Summary: Event pushed even if Answer is No in the Volume Stop and Delete prompt
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: eventsapi
Version: 3.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Aravinda VK
QA Contact:
URL:
Whiteboard:
Depends On: 1373072
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-07 05:48 UTC by Aravinda VK
Modified: 2016-12-06 05:59 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.9.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1373072
Environment:
Last Closed: 2016-12-06 05:59:37 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Aravinda VK 2016-09-07 05:48:56 UTC
+++ This bug was initially created as a clone of Bug #1373072 +++

Description of problem:
$gluster v stop gv1
Stopping volume will make its data inaccessible. Do you want to continue? (y/n) n

$gluster v delete gv1
Deleting volume will erase all information about the volume. Do you want to continue? (y/n) n

Answer is No in both of the above. But event is sent.

--- Additional comment from Worker Ant on 2016-09-05 01:47:23 EDT ---

REVIEW: http://review.gluster.org/15399 (eventsapi: Fix Volume Stop and delete prompt issue) posted (#1) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-09-05 02:00:15 EDT ---

REVIEW: http://review.gluster.org/15399 (eventsapi: Fix Volume Stop and delete prompt issue) posted (#2) for review on master by Aravinda VK (avishwan)

--- Additional comment from Worker Ant on 2016-09-07 01:19:02 EDT ---

COMMIT: http://review.gluster.org/15399 committed in master by Atin Mukherjee (amukherj) 
------
commit f20e41aec392a45f860fa7e80ad5ee9d5607a45c
Author: Aravinda VK <avishwan>
Date:   Mon Sep 5 11:15:10 2016 +0530

    eventsapi: Fix Volume Stop and delete prompt issue
    
    During Volume Stop and Delete, event is emitted even if
    prompt answer is No.
    
    Also added "force" details in START and STOP events.
    
    BUG: 1373072
    Change-Id: I986dcff7154b584f6ed44b533d4eeabe82815235
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/15399
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 1 Worker Ant 2016-09-07 05:52:49 UTC
REVIEW: http://review.gluster.org/15414 (eventsapi: Fix Volume Stop and delete prompt issue) posted (#1) for review on release-3.9 by Aravinda VK (avishwan)

Comment 2 Worker Ant 2016-09-07 05:55:48 UTC
REVIEW: http://review.gluster.org/15414 (eventsapi: Fix Volume Stop and delete prompt issue) posted (#2) for review on release-3.9 by Aravinda VK (avishwan)

Comment 3 Worker Ant 2016-09-07 06:24:31 UTC
REVIEW: http://review.gluster.org/15414 (cli/eventsapi: Fix Volume Stop and delete prompt issue) posted (#3) for review on release-3.9 by Aravinda VK (avishwan)

Comment 4 Worker Ant 2016-09-09 06:58:42 UTC
COMMIT: http://review.gluster.org/15414 committed in release-3.9 by Aravinda VK (avishwan) 
------
commit 0587f334e2e4fd71ad61f65db10ffe1b1ad5d1f9
Author: Aravinda VK <avishwan>
Date:   Mon Sep 5 11:15:10 2016 +0530

    cli/eventsapi: Fix Volume Stop and delete prompt issue
    
    During Volume Stop and Delete, event is emitted even if
    prompt answer is No.
    
    Also added "force" details in START and STOP events.
    
    > Signed-off-by: Aravinda VK <avishwan>
    > Reviewed-on: http://review.gluster.org/15399
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Atin Mukherjee <amukherj>
    
    BUG: 1373735
    Change-Id: I986dcff7154b584f6ed44b533d4eeabe82815235
    Signed-off-by: Aravinda VK <avishwan>
    (cherry picked from commit f20e41aec392a45f860fa7e80ad5ee9d5607a45c)
    Change-Id: Iee1a2a2f3749cfcf8dd0dcd3fcc3b48372fa06b1
    Reviewed-on: http://review.gluster.org/15414
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 5 Aravinda VK 2016-10-27 05:22:00 UTC
glusterfs-3.9.0rc2 is released[1] and packages are available for different distributions[2] to test.

[1] http://www.gluster.org/pipermail/maintainers/2016-October/001601.html
[2] http://www.gluster.org/pipermail/maintainers/2016-October/001605.html and http://www.gluster.org/pipermail/maintainers/2016-October/001606.html

Comment 6 Aravinda VK 2016-12-06 05:59:37 UTC
Gluster 3.9 GA is released http://blog.gluster.org/2016/11/announcing-gluster-3-9/


Note You need to log in before you can comment on or make changes to this bug.