Bug 1373953 - [QE](6.4.z) max-saved-replicated-journal-size = 0 should preserve no old journals
Summary: [QE](6.4.z) max-saved-replicated-journal-size = 0 should preserve no old jour...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Enterprise Application Platform 6
Classification: JBoss
Component: HornetQ
Version: 6.4.10
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: CR1
: EAP 6.4.16
Assignee: Peter Palaga
QA Contact: Peter Mackay
URL:
Whiteboard:
Depends On:
Blocks: eap6416-payload 1438037
TreeView+ depends on / blocked
 
Reported: 2016-09-07 14:09 UTC by Erich Duda
Modified: 2024-12-20 18:42 UTC (History)
10 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-06-22 09:19:46 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Apache JIRA ARTEMIS-716 0 None None None 2017-03-31 16:56:48 UTC
Red Hat Issue Tracker JBEAP-10974 0 Major Verified (7.0.z) max-saved-replicated-journal-size = 0 should preserve no old journals 2019-07-04 03:36:15 UTC
Red Hat Knowledge Base (Solution) 2988381 0 None None None 2017-03-31 11:56:44 UTC

Description Erich Duda 2016-09-07 14:09:48 UTC 
Description of problem:
Behavior of max-saved-replicated-journal-size = 0 is not intuitive. It preserves infinite number of old replicas but it should preserves 0 old replicas.


Steps to Reproduce:
1. Configure replicated HA topology with max-saved-replicated-journal-size = 0.
2. Do several failovers/failbacks.
3. Check whether the number of old replicas is 0 on backup node.
Comment 1 Erich Duda 2016-09-07 14:15:52 UTC 
See also https://bugzilla.redhat.com/show_bug.cgi?id=1348322
Comment 2 Clebert Suconic 2016-09-07 14:42:36 UTC 
The intention was that you should have at least 1 folder up. Otherwise the ID for the old folder would always be 1.
Comment 3 Clebert Suconic 2016-09-07 18:54:22 UTC 
I have added this into upstream:

https://github.com/apache/activemq-artemis/pull/758


it's an easy change. I will wait for further instructions on where and when to back port it.
Comment 4 Clebert Suconic 2016-09-08 16:30:23 UTC 
when/where to back-port this?

Do I have permissions?
Comment 5 Erich Duda 2016-09-09 05:39:46 UTC 
The fix should go to the next CP release. So just add the commit to 6.4.z maintenance branch.
Comment 7 Peter Palaga 2016-09-12 12:43:50 UTC 
(In reply to Erich Duda from comment #5)
> The fix should go to the next CP release. So just add the commit to 6.4.z
> maintenance branch.

This is something Brad will decide.

Clebert, please hold on with backporting to your 6.4.z maintenance branch till the present BZ gets assigned to some specific CP.
Comment 21 Peter Palaga 2017-05-17 15:00:24 UTC 
PR sent https://github.com/hornetq/hornetq/pull/2115
Comment 22 Peter Mackay 2017-06-14 09:52:54 UTC 
Verified with EAP 6.4.16.CP.CR1
Comment 23 Petr Penicka 2017-06-22 09:19:46 UTC 
Released on June 20 2017 as part of the EAP 6.4.16 maintenance release.
Note You need to log in before you can comment on or make changes to this bug.