Hide Forgot
Description of problem: Guest fails to start if some USB devices have no port in address but others have Version-Release number of selected component (if applicable): libvirt-2.0.0-8.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1. define a guest with USB companion controllers and four usb redir devices. # virsh dumpxml vm1 | grep usb -A 5 <controller type='usb' index='0' model='ich9-ehci1'> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x7'/> </controller> <controller type='usb' index='0' model='ich9-uhci1'> <master startport='0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0' multifunction='on'/> </controller> <controller type='usb' index='0' model='ich9-uhci2'> <master startport='2'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x1'/> </controller> <controller type='usb' index='0' model='ich9-uhci3'> <master startport='4'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x2'/> </controller> <controller type='pci' index='0' model='pci-root'/> <interface type='network'> -- <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='1'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='2'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='3'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='4'/> </redirdev> 2. virsh edit guest, add a usb virtual disk with port in address, it can add successfully. #virsh edit vm1 ...... <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/tmp/zp/qcow2.img'/> <target dev='sda' bus='usb'/> <address type='usb' bus='0'/> </disk> .... 3. start guest, it fails to start # virsh start vm1 error: Failed to start domain vm1 error: internal error: qemu unexpectedly closed the monitor: 2016-08-31T09:06:52.569922Z qemu-kvm: warning: CPU(s) not present in any NUMA nodes: 1 2 3 4 5 6 7 2016-08-31T09:06:52.570052Z qemu-kvm: warning: All CPU(s) up to maxcpus should be described in NUMA config 2016-08-31T09:06:52.604017Z qemu-kvm: -device usb-redir,chardev=charredir0,id=redir0,bus=usb.0,port=1: usb port 1 (bus usb.0) not found (in use?) Actual results: As step3, guest fails to start. Expected results: Guest can start successfully. Additional info:
Upstream patch: https://www.redhat.com/archives/libvir-list/2017-January/msg01109.html
Pushed upstream as: commit 384504f7ba5f5c885a642e94b123483a5534e873 Author: Ján Tomko <jtomko> CommitDate: 2017-02-13 09:46:15 +0100 qemu: assign USB port on a selected hub for all devices Due to a logic error, the autofilling of USB port when a bus is specified: <address type='usb' bus='0'/> does not work for non-hub devices on domain startup. Fix the logic in qemuDomainAssignUSBPortsIterator to also assign ports for USB addresses that do not yet have one. https://bugzilla.redhat.com/show_bug.cgi?id=1374128 git describe: v3.0.0-180-g384504f
Verified on libvirt-3.1.0-2.el7.x86_64 1. Define a vm with following xml <controller type='usb' index='0' model='ich9-ehci1'> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x7'/> </controller> <controller type='usb' index='0' model='ich9-uhci1'> <master startport='0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0' multifunction='on'/> </controller> <controller type='usb' index='0' model='ich9-uhci2'> <master startport='2'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x1'/> </controller> <controller type='usb' index='0' model='ich9-uhci3'> <master startport='4'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x2'/> </controller> <controller type='pci' index='0' model='pci-root'/> <interface type='network'> -- <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='1'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='2'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='3'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='4'/> </redirdev> ## virsh define vm1.xml Domain vm defined from vm1.xml 2. prepare a qcow2 image and use it in the vm ## qemu-img create -f qcow2 /tmp/1.qcow2 1G Formatting '/tmp/1.qcow2', fmt=qcow2 size=1073741824 encryption=off cluster_size=65536 lazy_refcounts=off refcount_bits=16 ## virsh edit vm ... <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/tmp/1.qcow2'/> <target dev='sda' bus='usb'/> <address type='usb' bus='0' port='5'/> </disk> ... ## virsh start vm Domain vm started <==== vm can be started successfully 3. check the usb related xml part ## virsh dumpxml vm | grep usb -5 </disk> <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/tmp/1.qcow2'/> <backingStore/> <target dev='sda' bus='usb'/> <alias name='usb-disk0'/> <address type='usb' bus='0' port='5'/> </disk> <controller type='usb' index='0' model='ich9-ehci1'> <alias name='usb'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x7'/> </controller> <controller type='usb' index='0' model='ich9-uhci1'> <alias name='usb'/> <master startport='0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0' multifunction='on'/> </controller> <controller type='usb' index='0' model='ich9-uhci2'> <alias name='usb'/> <master startport='2'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x1'/> </controller> <controller type='usb' index='0' model='ich9-uhci3'> <alias name='usb'/> <master startport='4'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x2'/> </controller> <controller type='virtio-serial' index='0'> <alias name='virtio-serial0'/> -- <source mode='bind' path='/var/lib/libvirt/qemu/channel/target/domain-25-vm/org.qemu.guest_agent.0'/> <target type='virtio' name='org.qemu.guest_agent.0' state='connected'/> <alias name='channel0'/> <address type='virtio-serial' controller='0' bus='0' port='6'/> </channel> <input type='tablet' bus='usb'> <alias name='input0'/> <address type='usb' bus='0' port='6'/> </input> <input type='mouse' bus='ps2'> <alias name='input1'/> </input> <input type='keyboard' bus='ps2'> -- <video> <model type='cirrus' vram='16384' heads='1' primary='yes'/> <alias name='video0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> <redirdev bus='usb' type='spicevmc'> <alias name='redir0'/> <address type='usb' bus='0' port='1'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <alias name='redir1'/> <address type='usb' bus='0' port='2'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <alias name='redir2'/> <address type='usb' bus='0' port='3'/> </redirdev> <redirdev bus='usb' type='spicevmc'> <alias name='redir3'/> <address type='usb' bus='0' port='4'/> </redirdev>
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2017:1846