Bug 1375221 - Azure provisioning missing pre and post methods.
Summary: Azure provisioning missing pre and post methods.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: GA
: 5.7.0
Assignee: William Fitzgerald
QA Contact: Milan Falešník
URL:
Whiteboard:
Depends On:
Blocks: 1375330
TreeView+ depends on / blocked
 
Reported: 2016-09-12 13:49 UTC by William Fitzgerald
Modified: 2017-03-16 10:27 UTC (History)
8 users (show)

Fixed In Version: 5.7.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1375330 (view as bug list)
Environment:
Last Closed: 2017-01-11 20:15:56 UTC
Category: ---
Cloudforms Team: Azure
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description William Fitzgerald 2016-09-12 13:49:23 UTC
Description of problem:

When provisioning for Azure, the pre and post methods are missing.


Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.  Provision a VM using Azure provider
2.
3.

Actual results:
Pre_provision and Post_provision methods are missing


Expected results:
Pre_provision and Post_provision methods should run.

Additional info:
These methods are vendor specific and Azure is missing.   Azure needs the generic methods and they are missing also. The schema needs to be updated to cal lthe generi methods when the provider is Azure.  The Google provider is also missing and that will be a separate BZ and PR to fix.

Please assign to wfitzger

Comment 3 CFME Bot 2016-09-12 17:51:02 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/31023515e8058771621b605d04bf854a97ab497d

commit 31023515e8058771621b605d04bf854a97ab497d
Author:     william fitzgerald <wfitzger>
AuthorDate: Fri Sep 9 10:07:27 2016 -0400
Commit:     william fitzgerald <wfitzger>
CommitDate: Mon Sep 12 12:11:10 2016 -0400

    Automate - Added Azure pre and post provisioning.
    
    Added relationship and method fields for azure.
    
    Added generic pre and post provisioning methods.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1375221
    
    http://talk.manageiq.org/t/azure-and-amazon-vm-post-provisioning/1691

 .../StateMachines/Methods.class/__class__.yaml     | 40 ++++++++++++++++++++++
 .../Methods.class/__methods__/postprovision.rb     |  8 +++++
 .../Methods.class/__methods__/postprovision.yaml   | 12 +++++++
 .../Methods.class/__methods__/preprovision.rb      |  8 +++++
 .../Methods.class/__methods__/preprovision.yaml    | 12 +++++++
 .../StateMachines/Methods.class/postprovision.yaml |  2 ++
 .../StateMachines/Methods.class/preprovision.yaml  |  2 ++
 7 files changed, 84 insertions(+)
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/__methods__/postprovision.rb
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/__methods__/postprovision.yaml
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/__methods__/preprovision.rb
 create mode 100644 db/fixtures/ae_datastore/ManageIQ/Cloud/VM/Provisioning/StateMachines/Methods.class/__methods__/preprovision.yaml

Comment 5 Milan Falešník 2016-09-29 12:36:03 UTC
Verified in 5.7.0.1.

The methods are present and get called during provisioning. Due to the state of our Azure subscription I could not test the post provisioning method, but since I tested it on 5.6.2.1 and knowledge of automate engine, I assume that one is all right too.


Note You need to log in before you can comment on or make changes to this bug.