Bug 1375290 - ipopt adds in /usr/include/openmpi-x86_64/strings.h - which breaks hdf5 build from source - when using /usr/lib64/openmpi/bin/mpicc
Summary: ipopt adds in /usr/include/openmpi-x86_64/strings.h - which breaks hdf5 build...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: coin-or-Ipopt
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Paulo Andrade
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-12 15:46 UTC by Satish Balay
Modified: 2016-10-07 14:46 UTC (History)
4 users (show)

Fixed In Version: coin-or-Ipopt-3.12.6-2.fc25 coin-or-Ipopt-3.12.6-2.fc24 coin-or-Ipopt-3.12.6-2.fc23 coin-or-Ipopt-3.12.6-2.el6 coin-or-Ipopt-3.12.6-2.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-27 00:34:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Satish Balay 2016-09-12 15:46:01 UTC
Description of problem:

HDF5 build from source [with openmpi] breaks when coin-or-Ipopt-openmpi-devel package is installed

Version-Release number of selected component (if applicable):

coin-or-Ipopt-openmpi-devel-3.12.6-1.fc23.x86_64
openmpi-devel-1.8.8-5.fc23.2.x86_64

How reproducible:

Always

Steps to Reproduce:
1. yum install coin-or-Ipopt-openmpi-devel openmpi-devel
2. Try configuring hdf5-1.8.12 - or do the equivalent configure test.


Actual results:


[balay@maverick junk]$ cat string-test.c 
# include <strings.h>
int main ()
{
  return 0;
}
[balay@maverick junk]$ /usr/lib64/openmpi/bin/mpicc string-test.c 
[balay@maverick junk]$ /usr/lib64/openmpi/bin/mpicc string-test.c -ansi -pedantic 
In file included from string-test.c:1:0:
/usr/include/openmpi-x86_64/strings.h:1:1: error: C++ style comments are not allowed in ISO C90
 // Copyright (C) 2009 Paragon Decision Technology B.V.
 ^
/usr/include/openmpi-x86_64/strings.h:1:1: error: (this will be reported only once per input file)


Expected results:

No such error

Additional info:

Presumably Ipopt is overloading system includes [not sure why] - which should probably be avoided. Or least patch up the file to use C comments [not C++]

Comment 1 Satish Balay 2016-09-12 15:56:41 UTC
[root@maverick ~]# yum whatprovides /usr/include/openmpi-x86_64/strings.h
Redirecting to '/usr/bin/dnf whatprovides /usr/include/openmpi-x86_64/strings.h' (see 'man yum2dnf')

Last metadata expiration check: 0:07:28 ago on Mon Sep 12 10:48:46 2016.
coin-or-Ipopt-openmpi-devel-3.12.6-1.fc23.x86_64 : The coin-or-Ipopt headers and development-related files
Repo        : updates

coin-or-Ipopt-openmpi-devel-3.12.4-3.fc23.x86_64 : The coin-or-Ipopt headers and development-related files
Repo        : fedora

[root@maverick ~]#

Comment 2 Antonio T. (sagitter) 2016-09-12 16:10:54 UTC
Paulo,

moving /usr/include/openmpi-x86_64/* files from 'coin-or-Ipopt-openmpi-devel' into a private directory can resolve this problem?

Comment 3 Paulo Andrade 2016-09-19 17:14:18 UTC
(In reply to Antonio Trande from comment #2)
> Paulo,
> 
> moving /usr/include/openmpi-x86_64/* files from
> 'coin-or-Ipopt-openmpi-devel' into a private directory can resolve this
> problem?

  Removing -pedantic from compiler command line will turn the
error into a warning.
  Otherwise, should patch the file from using from using C++ //
comment to using C comment /* */

  I believe it is better to check why it is being installed, and
why. /usr/include/openmpi-*/strings.h is just a wrapper to
include string.h (not strings.h) so it might be better to just
not install it.

Comment 4 Antonio T. (sagitter) 2016-09-20 11:22:24 UTC
Satish,

please try with this scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15716288

Comment 5 Satish Balay 2016-09-20 18:43:49 UTC
This fix works for me. Thanks!

Comment 6 Fedora Update System 2016-09-20 19:34:22 UTC
coin-or-Ipopt-3.12.6-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-cf2daec449

Comment 7 Fedora Update System 2016-09-20 19:34:29 UTC
coin-or-Ipopt-3.12.6-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-973c166076

Comment 8 Fedora Update System 2016-09-20 19:34:34 UTC
coin-or-Ipopt-3.12.6-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-eb895b3eb4

Comment 9 Fedora Update System 2016-09-20 19:34:39 UTC
coin-or-Ipopt-3.12.6-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ceaea3c8f8

Comment 10 Fedora Update System 2016-09-20 19:34:44 UTC
coin-or-Ipopt-3.12.6-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-68bbbf4170

Comment 11 Fedora Update System 2016-09-22 01:17:50 UTC
coin-or-Ipopt-3.12.6-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-cf2daec449

Comment 12 Fedora Update System 2016-09-22 01:19:22 UTC
coin-or-Ipopt-3.12.6-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-68bbbf4170

Comment 13 Fedora Update System 2016-09-22 01:24:06 UTC
coin-or-Ipopt-3.12.6-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-eb895b3eb4

Comment 14 Fedora Update System 2016-09-22 01:24:59 UTC
coin-or-Ipopt-3.12.6-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-973c166076

Comment 15 Fedora Update System 2016-09-22 09:56:30 UTC
coin-or-Ipopt-3.12.6-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ceaea3c8f8

Comment 16 Jay Jay Billings 2016-09-24 16:16:53 UTC
I was experiencing the same problem. I can confirm that this fix works on my F23 machine too. Thanks!

Comment 17 Fedora Update System 2016-09-27 00:34:49 UTC
coin-or-Ipopt-3.12.6-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2016-10-01 00:52:50 UTC
coin-or-Ipopt-3.12.6-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2016-10-01 04:21:04 UTC
coin-or-Ipopt-3.12.6-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2016-10-07 13:47:54 UTC
coin-or-Ipopt-3.12.6-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2016-10-07 14:46:53 UTC
coin-or-Ipopt-3.12.6-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.