Currently we are passing individual credentials directly to Runner.new. This is both problematic and inefficient, in the first case because we aren't including proxy information, and in the second case because we already have the connection information we need from the EMS. This code, which is very similar to the Google provider code, alters the Runner's initialize method to accept an ems object rather than individual credentials. This, in turn, lets us use the :with_provider_connection method which already contains the credentials we need, including the proxy information. It's also shorter and easier to read. :) In addition to the specs, this can be validated by firing up a local instance of the app, deliberately triggering an event (such as a power on/off) for a VM, and then look for power events in the UI.
https://github.com/ManageIQ/manageiq/pull/10710
There is no additional test case for refactoring. Everything is working just fine for the last few builds with the change. Moving to verified.