Bug 1375344 - Modify Azure Runner to use existing EMS
Summary: Modify Azure Runner to use existing EMS
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.7.0
Assignee: Daniel Berger
QA Contact: Jeff Teehan
URL:
Whiteboard: provider:azure
Depends On:
Blocks: 1376176
TreeView+ depends on / blocked
 
Reported: 2016-09-12 18:45 UTC by John Prause
Modified: 2017-01-12 04:40 UTC (History)
4 users (show)

Fixed In Version: 5.7.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1376176 (view as bug list)
Environment:
Last Closed: 2017-01-11 19:55:04 UTC
Category: ---
Cloudforms Team: Azure
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description John Prause 2016-09-12 18:45:15 UTC
Currently we are passing individual credentials directly to Runner.new. This is both problematic and inefficient, in the first case because we aren't including proxy information, and in the second case because we already have the connection information we need from the EMS.

This code, which is very similar to the Google provider code, alters the Runner's initialize method to accept an ems object rather than individual credentials. This, in turn, lets us use the :with_provider_connection method which already contains the credentials we need, including the proxy information.

It's also shorter and easier to read. :)

In addition to the specs, this can be validated by firing up a local instance of the app, deliberately triggering an event (such as a power on/off) for a VM, and then look for power events in the UI.

Comment 2 John Prause 2016-09-12 18:46:00 UTC
https://github.com/ManageIQ/manageiq/pull/10710

Comment 4 Jeff Teehan 2016-10-11 19:38:15 UTC
There is no additional test case for refactoring.  Everything is working just fine for the last few builds with the change.  Moving to verified.


Note You need to log in before you can comment on or make changes to this bug.