Bug 1375802 - banshee must not depend on webkitgtk
Summary: banshee must not depend on webkitgtk
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: banshee
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: webkit1-removal
TreeView+ depends on / blocked
 
Reported: 2016-09-14 04:31 UTC by Michael Catanzaro
Modified: 2017-08-02 16:49 UTC (History)
6 users (show)

Fixed In Version: banshee-2.6.2-22.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-02 16:49:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Michael Catanzaro 2016-09-14 04:31:59 UTC
The webkitgtk package will be removed from rawhide after Fedora 26 is branched due to the high number of unfixed security vulnerabilities. You must remove this dependency or your package will not be present in Fedora 27.

Please refer to [1] for a FAQ on this matter and be advised that for some packages this may require a substantial amount of work.

[1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/AKVB363GFCHHJ5MTHGVYHYT6NLLTF5VM/

Comment 1 Hin-Tak Leung 2016-09-14 21:33:30 UTC
same comments applies elsewhere:

webkit-sharp is indeed webkit1 *and* GTK+2 specific.

There are two other projects, neither of which are packaged with fedora, that provides later support.

https://github.com/hbons/webkit2-sharp - webkit2 + GTK3

https://github.com/openmedicus/webkitgtk3-sharp - webkit1 + GTK3

There is no webkit2 + GTK2 binding, AFAIK.

Comment 2 Michael Catanzaro 2016-09-14 22:14:50 UTC
Also note this would as a side-effect fix a bug in Banshee: https://bugzilla.gnome.org/show_bug.cgi?id=747030

Comment 3 Tom "spot" Callaway 2016-09-16 20:09:14 UTC
Well, two big problems there:

webkit2-sharp has one commit, and no licensing. see:
https://github.com/hbons/webkit2-sharp/issues/2

Not exactly optimal.

webkitgtk3-sharp is webkit1, which means it doesn't fix the other bug in Banshee.

Comment 4 Hin-Tak Leung 2016-09-16 20:25:09 UTC
wekbit2-sharp doesn't have licensing info because it is auto-generated - from webkit's gobject introspection and bindinator ( http://github.com/shana/bindinator ) . So its licensing is somewhere between webkit2's, bindinator's, and/or depends on the person who runs bindinator against a specific version of webkit2 .

The repo is simply the stored result of a particular run by a particular person on a particular version of webkit2 .

I suppose if redhat personnels run bindinator directly, one can eliminate the 3rd variable.

Ideally one might like a webkit2 + gtk2 binding (which currently does not exist) for ease of migration.

Comment 5 Hin-Tak Leung 2016-09-16 20:32:46 UTC
since gtk2 and gtk3 does not play nice with each other, you have a hidden problem that banshee is currently gtk2-dependent, and therefore really needs a webkit2 + gtk2 binding. This currently does not exist, and unlikely ever to, since wekbkit2 is rather gtk3 dependent.

i.e. you will need to migrate banshee from depending on gtk2-sharp to gtk3-sharp, on the way.

Comment 6 Hin-Tak Leung 2016-09-16 20:43:52 UTC
The process of auto-generating webkit2-shartp was somewhat documented in -

https://github.com/shana/bindinator/issues/26

Comment 7 Tom "spot" Callaway 2016-09-16 20:45:11 UTC
Yeah. I'm strongly inclined to simply let the banshee upstream deal with this whole problem. :/

Comment 8 Michael Catanzaro 2016-09-16 21:00:24 UTC
At any rate one needs to port it to GTK+ 3 before even thinking about WebKit2.

Comment 9 Hin-Tak Leung 2016-09-16 21:04:55 UTC
It looks like they were already moving towards gtk3 with 2.9.x (see known issues in http://banshee.fm/download/archives/2.9.1/ ) over two years ago. So in a year's time, this may be a non-problem, when they can complete the gtk3 move.

BTW, it may not be as serious an issue as it sounds - banshee on Mac OS X has an entirely different GUI based on Xamarin Mac (C# binding to Mac's native GUI kit...), and the Mac OS X's webkit framework. So the webkit-sharp dependent component is already somewhat modularized and replacible already, for running on a different platform.

Comment 10 Fedora End Of Life 2017-02-28 10:16:34 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 11 Fedora Update System 2017-07-18 19:36:09 UTC
banshee-2.6.2-21.fc26 dbus-sharp-0.8.1-2.fc26 mono-zeroconf-0.9.0-19.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc40ade2bd

Comment 12 Fedora Update System 2017-07-18 19:36:40 UTC
banshee-2.6.2-21.fc26 dbus-sharp-0.8.1-2.fc26 mono-zeroconf-0.9.0-19.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc40ade2bd

Comment 13 Fedora Update System 2017-07-20 00:24:47 UTC
banshee-2.6.2-21.fc26, dbus-sharp-0.8.1-2.fc26, mono-zeroconf-0.9.0-19.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc40ade2bd

Comment 14 Fedora Update System 2017-07-23 16:20:54 UTC
banshee-2.6.2-22.fc26 dbus-sharp-0.8.1-3.fc26 mono-zeroconf-0.9.0-20.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc40ade2bd

Comment 15 Fedora Update System 2017-07-25 04:24:11 UTC
banshee-2.6.2-22.fc26, dbus-sharp-0.8.1-3.fc26, mono-zeroconf-0.9.0-20.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc40ade2bd

Comment 16 Fedora Update System 2017-08-02 16:49:07 UTC
banshee-2.6.2-22.fc26, dbus-sharp-0.8.1-3.fc26, mono-zeroconf-0.9.0-20.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.