Red Hat Bugzilla – Bug 137629
evo: false positives in link-guessing
Last modified: 2007-11-30 17:10:53 EST
Description of problem:
Evolution seems to think the text "gnome-fs-ftp.png" should be a link.
Specifically, the "ftp.png" part - "ftp://ftp.png". It seems pretty
obvious that this should not be a link to me.
Here are some possible criteria to consider for the following
question: Should this string be a link, even though it lacks a
protocol prefix (like 'http://') and any slashes?
- NO if there are less than 2 dots in it (skip things like www.foo,
- NO if there is random junk before it (like 'gnome-fs-')
- NO if the characters between the last dot and the end of the string
are on a blacklist of common file extensions (but what about .COM files ;)
- YES if the characters between the last dot and the end of the string
are on a whitelist of valid TLDs
Obviously, the last criterion would be both slow and a pain to
maintain, and the third one would be highly subjective. Personally, I
like the first two... any ideas?
Version-Release number of selected component (if applicable):
Created attachment 105958 [details]
screenshot of gnome-fs-ftp.png link
Still affects rawhide right now.
Code in e-utils/e_text_to_html_full does a !strncasecmp (cur, "ftp://", 6)
which ought to work properly, so I suspect something else is at fault here.
Still affects rawhide; evolution-2.5.2-1
Filed upstream here:
I'm confused: You added it to FC5Target, then closed it.