Bug 1376645 - recipe reviewed state should not be set automatically if the recipe is still running
Summary: recipe reviewed state should not be set automatically if the recipe is still ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 23
Hardware: Unspecified
OS: Unspecified
low
unspecified
Target Milestone: 23.3
Assignee: Dan Callaghan
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-16 03:28 UTC by Dan Callaghan
Modified: 2016-11-07 06:44 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-07 06:44:26 UTC
Embargoed:


Attachments (Terms of Use)

Description Dan Callaghan 2016-09-16 03:28:28 UTC
Description of problem:


Version-Release number of selected component (if applicable):
23

How reproducible:
easily

Steps to Reproduce:
1. Find a running recipe, open the recipe page
2. Click through to its containing job

Actual results:
The reviewed checkbox for the recipe is checked, because I viewed the recipe page.

Expected results:
It doesn't make sense to consider a recipe as reviewed if it's still running (and therefore producing more results which might require further review). The reviewed checkbox should only be set automatically if the recipe is finished (or in Reserved state, because it also cannot produce any more results at that point).

However there's no reason to prevent people from *manually* marking a recipe as reviewed regardless of its status.

Comment 1 Dan Callaghan 2016-10-04 05:58:01 UTC
http://gerrit.beaker-project.org/5290

Comment 4 Dan Callaghan 2016-11-07 06:44:26 UTC
Beaker 23.3 has been released.


Note You need to log in before you can comment on or make changes to this bug.