Bug 1376900 - Review Request: espeak-ng - eSpeak NG Text-to-Speech
Summary: Review Request: espeak-ng - eSpeak NG Text-to-Speech
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Menšík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1376899
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-16 19:17 UTC by Ondřej Lysoněk
Modified: 2017-02-09 20:24 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-09 20:24:03 UTC
Type: ---
Embargoed:
pemensik: fedora-review+


Attachments (Terms of Use)

Description Ondřej Lysoněk 2016-09-16 19:17:21 UTC
Spec URL: http://www.fi.muni.cz/~xlysonek/espeak-ng.spec
SRPM URL: http://www.fi.muni.cz/~xlysonek/espeak-ng-1.49.0-1.fc24.src.rpm
Description: The eSpeak NG (Next Generation) Text-to-Speech program is an open source speech
synthesizer that supports over 70 languages. It is based on the eSpeak engine
created by Jonathan Duddington. It uses spectral formant synthesis by default
which sounds robotic, but can be configured to use Klatt formant synthesis
or MBROLA to give it a more natural sound.
Fedora Account System Username: olysonek

Comment 1 Ondřej Lysoněk 2016-09-16 19:51:11 UTC
The following package needs to be reviewed first, otherwise the build will fail because of an unsatisfied dependency:
https://bugzilla.redhat.com/show_bug.cgi?id=1376899

Comment 2 Petr Menšík 2016-09-21 14:51:27 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc make
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)", "*No copyright* GPL (v3 or later)", "GPL (v3
     or later)", "Unknown or generated". 1254 files have unknown license.
     Detailed output of licensecheck in
     /home/pemensik/fedora/rawhide/1376900-espeak-ng/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners:
     /usr/share/vim/vimfiles/ftdetect, /usr/share/vim/vimfiles/syntax,
     /usr/share/vim, /usr/share/vim/vimfiles
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content.
     License of espeak-ng-1.49.0/src/libespeak-ng/ieee80.c is not GPL compatible.
     Variant with acceptable license should might be for example:
     http://www.realitypixels.com/turk/opensource/ToFromIEEE.c.txt
[x]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
     Note: first uses parallel macro for binaries, then non-parallel for
     the rest
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in espeak-
     ng-devel , espeak-ng-vim , espeak-ng-doc , espeak-ng-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Package should not use obsolete m4 macros
     Note: Some obsoleted macros found, see the attachment.
     See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
[-]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2703360 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: espeak-ng-1.49.0-1.fc26.x86_64.rpm
          espeak-ng-devel-1.49.0-1.fc26.x86_64.rpm
          espeak-ng-vim-1.49.0-1.fc26.x86_64.rpm
          espeak-ng-doc-1.49.0-1.fc26.x86_64.rpm
          espeak-ng-debuginfo-1.49.0-1.fc26.x86_64.rpm
          espeak-ng-1.49.0-1.fc26.src.rpm
espeak-ng.x86_64: W: summary-not-capitalized C eSpeak NG Text-to-Speech
espeak-ng.x86_64: W: spelling-error %description -l en_US formant -> dormant, format, form ant
espeak-ng-devel.x86_64: W: only-non-binary-in-usr-lib
espeak-ng-devel.x86_64: W: no-documentation
espeak-ng-vim.x86_64: W: no-documentation
espeak-ng.src: W: summary-not-capitalized C eSpeak NG Text-to-Speech
espeak-ng.src: W: spelling-error %description -l en_US formant -> dormant, format, form ant
6 packages and 0 specfiles checked; 0 errors, 7 warnings.




Rpmlint (debuginfo)
-------------------
Checking: espeak-ng-debuginfo-1.49.0-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
espeak-ng-vim.x86_64: W: no-documentation
espeak-ng-devel.x86_64: W: only-non-binary-in-usr-lib
espeak-ng-devel.x86_64: W: no-documentation
espeak-ng.x86_64: W: summary-not-capitalized C eSpeak NG Text-to-Speech
espeak-ng.x86_64: W: spelling-error %description -l en_US formant -> dormant, format, form ant
5 packages and 0 specfiles checked; 0 errors, 5 warnings.



Requires
--------
espeak-ng-vim (rpmlib, GLIBC filtered):
    espeak-ng

espeak-ng-debuginfo (rpmlib, GLIBC filtered):

espeak-ng-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    espeak-ng
    libespeak-ng.so.1()(64bit)

espeak-ng (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libespeak-ng.so.1()(64bit)
    libm.so.6()(64bit)
    libpcaudio.so.0()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

espeak-ng-doc (rpmlib, GLIBC filtered):
    espeak-ng



Provides
--------
espeak-ng-vim:
    espeak-ng-vim
    espeak-ng-vim(x86-64)

espeak-ng-debuginfo:
    espeak-ng-debuginfo
    espeak-ng-debuginfo(x86-64)

espeak-ng-devel:
    espeak-ng-devel
    espeak-ng-devel(x86-64)
    pkgconfig(espeak-ng)

espeak-ng:
    espeak-ng
    espeak-ng(x86-64)
    libespeak-ng.so.1()(64bit)

espeak-ng-doc:
    espeak-ng-doc
    espeak-ng-doc(x86-64)



Source checksums
----------------
https://github.com/espeak-ng/espeak-ng/archive/1.49.0.tar.gz :
  CHECKSUM(SHA256) this package     : c7ef98b5bf86ffc00cde8930fc7a2182826d82ea183a03c85b24218c30eaddb2
  CHECKSUM(SHA256) upstream package : c7ef98b5bf86ffc00cde8930fc7a2182826d82ea183a03c85b24218c30eaddb2


AutoTools: Obsoleted m4s found
------------------------------
  AC_PROG_LIBTOOL found in: espeak-ng-1.49.0/configure.ac:19


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -c -b 1376900 -m fedora-rawhide-x86_64 -L /home/pemensik/fedora/rawhide/1376899-pcaudiolib/libs
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Built with local dependencies:
    /home/pemensik/fedora/rawhide/1376899-pcaudiolib/libs/pcaudiolib-debuginfo-1.0-1.fc26.x86_64.rpm
    /home/pemensik/fedora/rawhide/1376899-pcaudiolib/libs/pcaudiolib-devel-1.0-1.fc26.x86_64.rpm
    /home/pemensik/fedora/rawhide/1376899-pcaudiolib/libs/pcaudiolib-1.0-1.fc26.x86_64.rpm

Comment 3 Petr Menšík 2016-09-21 14:59:59 UTC
licensecheck.txt:

*No copyright* GPL (v3 or later)
--------------------------------
espeak-ng-1.49.0/dictsource/de_rules
espeak-ng-1.49.0/dictsource/fa_list
espeak-ng-1.49.0/dictsource/ky_list
espeak-ng-1.49.0/phsource/ph_kyrgyz
espeak-ng-1.49.0/src/include/espeak-ng/speak_lib.h
espeak-ng-1.49.0/src/include/espeak/speak_lib.h

BSD (2 clause)
--------------
espeak-ng-1.49.0/src/compat/getopt.c

GPL (v3 or later)
-----------------
espeak-ng-1.49.0/dictsource/en_rules
espeak-ng-1.49.0/dictsource/fa_rules
espeak-ng-1.49.0/dictsource/fr_list
espeak-ng-1.49.0/dictsource/fr_rules
espeak-ng-1.49.0/dictsource/ky_rules
espeak-ng-1.49.0/dictsource/ta_rules
espeak-ng-1.49.0/src/espeak-ng.c
espeak-ng-1.49.0/src/include/compat/getopt.h
espeak-ng-1.49.0/src/include/compat/math.h
espeak-ng-1.49.0/src/include/compat/stdint.h
espeak-ng-1.49.0/src/include/compat/string.h
espeak-ng-1.49.0/src/include/compat/strings.h
espeak-ng-1.49.0/src/include/compat/sys/stat.h
espeak-ng-1.49.0/src/include/compat/unistd.h
espeak-ng-1.49.0/src/include/espeak-ng/espeak_ng.h
espeak-ng-1.49.0/src/libespeak-ng/compiledata.c
espeak-ng-1.49.0/src/libespeak-ng/compiledict.c
espeak-ng-1.49.0/src/libespeak-ng/compilembrola.c
espeak-ng-1.49.0/src/libespeak-ng/dictionary.c
espeak-ng-1.49.0/src/libespeak-ng/error.c
espeak-ng-1.49.0/src/libespeak-ng/error.h
espeak-ng-1.49.0/src/libespeak-ng/espeak_api.c
espeak-ng-1.49.0/src/libespeak-ng/espeak_command.c
espeak-ng-1.49.0/src/libespeak-ng/espeak_command.h
espeak-ng-1.49.0/src/libespeak-ng/event.c
espeak-ng-1.49.0/src/libespeak-ng/event.h
espeak-ng-1.49.0/src/libespeak-ng/fifo.c
espeak-ng-1.49.0/src/libespeak-ng/fifo.h
espeak-ng-1.49.0/src/libespeak-ng/intonation.c
espeak-ng-1.49.0/src/libespeak-ng/klatt.c
espeak-ng-1.49.0/src/libespeak-ng/klatt.h
espeak-ng-1.49.0/src/libespeak-ng/mbrowrap.c
espeak-ng-1.49.0/src/libespeak-ng/mbrowrap.h
espeak-ng-1.49.0/src/libespeak-ng/numbers.c
espeak-ng-1.49.0/src/libespeak-ng/phoneme.h
espeak-ng-1.49.0/src/libespeak-ng/phonemelist.c
espeak-ng-1.49.0/src/libespeak-ng/readclause.c
espeak-ng-1.49.0/src/libespeak-ng/setlengths.c
espeak-ng-1.49.0/src/libespeak-ng/sintab.h
espeak-ng-1.49.0/src/libespeak-ng/spect.c
espeak-ng-1.49.0/src/libespeak-ng/spect.h
espeak-ng-1.49.0/src/libespeak-ng/speech.c
espeak-ng-1.49.0/src/libespeak-ng/speech.h
espeak-ng-1.49.0/src/libespeak-ng/synth_mbrola.c
espeak-ng-1.49.0/src/libespeak-ng/synthdata.c
espeak-ng-1.49.0/src/libespeak-ng/synthesize.c
espeak-ng-1.49.0/src/libespeak-ng/synthesize.h
espeak-ng-1.49.0/src/libespeak-ng/tr_languages.c
espeak-ng-1.49.0/src/libespeak-ng/translate.c
espeak-ng-1.49.0/src/libespeak-ng/translate.h
espeak-ng-1.49.0/src/libespeak-ng/voice.h
espeak-ng-1.49.0/src/libespeak-ng/voices.c
espeak-ng-1.49.0/src/libespeak-ng/wavegen.c
espeak-ng-1.49.0/src/speak-ng.c
espeak-ng-1.49.0/src/windows/com/comentrypoints.c
espeak-ng-1.49.0/src/windows/com/ttsengine.cpp

Unknown or generated
--------------------
espeak-ng-1.49.0/CHANGELOG.md
espeak-ng-1.49.0/COPYING
espeak-ng-1.49.0/README.md
espeak-ng-1.49.0/autogen.sh
espeak-ng-1.49.0/dictsource/ReadMe
espeak-ng-1.49.0/dictsource/af_list
espeak-ng-1.49.0/dictsource/af_rules
espeak-ng-1.49.0/dictsource/am_list
espeak-ng-1.49.0/dictsource/am_rules
espeak-ng-1.49.0/dictsource/an_list
espeak-ng-1.49.0/dictsource/an_rules
espeak-ng-1.49.0/dictsource/as_list
espeak-ng-1.49.0/dictsource/as_rules
espeak-ng-1.49.0/dictsource/az_list
espeak-ng-1.49.0/dictsource/az_rules
espeak-ng-1.49.0/dictsource/bg_list
espeak-ng-1.49.0/dictsource/bg_listx
espeak-ng-1.49.0/dictsource/bg_rules
espeak-ng-1.49.0/dictsource/bn_list
espeak-ng-1.49.0/dictsource/bn_rules
espeak-ng-1.49.0/dictsource/ca_list
espeak-ng-1.49.0/dictsource/ca_rules
espeak-ng-1.49.0/dictsource/cs_list
espeak-ng-1.49.0/dictsource/cs_rules
espeak-ng-1.49.0/dictsource/cy_list
espeak-ng-1.49.0/dictsource/cy_rules
espeak-ng-1.49.0/dictsource/da_list
espeak-ng-1.49.0/dictsource/da_rules
espeak-ng-1.49.0/dictsource/de_list
espeak-ng-1.49.0/dictsource/el_list
espeak-ng-1.49.0/dictsource/el_rules
espeak-ng-1.49.0/dictsource/en_list
espeak-ng-1.49.0/dictsource/eo_list
espeak-ng-1.49.0/dictsource/eo_rules
espeak-ng-1.49.0/dictsource/es_list
espeak-ng-1.49.0/dictsource/es_rules
espeak-ng-1.49.0/dictsource/et_list
espeak-ng-1.49.0/dictsource/et_rules
espeak-ng-1.49.0/dictsource/eu_list
espeak-ng-1.49.0/dictsource/eu_rules
espeak-ng-1.49.0/dictsource/extra/ru_listx
espeak-ng-1.49.0/dictsource/extra/zh_listx
espeak-ng-1.49.0/dictsource/extra/zhy_list
espeak-ng-1.49.0/dictsource/fi_list
espeak-ng-1.49.0/dictsource/fi_rules
espeak-ng-1.49.0/dictsource/ga_list
espeak-ng-1.49.0/dictsource/ga_rules
espeak-ng-1.49.0/dictsource/gd_list
espeak-ng-1.49.0/dictsource/gd_rules
espeak-ng-1.49.0/dictsource/gn_list
espeak-ng-1.49.0/dictsource/gn_rules
espeak-ng-1.49.0/dictsource/grc_list
espeak-ng-1.49.0/dictsource/grc_rules
espeak-ng-1.49.0/dictsource/gu_list
espeak-ng-1.49.0/dictsource/gu_rules
espeak-ng-1.49.0/dictsource/hbs_list
espeak-ng-1.49.0/dictsource/hbs_rules
espeak-ng-1.49.0/dictsource/hi_list
espeak-ng-1.49.0/dictsource/hi_rules
espeak-ng-1.49.0/dictsource/hu_list
espeak-ng-1.49.0/dictsource/hu_rules
espeak-ng-1.49.0/dictsource/hy_list
espeak-ng-1.49.0/dictsource/hy_rules
espeak-ng-1.49.0/dictsource/ia_list
espeak-ng-1.49.0/dictsource/ia_rules
espeak-ng-1.49.0/dictsource/id_list
espeak-ng-1.49.0/dictsource/id_rules
espeak-ng-1.49.0/dictsource/is_list
espeak-ng-1.49.0/dictsource/is_rules
espeak-ng-1.49.0/dictsource/it_list
espeak-ng-1.49.0/dictsource/it_listx
espeak-ng-1.49.0/dictsource/it_rules
espeak-ng-1.49.0/dictsource/jbo_list
espeak-ng-1.49.0/dictsource/jbo_rules
espeak-ng-1.49.0/dictsource/ka_list
espeak-ng-1.49.0/dictsource/ka_rules
espeak-ng-1.49.0/dictsource/kl_list
espeak-ng-1.49.0/dictsource/kl_rules
espeak-ng-1.49.0/dictsource/kn_list
espeak-ng-1.49.0/dictsource/kn_rules
espeak-ng-1.49.0/dictsource/ko_list
espeak-ng-1.49.0/dictsource/ko_rules
espeak-ng-1.49.0/dictsource/ku_list
espeak-ng-1.49.0/dictsource/ku_rules
espeak-ng-1.49.0/dictsource/la_list
espeak-ng-1.49.0/dictsource/la_rules
espeak-ng-1.49.0/dictsource/lfn_list
espeak-ng-1.49.0/dictsource/lfn_rules
espeak-ng-1.49.0/dictsource/lt_list
espeak-ng-1.49.0/dictsource/lt_rules
espeak-ng-1.49.0/dictsource/lv_list
espeak-ng-1.49.0/dictsource/lv_rules
espeak-ng-1.49.0/dictsource/mk_list
espeak-ng-1.49.0/dictsource/mk_rules
espeak-ng-1.49.0/dictsource/ml_list
espeak-ng-1.49.0/dictsource/ml_rules
espeak-ng-1.49.0/dictsource/mni_list
espeak-ng-1.49.0/dictsource/mr_list
espeak-ng-1.49.0/dictsource/mr_rules
espeak-ng-1.49.0/dictsource/ms_list
espeak-ng-1.49.0/dictsource/ms_rules
espeak-ng-1.49.0/dictsource/mt_list
espeak-ng-1.49.0/dictsource/mt_rules
espeak-ng-1.49.0/dictsource/my_list
espeak-ng-1.49.0/dictsource/my_rules
espeak-ng-1.49.0/dictsource/nci_list
espeak-ng-1.49.0/dictsource/nci_rules
espeak-ng-1.49.0/dictsource/ne_list
espeak-ng-1.49.0/dictsource/ne_rules
espeak-ng-1.49.0/dictsource/nl_list
espeak-ng-1.49.0/dictsource/nl_rules
espeak-ng-1.49.0/dictsource/no_list
espeak-ng-1.49.0/dictsource/no_rules
espeak-ng-1.49.0/dictsource/om_list
espeak-ng-1.49.0/dictsource/om_rules
espeak-ng-1.49.0/dictsource/or_list
espeak-ng-1.49.0/dictsource/or_rules
espeak-ng-1.49.0/dictsource/pa_list
espeak-ng-1.49.0/dictsource/pa_rules
espeak-ng-1.49.0/dictsource/pap_list
espeak-ng-1.49.0/dictsource/pap_rules
espeak-ng-1.49.0/dictsource/pl_list
espeak-ng-1.49.0/dictsource/pl_rules
espeak-ng-1.49.0/dictsource/pt_list
espeak-ng-1.49.0/dictsource/pt_rules
espeak-ng-1.49.0/dictsource/ro_list
espeak-ng-1.49.0/dictsource/ro_rules
espeak-ng-1.49.0/dictsource/ru_list
espeak-ng-1.49.0/dictsource/ru_rules
espeak-ng-1.49.0/dictsource/si_list
espeak-ng-1.49.0/dictsource/si_rules
espeak-ng-1.49.0/dictsource/sk_list
espeak-ng-1.49.0/dictsource/sk_rules
espeak-ng-1.49.0/dictsource/sl_list
espeak-ng-1.49.0/dictsource/sl_rules
espeak-ng-1.49.0/dictsource/sq_list
espeak-ng-1.49.0/dictsource/sq_rules
espeak-ng-1.49.0/dictsource/sv_list
espeak-ng-1.49.0/dictsource/sv_rules
espeak-ng-1.49.0/dictsource/sw_list
espeak-ng-1.49.0/dictsource/sw_rules
espeak-ng-1.49.0/dictsource/ta_list
espeak-ng-1.49.0/dictsource/te_list
espeak-ng-1.49.0/dictsource/te_rules
espeak-ng-1.49.0/dictsource/tn_list
espeak-ng-1.49.0/dictsource/tn_rules
espeak-ng-1.49.0/dictsource/tr_list
espeak-ng-1.49.0/dictsource/tr_rules
espeak-ng-1.49.0/dictsource/tt_list
espeak-ng-1.49.0/dictsource/tt_rules
espeak-ng-1.49.0/dictsource/ur_list
espeak-ng-1.49.0/dictsource/ur_rules
espeak-ng-1.49.0/dictsource/vi_list
espeak-ng-1.49.0/dictsource/vi_rules
espeak-ng-1.49.0/dictsource/zh_list
espeak-ng-1.49.0/dictsource/zh_rules
espeak-ng-1.49.0/dictsource/zhy_rules
espeak-ng-1.49.0/docs/add_language.md
espeak-ng-1.49.0/docs/dictionary.md
espeak-ng-1.49.0/docs/index.md
espeak-ng-1.49.0/docs/intonation.md
espeak-ng-1.49.0/docs/markup.md
espeak-ng-1.49.0/docs/mbrola.md
espeak-ng-1.49.0/docs/phontab.md
espeak-ng-1.49.0/docs/voices.md
espeak-ng-1.49.0/espeak-ng-data/voices/*
espeak-ng-1.49.0/phsource/*
espeak-ng-1.49.0/src/libespeak-ng/ieee80.c
espeak-ng-1.49.0/src/windows/config.h

Comment 4 Petr Menšík 2016-09-21 15:25:02 UTC
See also https://lists.debian.org/debian-accessibility/2016/09/msg00123.html about ieee80.c license.

Comment 5 Ondřej Lysoněk 2016-09-22 15:28:26 UTC
Thank you! I'll wait for the promised espeak-ng 1.49.1 release.

Comment 6 Petr Menšík 2016-09-22 17:14:38 UTC
In the meantime please change %{name} in %package devel Requires to %{name}%{_isa}.
Also add BuildArch: noarch into %package vim and doc.

Comment 7 Ondřej Lysoněk 2017-01-24 09:56:26 UTC
I packaged the new 1.49.1 release and updated the spec according to your comments.

Spec URL: http://www.fi.muni.cz/~xlysonek/espeak-ng.spec
SRPM URL: http://www.fi.muni.cz/~xlysonek/espeak-ng-1.49.1-1.fc24.src.rpm

Comment 8 Petr Menšík 2017-01-24 16:10:44 UTC
Good. I did write _isa macro wrong. Sorry. Correct line for devel is

Requires: %{name}%{?_isa} = %{version}-%{release}

You have to distribute COPYING.IEEE with the package, add it with %license COPYING.IEEE to the main package.

There is no more that prevents it for inclusion in Fedora IMO.

Comment 9 Ondřej Lysoněk 2017-01-24 16:45:52 UTC
Right, thanks.

Spec URL: http://www.fi.muni.cz/~xlysonek/espeak-ng.spec
SRPM URL: http://www.fi.muni.cz/~xlysonek/espeak-ng-1.49.1-2.fc24.src.rpm

Comment 10 Ondřej Lysoněk 2017-01-30 15:07:00 UTC
Can I have my fedora-review+?

Comment 11 Petr Menšík 2017-01-31 10:59:47 UTC
Oh yes, you can.

Comment 12 Gwyn Ciesla 2017-01-31 17:32:28 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/espeak-ng

Comment 13 Fedora Update System 2017-01-31 18:54:05 UTC
espeak-ng-1.49.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bdfd346538

Comment 14 Fedora Update System 2017-02-01 23:50:58 UTC
espeak-ng-1.49.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bdfd346538

Comment 15 Fedora Update System 2017-02-09 20:24:03 UTC
espeak-ng-1.49.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.