Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-jinja2.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python3-jinja2-2.8-1.el7.src.rpm Description: Jinja2 is a template engine written in pure Python. It provides a Django inspired non-XML syntax but supports inline expressions and an optional sandboxed environment. If you have any exposure to other text-based template languages, such as Smarty or Django, you should feel right at home with Jinja2. It's both designer and developer friendly by sticking to Python's principles and adding functionality useful for templating environments. Fedora Account System Username: orion This in an EPEL7 only package.
I am also willing to consider adding to EPEL6.
Koji EPEL7 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16643818 Koji EL6 build (fail, but not required): http://koji.fedoraproject.org/koji/taskinfo?taskID=16643910 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package contains BR: python2-devel or python3-devel => OK: uses python%{python3_pkgversion}-devel is used and this is EPEL only. - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1146880 bytes in 87 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation [!] should be split out to doc sub-package - Should use or document reason not to use: [!]: Uses parallel make %{?_smp_mflags} macro. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 44 files have unknown license. Detailed output of licensecheck in /home/parallels/1376934-python3-jinja2/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/licenses => OK: no default owner of /usr/share/licenses in EPEL [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/licenses [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python34-jinja2-2.8-1.el7.centos.noarch.rpm python3-jinja2-2.8-1.el7.centos.src.rpm python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/_stringdefs.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/parser.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/_compat.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/_compat.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/_stringdefs.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/parser.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/environment.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/ext.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/environment.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/ext.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/runtime.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/runtime.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/compiler.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/compiler.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/tests.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/tests.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/optimizer.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/optimizer.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/visitor.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/bccache.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/visitor.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/bccache.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/meta.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/meta.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/nodes.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/nodes.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: W: hidden-file-or-dir /usr/share/doc/python34-jinja2-2.8/html/.buildinfo python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/filters.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/filters.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/utils.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/defaults.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/defaults.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/utils.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/lexer.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/lexer.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/sandbox.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/sandbox.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/debug.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/debug.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/loaders.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/loaders.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/constants.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/constants.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/exceptions.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/exceptions.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) => OK: this is because of a bug in rpmlint python3-jinja2.src:40: W: macro-in-comment %{python3_pkgversion} => OK 2 packages and 0 specfiles checked; 46 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/_stringdefs.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) <-- snip --> python34-jinja2.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/jinja2/__pycache__/exceptions.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) 1 packages and 0 specfiles checked; 46 errors, 1 warnings. Requires -------- python34-jinja2 (rpmlib, GLIBC filtered): python(abi) python34-markupsafe python34-setuptools Provides -------- python34-jinja2: python34-jinja2 Source checksums ---------------- http://pypi.python.org/packages/source/J/Jinja2/Jinja2-2.8.tar.gz : CHECKSUM(SHA256) this package : bc1ff2ff88dbfacefde4ddde471d1417d3b304e8df103a7a9437d47269201bf4 CHECKSUM(SHA256) upstream package : bc1ff2ff88dbfacefde4ddde471d1417d3b304e8df103a7a9437d47269201bf4 Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -b 1376934 Buildroot used: epel-7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-jinja2.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python3-jinja2-2.8-2.el7.src.rpm * Tue Nov 29 2016 Orion Poplawski <orion.com> - 2.8-2 - Use github tarball and run tests - Split documentation in sub-package
Koji EPEL7 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16727251 Koji EL6 build (fails, but not required): http://koji.fedoraproject.org/koji/taskinfo?taskID=16727311 (needs python2-markupsafe in EL6) All review requests addressed: [x] separate docs package [x] %make_build instead of make addresses parallel make warning Bonus: [x] tests run in %check APPROVED
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python3-jinja2
python3-jinja2-2.8-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-45c1c0b276
python3-jinja2-2.8-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d4293aff8d
python3-jinja2-2.8-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d4293aff8d
python3-jinja2-2.8-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-45c1c0b276
python3-jinja2-2.8-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
python3-jinja2-2.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.