Bug 1377105 - Nilclass for servicetemplateprovisionrequest_pending method
Summary: Nilclass for servicetemplateprovisionrequest_pending method
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.8.0
Assignee: William Fitzgerald
QA Contact: Dmitry Misharov
URL:
Whiteboard: automate:service:provision
Depends On:
Blocks: 1379693 1383503
TreeView+ depends on / blocked
 
Reported: 2016-09-18 13:24 UTC by Tsai Li Ming
Modified: 2019-08-06 20:03 UTC (History)
9 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1379693 1383503 (view as bug list)
Environment:
Last Closed: 2017-06-12 16:09:42 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Tsai Li Ming 2016-09-18 13:24:48 UTC
Description of problem:

[----] I, [2016-09-18T20:52:26.122863 #13596:10b0ea4]  INFO -- : <AutomationEngine> <AEMethod servicetemplateprovisionrequest_pending> [undefined method `+' for nil:NilClass]
<code: body += "<a href='https://#{appliance}/miq_request/show/#{@miq_request.id}'>">:57:in `requester_href'
<code: body += requester_href(appliance)>:66:in `requester_text'
<code: send_mail(to, from, subject, requester_text(appliance))>:78:in `email_requester'
<code: email_requester(appliance)>:92:in `<main>'

Version-Release number of selected component (if applicable):
4.1.1

How reproducible:
Always

Steps to Reproduce:
1. Trigger the automate method
2.
3.

Actual results:
Traceback because of:
def requester_href(appliance)
  body += "<a href='https://#{appliance}/miq_request/show/#{@miq_request.id}'>" 
  ^^^^^^^^
  body += "https://#{appliance}/miq_request/show/#{@miq_request.id}</a>"
  body
end


Expected results:
No traceback

Additional info:

Comment 2 William Fitzgerald 2016-09-19 22:18:50 UTC
Tsai,

Can I get access to your appliance?  

Thanks

Billy

Comment 5 William Fitzgerald 2016-10-10 15:24:50 UTC
https://github.com/ManageIQ/manageiq/pull/11405

Comment 7 Milan Falešník 2017-04-27 10:01:36 UTC
Verified in 5.8.0.12.

I did these steps:
1) I enabled notifier role on my appliance and configured the smtp server (removing the login auth to none is enough)
2) I added my e-mail address into the admin user account
3) I created a dummy dialog
4) I created an additional domain in Automate
5) I copied ManageIQ/Service/Provisioning/StateMachines/ServiceProvisionRequestApproval/Default into the new domain and changed the auto to manual in it.
6) I created a generic service using the dummy dialog. I left all other fields intact
7) I initiated provisioning of the service.
8) I got an e-mail that it was not auto-approved
9) I tried both approval and disapproval and I received an appropriate e-mail upon making the decision.

Therefore, this bug is VERIFIED.


Note You need to log in before you can comment on or make changes to this bug.