Bug 1378028 - Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting threads and processes
Summary: Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1378014
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-21 11:00 UTC by Paul Howarth
Modified: 2016-10-21 15:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-09 18:51:06 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Paul Howarth 2016-09-21 11:00:53 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-MCE-Shared/branches/fedora/perl-MCE-Shared.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-MCE-Shared/perl-MCE-Shared-1.804-2.fc26.src.rpm

Description:
This module provides data sharing capabilities for MCE, supporting threads and
processes. MCE::Hobo provides threads-like parallelization for running code
asynchronously.

Fedora Account System Username: pghmcfc

Comment 2 Petr Pisar 2016-10-03 15:06:50 UTC
URL and Source addresses are usable. Ok.
Source archive is original (SHA-256: fecc71952ab13b88f65e6e3bb8815dae915c78455a098cc31af9842253c4dc81). Ok.
Summary is Ok.
Description verified from README.md. Ok.
License verified from lib/MCE/Shared.pm, README.md, Copying, LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

TODO: The dependency on `perl >= 4:5.10.1' is better written as `perl(:VERSION) >= 5.10.1'. You don't have to deal with the epoch number. (Although it's probably unavailable on EPEL.)

All tests pass. Ok.

$ rpmlint perl-MCE-Shared.spec ../SRPMS/perl-MCE-Shared-1.805-1.fc26.src.rpm ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm 
perl-MCE-Shared.src: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization
perl-MCE-Shared.noarch: W: spelling-error %description -l en_US parallelization -> palatalization, rationalization, pluralization
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm
drwxr-xr-x    2 root    root                        0 Oct  3 16:55 /usr/share/doc/perl-MCE-Shared
-rw-r--r--    1 root    root                     4350 Sep 23 08:04 /usr/share/doc/perl-MCE-Shared/Changes
-rw-r--r--    1 root    root                     3900 Sep 23 07:58 /usr/share/doc/perl-MCE-Shared/README.md
drwxr-xr-x    2 root    root                        0 Oct  3 16:55 /usr/share/licenses/perl-MCE-Shared
-rw-r--r--    1 root    root                    12633 Aug 22  2015 /usr/share/licenses/perl-MCE-Shared/Copying
-rw-r--r--    1 root    root                     6319 Aug 22  2015 /usr/share/licenses/perl-MCE-Shared/LICENSE
-rw-r--r--    1 root    root                     5657 Oct  3 16:54 /usr/share/man/man3/MCE::Hobo.3pm.gz
-rw-r--r--    1 root    root                     8016 Oct  3 16:54 /usr/share/man/man3/MCE::Shared.3pm.gz
-rw-r--r--    1 root    root                     5554 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Array.3pm.gz
-rw-r--r--    1 root    root                     1255 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Base.3pm.gz
-rw-r--r--    1 root    root                     3607 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Condvar.3pm.gz
-rw-r--r--    1 root    root                     3634 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Handle.3pm.gz
-rw-r--r--    1 root    root                     4574 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Hash.3pm.gz
-rw-r--r--    1 root    root                     7275 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Minidb.3pm.gz
-rw-r--r--    1 root    root                     7037 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Ordhash.3pm.gz
-rw-r--r--    1 root    root                     4372 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Queue.3pm.gz
-rw-r--r--    1 root    root                     2329 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Scalar.3pm.gz
-rw-r--r--    1 root    root                     2506 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Sequence.3pm.gz
-rw-r--r--    1 root    root                     1240 Oct  3 16:54 /usr/share/man/man3/MCE::Shared::Server.3pm.gz
drwxr-xr-x    2 root    root                        0 Oct  3 16:54 /usr/share/perl5/vendor_perl/MCE
-rw-r--r--    1 root    root                    26123 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Hobo.pm
drwxr-xr-x    2 root    root                        0 Oct  3 16:54 /usr/share/perl5/vendor_perl/MCE/Shared
-rw-r--r--    1 root    root                    32395 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Shared.pm
-rw-r--r--    1 root    root                    24185 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Shared/Array.pm
-rw-r--r--    1 root    root                     8547 Sep 23 08:00 /usr/share/perl5/vendor_perl/MCE/Shared/Base.pm
-rw-r--r--    1 root    root                     9928 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Condvar.pm
-rw-r--r--    1 root    root                    12273 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Handle.pm
-rw-r--r--    1 root    root                    19410 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Hash.pm
-rw-r--r--    1 root    root                    56625 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Minidb.pm
-rw-r--r--    1 root    root                    39521 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Ordhash.pm
-rw-r--r--    1 root    root                    25479 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Queue.pm
-rw-r--r--    1 root    root                     5580 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Scalar.pm
-rw-r--r--    1 root    root                     9834 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Sequence.pm
-rw-r--r--    1 root    root                    61509 Sep 23 08:01 /usr/share/perl5/vendor_perl/MCE/Shared/Server.pm
File permissions and layout is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.10.1
      1 perl(bytes)
      1 perl(Carp)
      1 perl(constant)
      1 perl(IO::FDPass)
      1 perl(MCE::Mutex)
      1 perl(MCE::Shared)
      1 perl(MCE::Shared::Array)
      1 perl(MCE::Shared::Base)
      1 perl(MCE::Shared::Hash)
      1 perl(MCE::Shared::Ordhash)
      1 perl(MCE::Shared::Server)
      1 perl(MCE::Util)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(Socket)
      1 perl(strict)
      1 perl(threads)
      1 perl(threads::shared)
      1 perl(Time::HiRes)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
FIX: Run-require `perl(overloading)' (lib/MCE/Shared/Server.pm:28).
FIX: Run-require `perl(Storable) >= 2.04' (lib/MCE/Shared/Minidb.pm:417).
FIX: Run-require `perl(Symbol)' (lib/MCE/Shared/Server.pm:306).

$ rpm -q --provides -p ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(MCE::Hobo) = 1.805
      1 perl(MCE::Shared) = 1.805
      1 perl(MCE::Shared::Array) = 1.805
      1 perl(MCE::Shared::Base) = 1.805
      1 perl(MCE::Shared::Condvar) = 1.805
      1 perl(MCE::Shared::Handle) = 1.805
      1 perl(MCE::Shared::Hash) = 1.805
      1 perl(MCE::Shared::Minidb) = 1.805
      1 perl(MCE::Shared::Object)
      1 perl(MCE::Shared::Ordhash) = 1.805
      1 perl(MCE::Shared::Ordhash::_href)
      1 perl(MCE::Shared::Queue) = 1.805
      1 perl(MCE::Shared::Scalar) = 1.805
      1 perl(MCE::Shared::Sequence) = 1.805
      1 perl(MCE::Shared::Server) = 1.805
      1 perl-MCE-Shared = 1.805-1.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15925335). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items and consider fixing `TODO' items before building this package.
Resolution: Package APPROVED.

Comment 3 Paul Howarth 2016-10-04 08:48:12 UTC
(In reply to Petr Pisar from comment #2)
> TODO: The dependency on `perl >= 4:5.10.1' is better written as
> `perl(:VERSION) >= 5.10.1'. You don't have to deal with the epoch number.
> (Although it's probably unavailable on EPEL.)

Indeed, this does not work on EL-7, which upstream is particularly keen to see MCE::Shared available on.

> FIX: Run-require `perl(overloading)' (lib/MCE/Shared/Server.pm:28).
> FIX: Run-require `perl(Storable) >= 2.04' (lib/MCE/Shared/Minidb.pm:417).
> FIX: Run-require `perl(Symbol)' (lib/MCE/Shared/Server.pm:306).

Fixed in perl-MCE-Shared-1.805-3

> Resolution: Package APPROVED.

Thanks for the review Petr.

Comment 4 Gwyn Ciesla 2016-10-04 12:24:54 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MCE-Shared

Comment 5 Fedora Update System 2016-10-05 11:21:55 UTC
perl-MCE-Shared-1.805-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3411eea4a3

Comment 6 Fedora Update System 2016-10-05 13:19:31 UTC
perl-MCE-Shared-1.805-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-be90ea5d91

Comment 7 Fedora Update System 2016-10-05 20:30:04 UTC
perl-MCE-Shared-1.805-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f5fd66e5fa

Comment 8 Fedora Update System 2016-10-09 18:51:06 UTC
perl-MCE-Shared-1.805-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-10-12 23:22:41 UTC
perl-MCE-Shared-1.805-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-10-21 15:51:15 UTC
perl-MCE-Shared-1.805-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.