Bug 1378031 - crash on remote-viewer vnc:foo:1
Summary: crash on remote-viewer vnc:foo:1
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: virt-viewer
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Berrangé
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-21 11:08 UTC by Dr. David Alan Gilbert
Modified: 2017-08-03 22:05 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-08-03 22:05:28 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Smal reproducer (743 bytes, text/x-csrc)
2016-09-22 09:49 UTC, Christophe Fergeau
no flags Details

Description Dr. David Alan Gilbert 2016-09-21 11:08:19 UTC
Description of problem:
I forgot the // in the URI and it reliably segs with:
     remote-viewer vnc:foo:1

Version-Release number of selected component (if applicable):
virt-viewer-4.0-1.fc24.x86_64

How reproducible:
100%

Steps to Reproduce:
1. remote-viewer vnc:foo:1
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Christophe Fergeau 2016-09-22 09:48:55 UTC
For what it's worth, the crash is in glib because we are trying to use it with bogus args. gtkvnc should not be passing these invalid args (NULL address, 0 port), but glib should also reject them before crashing :)

Comment 2 Christophe Fergeau 2016-09-22 09:49:43 UTC
Created attachment 1203644 [details]
Smal reproducer

Comment 3 Christophe Fergeau 2016-12-09 15:48:51 UTC
Just sent https://www.redhat.com/archives/virt-tools-list/2016-December/msg00006.html which should fix this, as well as https://bugzilla.gnome.org/show_bug.cgi?id=775890

Comment 4 Fedora End Of Life 2017-07-25 23:10:32 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 5 Cole Robinson 2017-08-03 22:05:28 UTC
The bug is gone because gtk-vnc was fixed not to crash. However Christophe your virt-viewer patch to improve the error message doesn't seem to have made it git, might wanna resend


Note You need to log in before you can comment on or make changes to this bug.