Bug 1378215 - deploy_hook() traceback on missing mandatory arguments
Summary: deploy_hook() traceback on missing mandatory arguments
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: preupgrade-assistant
Version: 6.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Petr Hracek
QA Contact: Alois Mahdal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-21 20:50 UTC by Alois Mahdal
Modified: 2016-11-04 08:59 UTC (History)
4 users (show)

Fixed In Version: preupgrade-assistant-2.1.10-3.el6
Doc Type: No Doc Update
Doc Text:
undefined
Clone Of:
Environment:
Last Closed: 2016-11-04 08:59:17 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2616 0 normal SHIPPED_LIVE preupgrade-assistant bug fix and enhancement update 2016-11-03 16:23:38 UTC

Description Alois Mahdal 2016-09-21 20:50:15 UTC 
Description of problem
======================

If an upgrade path module calls preupg.script_api.deploy_hook() but fails to provide mandatory arguments, the module will raise uncaught IndexError exception.  This is due to incorrect parsing of arguments
(`if arg[0] == "":`...)


Version-Release number of selected component
============================================

preupgrade-assistant-2.1.10-1.el6


How reproducible
================

Always


Steps to Reproduce
==================

 1. Have a Python upgrade path module call deploy_hook() without one or both
    mandatory arguments
 2. Observe HTML report or XML node


Actual results
==============

Traceback


Expected results
================

Useful error is logged


Additional info
===============

Upstream PR is ready:

    https://github.com/upgrades-migrations/preupgrade-assistant/pull/150
Comment 4 Alois Mahdal 2016-10-07 03:56:47 UTC 
Tested with preupgrade-assistant-2.1.10-5.el6.  All deploy_hook() (Bash and Python) cases now pass.
Comment 6 errata-xmlrpc 2016-11-04 08:59:17 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2616.html
Note You need to log in before you can comment on or make changes to this bug.