Description of problem: OpenStack murano-agent project has not been packaged in rpm for RDO, but murano services like python-muranoclient, openstack-murano-{engine,api,cf-api} - are packaged and presented in package repositories. Version-Release number of selected component (if applicable): Project git repository: https://github.com/openstack/murano-agent git tag 3.0.0.0rc1 rpm version 3.0.0.0rc1 Spec URL: https://raw.githubusercontent.com/akroshchenko/RPMs/master/murano-agent/murano-agent.spec SRPM URL: https://github.com/akroshchenko/RPMs/raw/master/murano-agent/murano-agent-3.0.0-0.1.rc1.el7.centos.src.rpm Description for packaged project: Murano Agent is a VM-side guest agent that accepts commands from Murano engine and executes them. Additional info: Package built and tested on CentOS7 using next repositories: 1) http://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-master-tested/ 2) http://buildlogs.centos.org/centos/7/cloud/x86_64/openstack-newton/ 3) http://dl.fedoraproject.org/pub/epel/7/x86_64/
Thanks for contributing this package!! Here you have some comments about this package: - upstream_version fallback macro has an extra '.' , it should be: %{!?upstream_version: %global upstream_version %{version}%{?milestone}} - Release should be "0.1%{?milestone}%{?dist}" - https should be used in Source0 url. - I'm not sure if there is a reason to jump from Source0 to Source10, we tipically use consecutive numbers, Source1, Source2, etc... - According to build logs, no tests are actually being executed in %check section (i think "--testr-args='{posargs}'" option can be removed) - docs built with build_sphinx are not being included in the package. - In install section, you can use py2_install macro instead of (%{__python2} setup.py install -O1 --skip-build --root %{buildroot}). Additionally, following errors are reported by rpmlint: 1. E: description-line-too-long C Murano Agent is the VM-side guest agent that accepts commands from Murano engine and executes them. It's recommended to use limit lines to 79 characters in description. As an additional note, RDO packages must not need EPEL packages, any requirement should be in Centos repo or RDO (delorean and delorean-deps)
Hi Alfredo, I updated package and re-upload it Spec URL: https://raw.githubusercontent.com/akroshchenko/RPMs/master/murano-agent/murano-agent.spec SRPM URL: https://github.com/akroshchenko/RPMs/blob/master/murano-agent/murano-agent-3.0.0-0.1.0rc2.el7.centos.src.rpm?raw=true I make some changes(https://github.com/akroshchenko/RPMs/blob/master/murano-agent/murano-agent.spec#L1) only for "my-build" workflow. Further, it will be deleted.
fedora-review is having problems with latest URLs, i'm updating it: Spec URL: https://raw.githubusercontent.com/akroshchenko/RPMs/master/murano-agent/murano-agent.spec SRPM URL: https://github.com/akroshchenko/RPMs/raw/master/murano-agent/murano-agent-3.0.0-0.1.0rc2.el7.centos.src.rpm
One more point, according to RDO standards, package name should be openstack-murano-agent. Note that, version packaged in last spec is 0rc2, but changelog still mentions 0rc1.
Amended according to Your comment: Spec URL: https://raw.githubusercontent.com/akroshchenko/RPMs/master/murano-agent/openstack-murano-agent.spec SRPM URL: https://github.com/akroshchenko/RPMs/blob/master/murano-agent/openstack-murano-agent-3.0.0-0.1.0rc2.el7.centos.src.rpm?raw=true
fedora-review is having problems with latest URLs, i'm updating it: Spec URL: https://raw.githubusercontent.com/akroshchenko/RPMs/master/murano-agent/openstack-murano-agent.spec SRPM URL: https://github.com/akroshchenko/RPMs/raw/master/murano-agent/openstack-murano-agent-3.0.0-0.1.0rc2.el7.centos.src.rpm
Fedora review results: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MIT/X11 (BSD like)", "Unknown or generated", "*No copyright* Apache (v2.0)". 32 files have unknown license. Detailed output of licensecheck in /tmp/test4/1378458-openstack- murano-agent/licensecheck.txt [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/murano-agent [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/logrotate.d, /etc/murano- agent [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 563200 bytes in 29 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openstack-murano-agent-3.0.0-0.1.0rc2.fc26.noarch.rpm openstack-murano-agent-3.0.0-0.1.0rc2.fc26.src.rpm openstack-murano-agent.noarch: W: summary-ended-with-dot C VM-side guest agent that accepts commands from Murano engine and executes them. openstack-murano-agent.noarch: W: incoherent-version-in-changelog 3.0.0.0rc2 ['3.0.0-0.1.0rc2.fc26', '3.0.0-0.1.0rc2'] openstack-murano-agent.noarch: E: incoherent-logrotate-file /etc/logrotate.d/murano-agent openstack-murano-agent.noarch: E: non-standard-dir-perm /var/log/murano-agent 750 openstack-murano-agent.noarch: W: no-manual-page-for-binary muranoagent openstack-murano-agent.src: W: summary-ended-with-dot C VM-side guest agent that accepts commands from Murano engine and executes them. 2 packages and 0 specfiles checked; 2 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- openstack-murano-agent.noarch: W: summary-ended-with-dot C VM-side guest agent that accepts commands from Murano engine and executes them. openstack-murano-agent.noarch: W: incoherent-version-in-changelog 3.0.0.0rc2 ['3.0.0-0.1.0rc2.fc26', '3.0.0-0.1.0rc2'] openstack-murano-agent.noarch: E: non-standard-dir-perm /var/log/murano-agent 750 openstack-murano-agent.noarch: E: incoherent-logrotate-file /etc/logrotate.d/murano-agent openstack-murano-agent.noarch: W: no-manual-page-for-binary muranoagent 1 packages and 0 specfiles checked; 2 errors, 3 warnings. Requires -------- openstack-murano-agent (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 GitPython PyYAML config(openstack-murano-agent) python(abi) python-anyjson python-eventlet python-kombu python-oslo-config python-oslo-log python-oslo-service python-oslo-utils python-pbr python-requests python-semantic-version python-six systemd Provides -------- openstack-murano-agent: config(openstack-murano-agent) openstack-murano-agent python2.7dist(murano-agent) python2dist(murano-agent) Source checksums ---------------- https://tarballs.openstack.org/murano-agent/murano-agent-3.0.0.0rc2.tar.gz : CHECKSUM(SHA256) this package : 32389cb48ee4aaaf4b622722e5f49cb1c683fd7baad1cb2e711d0f147bdbf989 CHECKSUM(SHA256) upstream package : 32389cb48ee4aaaf4b622722e5f49cb1c683fd7baad1cb2e711d0f147bdbf989
Some analysis from informal review. About Rpmlint errors: 1. openstack-murano-agent.noarch: E: non-standard-dir-perm /var/log/murano-agent 750 - I think it's ok to have more restrictive permissions for log dir as it may have security information. 2. openstack-murano-agent.noarch: E: incoherent-logrotate-file /etc/logrotate.d/murano-agent - I think it's ok to use murano-agent as name for logrotate config file, as it's the name of the log directory. Main package contains tests and html doc, there is not -doc and -tests subpackages. I think it's ok for a simple package as this one, but i'll wait for confirmation from bz owner.
I corrected permissions for log dir as, I suppose, it does not contain security information. I updated package and re-upload it Spec URL: https://raw.githubusercontent.com/akroshchenko/RPMs/master/murano-agent/openstack-murano-agent.spec SRPM URL: https://github.com/akroshchenko/RPMs/blob/master/murano-agent/openstack-murano-agent-3.0.0-0.1.0rc2.el7.centos.src.rpm?raw=true
Besides Alfredo's comment, just one warning: GitPython is not currently on the dependency repos used by RDO, so we'll need to add it.
Spec file was merged - https://review.rdoproject.org/r/#/c/3607/ Proposed changes to rdoinfo - https://review.rdoproject.org/r/#/c/3650/
The changes to rdoinfo were merged - https://review.rdoproject.org/r/#/c/3650/1
Package has been added to RDO Trunk repos. Related reviews https://review.rdoproject.org/r/#/q/topic:add-murano-agent First package in newton worker: https://trunk.rdoproject.org/centos7-newton/dd/a3/dda36c98913deb3be661be84c25dd4bb54608e90_a3c8466a/openstack-murano-agent-3.0.1-0.20161111153944.6a4af3f.el7.centos.noarch.rpm First package in master-uc worker (ocata cycle): https://trunk.rdoproject.org/centos7/consistent/openstack-murano-agent-3.0.0-0.20161111124119.d9237d0.el7.centos.noarch.rpm