Spec URL: https://luya.fedorapeople.org/packages/SPECS/f25-backgrounds.spec SRPM URL: https://luya.fedorapeople.org/packages/SRPMS/f25-backgrounds-25.0.0-1.fc24.src.rpm Description: This package contains desktop backgrounds for the Fedora 25 default theme. Pulls in themes for GNOME, KDE, Mate and Xfce desktops. Fedora Account System Username: luya
Scratch build result: http://koji.fedoraproject.org/koji/taskinfo?taskID=15770685
I don't know if it helps, but I saw your message asking for review and decided to try these packages. I am not a reviewer, but I am running f25. I was able to build the rpms locally from the src.rpm above, and install them successfully. For what it is worth.
(In reply to stan from comment #2) > I don't know if it helps, but I saw your message asking for review and > decided to try these packages. I am not a reviewer, but I am running f25. > I was able to build the rpms locally from the src.rpm above, and install > them successfully. For what it is worth. Good to hear. If you are interested, please read the document about the reviewer guideline: https://fedoraproject.org/wiki/Package_Review_Process#Reviewer
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290339 ?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/gil/1378971-f25-backgrounds/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/xfce4/backdrops [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gnome-background- properties, /usr/share/mate-background-properties, /usr/share/xfce4/backdrops [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in f25 -backgrounds-base , f25-backgrounds-kde , f25-backgrounds-gnome , f25 -backgrounds-mate , f25-backgrounds-xfce [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. See above "Issues" [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: f25-backgrounds-25.0.0-1.fc26.noarch.rpm f25-backgrounds-base-25.0.0-1.fc26.noarch.rpm f25-backgrounds-kde-25.0.0-1.fc26.noarch.rpm f25-backgrounds-gnome-25.0.0-1.fc26.noarch.rpm f25-backgrounds-mate-25.0.0-1.fc26.noarch.rpm f25-backgrounds-xfce-25.0.0-1.fc26.noarch.rpm f25-backgrounds-25.0.0-1.fc26.src.rpm f25-backgrounds.noarch: W: incoherent-version-in-changelog 24.0.0-1 ['25.0.0-1.fc26', '25.0.0-1'] f25-backgrounds.noarch: W: no-documentation f25-backgrounds-base.noarch: W: no-documentation f25-backgrounds-kde.noarch: W: no-documentation f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/640x480.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1152x720.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1680x1050.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x768.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/800x600.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1920x1440.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/2048x1536.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1440x900.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1920x1080.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x720.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1152x864.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1600x1200.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1440x1080.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1600x1280.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x1024.png ../../../../backgrounds/f25/default/normalish/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x960.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/800x480.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1366x768.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1024x600.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1200x900.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1024x768.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x800.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1920x1200.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-gnome.noarch: W: no-documentation f25-backgrounds-mate.noarch: W: no-documentation f25-backgrounds-xfce.noarch: W: no-documentation f25-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f25.png ../../backgrounds/f25/default/wide/f25.png 7 packages and 0 specfiles checked; 0 errors, 31 warnings. Rpmlint (installed packages) ---------------------------- f25-backgrounds-base.noarch: W: no-documentation f25-backgrounds-gnome.noarch: W: no-documentation f25-backgrounds.noarch: W: incoherent-version-in-changelog 24.0.0-1 ['25.0.0-1.fc26', '25.0.0-1'] f25-backgrounds.noarch: W: no-documentation f25-backgrounds-mate.noarch: W: no-documentation f25-backgrounds-kde.noarch: W: no-documentation f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1600x1280.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1024x600.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x1024.png ../../../../backgrounds/f25/default/normalish/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1440x900.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1152x720.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/800x480.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x800.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x768.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x960.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/640x480.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1200x900.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/2048x1536.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1024x768.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1440x1080.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1680x1050.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1920x1440.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1366x768.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1920x1080.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/800x600.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1600x1200.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1280x720.png ../../../../backgrounds/f25/default/tv-wide/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1152x864.png ../../../../backgrounds/f25/default/standard/f25.png f25-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F25/contents/images/1920x1200.png ../../../../backgrounds/f25/default/wide/f25.png f25-backgrounds-xfce.noarch: W: no-documentation f25-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f25.png ../../backgrounds/f25/default/wide/f25.png 6 packages and 0 specfiles checked; 0 errors, 31 warnings. Requires -------- f25-backgrounds-base (rpmlib, GLIBC filtered): f25-backgrounds-gnome (rpmlib, GLIBC filtered): f25-backgrounds-base f25-backgrounds (rpmlib, GLIBC filtered): f25-backgrounds-gnome f25-backgrounds-kde f25-backgrounds-mate f25-backgrounds-xfce f25-backgrounds-mate (rpmlib, GLIBC filtered): f25-backgrounds-base f25-backgrounds-kde (rpmlib, GLIBC filtered): f25-backgrounds-base kde-filesystem f25-backgrounds-xfce (rpmlib, GLIBC filtered): f25-backgrounds-base xfdesktop Provides -------- f25-backgrounds-base: f25-backgrounds-base f25-backgrounds-gnome: f25-backgrounds-gnome f25-backgrounds: f25-backgrounds f25-backgrounds-mate: f25-backgrounds-mate f25-backgrounds-kde: f25-backgrounds-kde f25-backgrounds-xfce: f25-backgrounds-xfce Source checksums ---------------- https://fedorahosted.org/released/design-team/f25-backgrounds-25.0.0.tar.xz : CHECKSUM(SHA256) this package : 57ad1c5311f7c1f9e9870ee6e6f7783ed45ab8d583b3078568fcf9c5cd9ca4c8 CHECKSUM(SHA256) upstream package : 57ad1c5311f7c1f9e9870ee6e6f7783ed45ab8d583b3078568fcf9c5cd9ca4c8 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1378971 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Issues: - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. NON blocking issues: f25-backgrounds.noarch: W: incoherent-version-in-changelog 24.0.0-1 ['25.0.0-1.fc26', '25.0.0-1']
desktop-file-validate ~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop /home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop: error: required key "Type" in group "Desktop Entry" is not present Is usual for this kind of desktop file?
(In reply to gil cattaneo from comment #4) > have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290339 ? Taken.
(In reply to gil cattaneo from comment #7) > desktop-file-validate > ~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26. > noarch.rpm/usr/share/wallpapers/F25/metadata.desktop > /home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1. > fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop: > > error: required key "Type" in group "Desktop Entry" is not present > > Is usual for this kind of desktop file? It is specific to KDE.
(In reply to Luya Tshimbalanga from comment #9) > (In reply to gil cattaneo from comment #7) > > desktop-file-validate > > ~/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1.fc26. > > noarch.rpm/usr/share/wallpapers/F25/metadata.desktop > > /home/gil/1378971-f25-backgrounds/rpms-unpacked/f25-backgrounds-kde-25.0.0-1. > > fc26.noarch.rpm/usr/share/wallpapers/F25/metadata.desktop: > > > > error: required key "Type" in group "Desktop Entry" is not present > > > > Is usual for this kind of desktop file? > > It is specific to KDE. Ok, fix changelog entry/ies before import Approved
Thank you, Gil!
SCM request F25: https://admin.fedoraproject.org/pkgdb/package/requests/7934 Master: https://admin.fedoraproject.org/pkgdb/package/requests/7935
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/f25-backgrounds