Bug 1379074 - [storage] Improve logging for ExportVM flow
Summary: [storage] Improve logging for ExportVM flow
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.6.5
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.1.1
: ---
Assignee: Shmuel Melamud
QA Contact: sefi litmanovich
URL:
Whiteboard:
Depends On:
Blocks: 1425219
TreeView+ depends on / blocked
 
Reported: 2016-09-24 16:49 UTC by Marina Kalinin
Modified: 2019-12-16 06:56 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Previously, the ExportVmCommand appeared in the Engine log without the ID of the virtual machine being exported. This information has now been added to the log. Note: After this change, users must have export permissions for the virtual machine and its disks to export a virtual machine. Previously, permissions to export virtual machine disks were sufficient.
Clone Of:
Environment:
Last Closed: 2017-04-25 00:52:16 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:0997 0 normal SHIPPED_LIVE Red Hat Virtualization Manager (ovirt-engine) 4.1 GA 2017-04-18 20:11:26 UTC
oVirt gerrit 71678 0 None None None 2017-02-14 07:33:08 UTC
oVirt gerrit 72392 0 None None None 2017-02-16 13:38:23 UTC

Description Marina Kalinin 2016-09-24 16:49:36 UTC 
I had to dig into customer logs from 3.6.5 and it was very inconvenient, at a very least. I didn't check on latest version. So, if the following has been improved, please show the improvements and close the bug.

1. Correlation ID should propagate from the ExportVM flow to the subsequent CopyImage commands (and hopefully vdsm as well, I didn't check vdsm). To allow easy correlation.

2. Make sure correlation ID is present in all the messages, for example this one is missing it:
~~~
2016-09-21 07:39:03,486 ERROR [org.ovirt.engine.core.bll.ExportVmCommand] (org.ovirt.thread.pool-6-thread-37) [] Ending command 'org.ovirt.engine.core.bll.ExportVmCommand' with failure.
~~~

3. The following command should mention VM name or VM uuid. But all it mentions is storage id. So it is not really informative.
2016-09-21 07:38:30,519 INFO  [org.ovirt.engine.core.bll.ExportVmCommand] (org.ovirt.thread.pool-6-thread-36) [2986f56b] Running command: ExportVmCommand internal: false. Entities affected :  ID: 2903589d-e1f3-4618-baf5-96ca13294077 Type: StorageAction group IMPORT_EXPORT_VM with role type ADMIN


Logs and additional details are following
Comment 4 Tal Nisan 2016-09-25 09:03:55 UTC 
Michal as you are taking all export domain related bugs I'm putting this one on virt as well as a part of your consideration about the future of the export domain
Comment 6 Michal Skrivanek 2016-12-07 12:52:00 UTC 
is it the correlation id across engine and vdsm you are looking for? there is a separate argument/bug about that i believe (also opened by you I think)
Comment 8 Marina Kalinin 2016-12-07 20:47:08 UTC 
(In reply to Michal Skrivanek from comment #6)
> is it the correlation id across engine and vdsm you are looking for? there
> is a separate argument/bug about that i believe (also opened by you I think)

1. and 2. - yes.
3. is different and still important, in my opinion.
Comment 9 Shmuel Melamud 2017-02-05 13:37:08 UTC 
Can you please give a reference to the bug related to correlation ID fix (items 1 and 2)?
Comment 10 Marina Kalinin 2017-02-13 22:32:44 UTC 
(In reply to Shmuel Melamud from comment #9)
> Can you please give a reference to the bug related to correlation ID fix
> (items 1 and 2)?

Tough one.
Michal, I think you meant this one:
https://bugzilla.redhat.com/show_bug.cgi?id=1339045

I do not think we have a specific one for correlation id in general. We may have a bug somewhere (or a gerrit commit?) requesting to stop using it, I think by smizrahi.

Shmuel, I would start from little - fix those specific flows as requested. And this will contribute to the use of correlation id and related.
Comment 13 Shmuel Melamud 2017-02-16 14:07:30 UTC 
#3 is addressed, the rest is out of scope of this bug.
Comment 14 Michal Skrivanek 2017-02-16 18:01:30 UTC 
(In reply to Marina from comment #10)
> (In reply to Shmuel Melamud from comment #9)
> > Can you please give a reference to the bug related to correlation ID fix
> > (items 1 and 2)?
> 
> Tough one.
> Michal, I think you meant this one:
> https://bugzilla.redhat.com/show_bug.cgi?id=1339045

Indeed that is the one

> Shmuel, I would start from little - fix those specific flows as requested.
> And this will contribute to the use of correlation id and related.

Ok, that's what is being tracked here
Comment 16 sefi litmanovich 2017-03-13 15:35:00 UTC 
Verified on rhevm-4.1.1.4-0.1.el7.noarch : [org.ovirt.engine.core.bll.ExportVmCommand]  now show also the ID of the exported vm.
Note You need to log in before you can comment on or make changes to this bug.