Bug 1379074 – [storage] Improve logging for ExportVM flow

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1379074 - [storage] Improve logging for ExportVM flow

Summary:	[storage] Improve logging for ExportVM flow

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-engine (Show other bugs)
Sub Component:
Version:	3.6.5
Hardware:	Unspecified Unspecified

Priority	high Severity high
Target Milestone:	ovirt-4.1.1
Target Release:	---
Assigned To:	Shmuel Melamud
QA Contact:	sefi litmanovich
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:	1425219
	Show dependency tree / graph

Reported:	2016-09-24 12:49 EDT by Marina
Modified:	2017-04-24 20:52 EDT (History)
CC List:	15 users (show)

See Also:
Fixed In Version:
Doc Type:	Enhancement
Doc Text:	Previously, the ExportVmCommand appeared in the Engine log without the ID of the virtual machine being exported. This information has now been added to the log. Note: After this change, users must have export permissions for the virtual machine and its disks to export a virtual machine. Previously, permissions to export virtual machine disks were sufficient.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-04-24 20:52:16 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Virt
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	71678	None	None	None	2017-02-14 02:33 EST
oVirt gerrit	72392	None	None	None	2017-02-16 08:38 EST
Red Hat Product Errata	RHEA-2017:0997	normal	SHIPPED_LIVE	Red Hat Virtualization Manager (ovirt-engine) 4.1 GA	2017-04-18 16:11:26 EDT

Groups: None (edit)

Description Marina 2016-09-24 12:49:36 EDT

I had to dig into customer logs from 3.6.5 and it was very inconvenient, at a very least. I didn't check on latest version. So, if the following has been improved, please show the improvements and close the bug.

1. Correlation ID should propagate from the ExportVM flow to the subsequent CopyImage commands (and hopefully vdsm as well, I didn't check vdsm). To allow easy correlation.

2. Make sure correlation ID is present in all the messages, for example this one is missing it:
~~~
2016-09-21 07:39:03,486 ERROR [org.ovirt.engine.core.bll.ExportVmCommand] (org.ovirt.thread.pool-6-thread-37) [] Ending command 'org.ovirt.engine.core.bll.ExportVmCommand' with failure.
~~~

3. The following command should mention VM name or VM uuid. But all it mentions is storage id. So it is not really informative.
2016-09-21 07:38:30,519 INFO  [org.ovirt.engine.core.bll.ExportVmCommand] (org.ovirt.thread.pool-6-thread-36) [2986f56b] Running command: ExportVmCommand internal: false. Entities affected :  ID: 2903589d-e1f3-4618-baf5-96ca13294077 Type: StorageAction group IMPORT_EXPORT_VM with role type ADMIN


Logs and additional details are following

Comment 4 Tal Nisan 2016-09-25 05:03:55 EDT

Michal as you are taking all export domain related bugs I'm putting this one on virt as well as a part of your consideration about the future of the export domain

Comment 6 Michal Skrivanek 2016-12-07 07:52:00 EST

is it the correlation id across engine and vdsm you are looking for? there is a separate argument/bug about that i believe (also opened by you I think)

Comment 8 Marina 2016-12-07 15:47:08 EST

(In reply to Michal Skrivanek from comment #6)
> is it the correlation id across engine and vdsm you are looking for? there
> is a separate argument/bug about that i believe (also opened by you I think)

1. and 2. - yes.
3. is different and still important, in my opinion.

Comment 9 Shmuel Melamud 2017-02-05 08:37:08 EST

Can you please give a reference to the bug related to correlation ID fix (items 1 and 2)?

Comment 10 Marina 2017-02-13 17:32:44 EST

(In reply to Shmuel Melamud from comment #9)
> Can you please give a reference to the bug related to correlation ID fix
> (items 1 and 2)?

Tough one.
Michal, I think you meant this one:
https://bugzilla.redhat.com/show_bug.cgi?id=1339045

I do not think we have a specific one for correlation id in general. We may have a bug somewhere (or a gerrit commit?) requesting to stop using it, I think by smizrahi.

Shmuel, I would start from little - fix those specific flows as requested. And this will contribute to the use of correlation id and related.

Comment 13 Shmuel Melamud 2017-02-16 09:07:30 EST

#3 is addressed, the rest is out of scope of this bug.

Comment 14 Michal Skrivanek 2017-02-16 13:01:30 EST

(In reply to Marina from comment #10)
> (In reply to Shmuel Melamud from comment #9)
> > Can you please give a reference to the bug related to correlation ID fix
> > (items 1 and 2)?
> 
> Tough one.
> Michal, I think you meant this one:
> https://bugzilla.redhat.com/show_bug.cgi?id=1339045

Indeed that is the one

> Shmuel, I would start from little - fix those specific flows as requested.
> And this will contribute to the use of correlation id and related.

Ok, that's what is being tracked here

Comment 16 sefi litmanovich 2017-03-13 11:35:00 EDT

Verified on rhevm-4.1.1.4-0.1.el7.noarch : [org.ovirt.engine.core.bll.ExportVmCommand]  now show also the ID of the exported vm.

Note You need to log in before you can comment on or make changes to this bug.