Bug 1379131 - Snapshot not removed on commit of previous one
Summary: Snapshot not removed on commit of previous one
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.0.3
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.1.0-beta
: 4.1.0.2
Assignee: Daniel Erez
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-25 10:00 UTC by Yedidyah Bar David
Modified: 2017-02-01 14:45 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:45:43 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
tnisan: devel_ack+
ratamir: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 68536 0 master MERGED core: commit snapshot - handle snapshots with illegal disks 2016-12-27 11:19:01 UTC
oVirt gerrit 69181 0 ovirt-engine-4.1 MERGED core: commit snapshot - handle snapshots with illegal disks 2016-12-27 23:47:40 UTC
oVirt gerrit 69200 0 ovirt-engine-4.0 ABANDONED core: commit snapshot - handle snapshots with illegal disks 2016-12-28 09:48:22 UTC

Description Yedidyah Bar David 2016-09-25 10:00:10 UTC 
Description of problem:

I have a VM didi-rhel6-dwh, which had these snapshots:

0. Current Active VM
1. Feb 4, 2015 5:36:25 PM after-remote-dwh-reports-setup
2. Jan 21, 2015 3:08:51 PM after-yum-update-and-usb-enabled
3. Dec 21, 2014 12:27:06 PM after-yum-update

and several older ones.

Did this:
1. Machine was up from (0.)
2. Shutdown from within machine
3. Selected (2.) and pressed Preview. Snapshot had memory, chose to not restore it.
4. Pressed Start.
5. Machine booted ok. Logged into it, all seemed ok.
6. Shutdown from within machine.
7. Pressed Commit.
8. After a while it seems to have finished - nothing was locked etc. But snapshot (1.) didn't disappear.
9. Pressed Start.
10. Machine booted ok. Logged into it, all seemed ok. It still looked as in the state in which snapshot (2.) was taken. Tried refreshing the browser etc., snapshot (1.) didn't disappear.

Version-Release number of selected component (if applicable):

4.0.4.2

Snapshots were taken on older versions, not sure which.

How reproducible:

Not sure

Steps to Reproduce:
1. See above
2.
3.

Actual results:

See above

Expected results:

Snapshot (1.) to disappear

Additional info:

Not sure how, but might be related to bug 1375139 ?

Usually when I revert a VM to a previous snapshot these days, I do not boot it first in Preview - I just Preview and Commit immediately. This time was a bit more careful due to bug 1375139.
Comment 1 Yedidyah Bar David 2016-09-25 10:00:52 UTC 
This is on rhev.tlv.redhat.com, I did all of the above as a user from the user portal - I do not have admin privs there.
Comment 2 Red Hat Bugzilla Rules Engine 2016-09-25 13:38:42 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 3 Daniel Erez 2016-10-31 10:11:23 UTC 
Hi Didi,

Do you still have the relevant engine/ui/vdsm logs to upload?
Comment 4 Yedidyah Bar David 2016-10-31 10:38:06 UTC 
(In reply to Daniel Erez from comment #3)
> Hi Didi,
> 
> Do you still have the relevant engine/ui/vdsm logs to upload?

As I wrote above, it's not my engine, it's rhev.tlv.redhat.com. I see there engine.log only from 2016-10-09 onwards, so too new. Denis, do you have backups of /var/log/ovirt-engine from September? Also of the relevant hosts - iirc hera09 or hera10 - we can see that in engine.log if you find it.
Comment 5 Raz Tamir 2017-01-22 19:11:52 UTC 
Verified on ovirt-engine-4.1.0.3-0.0.master.20170122091652.gitc6fc2c2.el7.centos.noarch

- Created VM with 1 disk and added 2 snapshots.
- Removed the first snapshot

--> the second snapshot was removed
Note You need to log in before you can comment on or make changes to this bug.