RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1379200 - ABI check error message is wrong when serial controller model does not match
Summary: ABI check error message is wrong when serial controller model does not match
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.3
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: rc
: ---
Assignee: Michal Privoznik
QA Contact: Jing Qi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-26 02:58 UTC by zhe peng
Modified: 2017-08-01 23:57 UTC (History)
4 users (show)

Fixed In Version: libvirt-3.1.0-2.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-01 17:16:43 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1846 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2017-08-01 18:02:50 UTC

Description zhe peng 2016-09-26 02:58:11 UTC 
Description of problem:
ABI check get wrong error message when restore guest with modified xml

How producible
100%

Build:
libvirt-2.0.0-9.el7.x86_64

Steps:
1. start a guest
#virsh dumpxml rhel7
....
  <serial type='pty'>
      <source path='/dev/pts/2'/>
      <target type='isa-serial' port='1'/>
      <alias name='serial0'/>
    </serial>
    <console type='pty'>
      <source path='/dev/pts/2'/>
      <target type='serial' port='1'/>
      <alias name='serial0'/>
    </console>
....

#virsh dumpxml rhel7 > rhel7.xml

#virsh save rhel7 r7.save

modified xml
#vi rhel7.xml
...
<serial type='pty'>
      <target type='isa-serial' port='1'/>
    </serial>
...
change to:
...
    <serial type='pty'>
      <target type='pci-serial' port='1'/>
    </serial>
...

restore guest with xml
# virsh restore r7.save --xml rhel7.xml
error: Failed to restore domain from r7.save
error: unsupported configuration: Target controller type pci does not match source virtio-serial

Actual result
error: unsupported configuration: Target controller type pci does not match source virtio-serial

Expected result
error: unsupported configuration：Target serial type pci-serial does not match source isa-serial
Comment 2 Michal Privoznik 2017-03-03 09:56:12 UTC 
Patch proposed upstream:

https://www.redhat.com/archives/libvir-list/2017-March/msg00109.html
Comment 3 Michal Privoznik 2017-03-08 09:32:35 UTC 
Pushed upstream:

commit b3388de7f26e6e62a3cf67a12481fdfbf16fc5e4
Author:     Michal Privoznik <mprivozn>
AuthorDate: Fri Mar 3 10:45:31 2017 +0100
Commit:     Michal Privoznik <mprivozn>
CommitDate: Wed Mar 8 10:09:15 2017 +0100

    qemuDomainSaveImageUpdateDef: Don't overwrite errors from virDomainDefCheckABIStability
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1379200
    
    When we are restoring a domain from a saved image, or just
    updating its XML in the saved image - we have to make sure that
    the ABI guests sees will not change. We have a function for that
    which reports errors. But for some reason if this function fails,
    we call it again with slightly different argument. Therefore it
    might happen that we overwrite the original error and leave user
    with less helpful one.
    
    Signed-off-by: Michal Privoznik <mprivozn>

v3.1.0-81-gb3388de7f
Comment 4 Michal Privoznik 2017-03-08 09:35:45 UTC 
To POST:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2017-March/msg00218.html
Comment 6 Jing Qi 2017-03-13 05:27:17 UTC 
Verified the issue with label libvirt-3.1.0-2.el7.x86_64 and the result is as below.

# virsh restore /tmp/rhel7.save  --xml rhel7.xml
error: Failed to restore domain from /tmp/rhel7.save
error: unsupported configuration: Target serial type pci-serial does not match source isa-serial
Comment 7 errata-xmlrpc 2017-08-01 17:16:43 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Comment 8 errata-xmlrpc 2017-08-01 23:57:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Note You need to log in before you can comment on or make changes to this bug.