Spec URL: https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec SRPM URL: https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc22.src.rpm Description: SSIA Fedora Account System Username: ttomecek
Just a couple of easy-to-fix issues, which are at the top: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - python3-docker-pycreds requires python3-six, not listed in Requires: ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [!]: License file installed when any subpackage combination is installed. Note: License file LICENSE is not marked as %license [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. python3-docker-pycreds requires python3-six, not listed in Requires: [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. Note: Tests require a package which is not yet in Fedora. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. Note: Tests require a package which is not yet in Fedora. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-docker-pycreds-0.2.1-1.fc26.noarch.rpm python3-docker-pycreds-0.2.1-1.fc26.noarch.rpm python-docker-pycreds-0.2.1-1.fc26.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python-docker-pycreds (rpmlib, GLIBC filtered): python(abi) python-six python3-docker-pycreds (rpmlib, GLIBC filtered): python(abi) Provides -------- python-docker-pycreds: python-docker-pycreds python2.7dist(docker-pycreds) python2dist(docker-pycreds) python3-docker-pycreds: python3-docker-pycreds python3.5dist(docker-pycreds) python3dist(docker-pycreds) Source checksums ---------------- https://pypi.python.org/packages/95/2e/3c99b8707a397153bc78870eb140c580628d7897276960da25d8a83c4719/docker-pycreds-0.2.1.tar.gz : CHECKSUM(SHA256) this package : 93833a2cf280b7d8abbe1b8121530413250c6cd4ffed2c1cf085f335262f7348 CHECKSUM(SHA256) upstream package : 93833a2cf280b7d8abbe1b8121530413250c6cd4ffed2c1cf085f335262f7348 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1379254 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Michael, thanks for the review well done. I wonder how my fedora-review (and myself) missed those. Updated: https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec
OK, the LICENSE looks right now, but the Requires: python3-six is still missing. Instead, where I expected to see it, I found BuildRequires: python-six %if %{?with_python3} BuildRequires: python3-devel -BuildRequires: python-six +Requires: python3-six BuildRequires: python3-pytest %endif # if with_python3
Hi Tomas, 1) Can you use the current recommended way of writing python specs? See we are now using %py2_build, %py2_install macros. See https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file 2) Source0: can be used as Source0: https://files.pythonhosted.org/packages/source/d/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
(I'm back from vacation) I used pyp2rpm to generate the spec and expected it would conform to the guidelines. I rewrote it then. Spec: https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec Srpm: https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm
All right, thank you to Parag An who drew my attention to the need to pay attention to the Python-specific guidelines more closely. I think this package is almost ready. I was only able to find one issue, but it's a pretty serious one. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues === - This program requires the python six module, but neither subpackage Requires: it. %package -n python2-%{pypi_name} Does not contain Requires: python-six %package -n python3-%{pypi_name} Does not contain Requires: python3-six ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-docker-pycreds-0.2.1-1.fc26.noarch.rpm python3-docker-pycreds-0.2.1-1.fc26.noarch.rpm python-docker-pycreds-0.2.1-1.fc26.src.rpm python2-docker-pycreds.noarch: W: unexpanded-macro Obsoletes python-%{srcname} < 0.2.1-1.fc26 %{srcname} python2-docker-pycreds.noarch: W: unexpanded-macro Provides python-%{srcname} = 0.2.1-1.fc26 %{srcname} 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python2-docker-pycreds.noarch: W: unexpanded-macro Obsoletes python-%{srcname} < 0.2.1-1.fc26 %{srcname} python2-docker-pycreds.noarch: W: unexpanded-macro Provides python-%{srcname} = 0.2.1-1.fc26 %{srcname} 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python2-docker-pycreds (rpmlib, GLIBC filtered): python(abi) python3-docker-pycreds (rpmlib, GLIBC filtered): python(abi) Provides -------- python2-docker-pycreds: python-%{srcname} python2-docker-pycreds python2.7dist(docker-pycreds) python2dist(docker-pycreds) python3-docker-pycreds: python3-docker-pycreds python3.5dist(docker-pycreds) python3dist(docker-pycreds) Source checksums ---------------- https://files.pythonhosted.org/packages/source/d/docker-pycreds/docker-pycreds-0.2.1.tar.gz : CHECKSUM(SHA256) this package : 93833a2cf280b7d8abbe1b8121530413250c6cd4ffed2c1cf085f335262f7348 CHECKSUM(SHA256) upstream package : 93833a2cf280b7d8abbe1b8121530413250c6cd4ffed2c1cf085f335262f7348
Oh my, I feel really bad now. The new spec format is pretty confusing. I really hope I got it right this time, thank you so much Michael and Parag. (on top of the missing requirement, there was also a typo in provides macro) Spec: https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec Srpm: https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm
All right, the Requires look right and everything else does as well. That covers everything I could find. If something else comes up later, it should be easy enough to update it.
Thanks a lot Michael! SCM request initiated: https://admin.fedoraproject.org/pkgdb/package/requests/8140
I am happy to help here :) BTW, you used bcond so I just thought lets check and python3 bcond need some changes in spec. e.g. rpmbuild -ba python-docker-pycreds.spec --without python failing because conditional not used for py3_build and py3_install lines.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-docker-pycreds
python-docker-pycreds-0.2.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9a3a8e9dd8
python-docker-pycreds-0.2.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e4c91eeb23
python-docker-pycreds-0.2.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-docker-pycreds-0.2.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.