Spec URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose.spec SRPM URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose-0.1.0-0.1.git8227684.fc24.src.rpm Description: This is a tool that is used to convert between compose files to kubernetes/openshift artifacts. Fedora Account System Username: dustymabe
Hey jchaloup. I ran redora review tool on this rpm myself. One problem I notice is that the devel rpm won't install because the "requires" aren't all met. This makes sense because we don't bundle things in the vendor directory. What do I do about that?
It is sad but in this case I recommend to set with_devel and with_unit_test to 0. As long as the missing dependencies are not packaged in Fedora, it does not make much sense to provide devel or any subpackage that depends on devel.
ok rpm has been updated: Spec URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose.spec SRPM URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose-0.1.0-0.1.git8227684.fc24.src.rpm
This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/kompose See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* MPL (v2.0)", "ISC", "BSD (3 clause)", "BSD (2 clause)", "BSD (3 clause) MIT/X11 (BSD like)". 1590 files have unknown license. Detailed output of licensecheck in /tmp/tmpOV_NQ5/review- kompose/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 5 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kompose- debuginfo [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define gobuild(o:) go build -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d ' \\n')" -a -v -x %{?**}; [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kompose-0.1.0-0.1.git8227684.fc24.x86_64.rpm kompose-debuginfo-0.1.0-0.1.git8227684.fc24.x86_64.rpm kompose-0.1.0-0.1.git8227684.fc24.src.rpm kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/README.md kompose.x86_64: E: script-without-shebang /usr/share/licenses/kompose/LICENSE kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/RELEASE.md kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/code-of-conduct.md kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/CONTRIBUTING.md kompose.x86_64: W: no-manual-page-for-binary kompose kompose.src:596: W: macro-in-comment %{buildroot} 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: kompose-debuginfo-0.1.0-0.1.git8227684.fc24.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/RELEASE.md kompose.x86_64: E: script-without-shebang /usr/share/licenses/kompose/LICENSE kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/CONTRIBUTING.md kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/README.md kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/code-of-conduct.md kompose.x86_64: W: no-manual-page-for-binary kompose 2 packages and 0 specfiles checked; 1 errors, 5 warnings. Requires -------- kompose (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) kompose-debuginfo (rpmlib, GLIBC filtered): Provides -------- kompose: bundled(golang(github.com/Azure/go-ansiterm)) bundled(golang(github.com/Azure/go-ansiterm/winterm)) bundled(golang(github.com/Microsoft/go-winio)) bundled(golang(github.com/Sirupsen/logrus)) bundled(golang(github.com/beorn7/perks/quantile)) bundled(golang(github.com/blang/semver)) bundled(golang(github.com/coreos/go-oidc/http)) bundled(golang(github.com/coreos/go-oidc/jose)) bundled(golang(github.com/coreos/go-oidc/key)) bundled(golang(github.com/coreos/go-oidc/oauth2)) bundled(golang(github.com/coreos/go-oidc/oidc)) bundled(golang(github.com/coreos/go-systemd/journal)) bundled(golang(github.com/coreos/pkg/capnslog)) bundled(golang(github.com/coreos/pkg/health)) bundled(golang(github.com/coreos/pkg/httputil)) bundled(golang(github.com/coreos/pkg/timeutil)) bundled(golang(github.com/davecgh/go-spew/spew)) bundled(golang(github.com/dgrijalva/jwt-go)) bundled(golang(github.com/docker/distribution)) bundled(golang(github.com/docker/distribution/context)) bundled(golang(github.com/docker/distribution/digest)) bundled(golang(github.com/docker/distribution/manifest)) bundled(golang(github.com/docker/distribution/manifest/schema1)) bundled(golang(github.com/docker/distribution/manifest/schema2)) bundled(golang(github.com/docker/distribution/reference)) bundled(golang(github.com/docker/distribution/registry/api/errcode)) bundled(golang(github.com/docker/distribution/registry/api/v2)) bundled(golang(github.com/docker/distribution/registry/client)) bundled(golang(github.com/docker/distribution/registry/client/auth)) bundled(golang(github.com/docker/distribution/registry/client/transport)) bundled(golang(github.com/docker/distribution/registry/storage/cache)) bundled(golang(github.com/docker/distribution/registry/storage/cache/memory)) bundled(golang(github.com/docker/distribution/uuid)) bundled(golang(github.com/docker/docker/api/client/bundlefile)) bundled(golang(github.com/docker/docker/api/types/backend)) bundled(golang(github.com/docker/docker/builder)) bundled(golang(github.com/docker/docker/builder/dockerignore)) bundled(golang(github.com/docker/docker/cliconfig)) bundled(golang(github.com/docker/docker/cliconfig/configfile)) bundled(golang(github.com/docker/docker/daemon/graphdriver)) bundled(golang(github.com/docker/docker/image)) bundled(golang(github.com/docker/docker/image/v1)) bundled(golang(github.com/docker/docker/layer)) bundled(golang(github.com/docker/docker/opts)) bundled(golang(github.com/docker/docker/pkg/archive)) bundled(golang(github.com/docker/docker/pkg/chrootarchive)) bundled(golang(github.com/docker/docker/pkg/fileutils)) bundled(golang(github.com/docker/docker/pkg/gitutils)) bundled(golang(github.com/docker/docker/pkg/homedir)) bundled(golang(github.com/docker/docker/pkg/httputils)) bundled(golang(github.com/docker/docker/pkg/idtools)) bundled(golang(github.com/docker/docker/pkg/ioutils)) bundled(golang(github.com/docker/docker/pkg/jsonlog)) bundled(golang(github.com/docker/docker/pkg/jsonmessage)) bundled(golang(github.com/docker/docker/pkg/longpath)) bundled(golang(github.com/docker/docker/pkg/mflag)) bundled(golang(github.com/docker/docker/pkg/mount)) bundled(golang(github.com/docker/docker/pkg/plugins)) bundled(golang(github.com/docker/docker/pkg/plugins/transport)) bundled(golang(github.com/docker/docker/pkg/pools)) bundled(golang(github.com/docker/docker/pkg/progress)) bundled(golang(github.com/docker/docker/pkg/promise)) bundled(golang(github.com/docker/docker/pkg/random)) bundled(golang(github.com/docker/docker/pkg/reexec)) bundled(golang(github.com/docker/docker/pkg/signal)) bundled(golang(github.com/docker/docker/pkg/stdcopy)) bundled(golang(github.com/docker/docker/pkg/streamformatter)) bundled(golang(github.com/docker/docker/pkg/stringid)) bundled(golang(github.com/docker/docker/pkg/symlink)) bundled(golang(github.com/docker/docker/pkg/system)) bundled(golang(github.com/docker/docker/pkg/tarsum)) bundled(golang(github.com/docker/docker/pkg/term)) bundled(golang(github.com/docker/docker/pkg/term/windows)) bundled(golang(github.com/docker/docker/pkg/urlutil)) bundled(golang(github.com/docker/docker/reference)) bundled(golang(github.com/docker/docker/registry)) bundled(golang(github.com/docker/docker/runconfig/opts)) bundled(golang(github.com/docker/engine-api/client)) bundled(golang(github.com/docker/engine-api/client/transport)) bundled(golang(github.com/docker/engine-api/client/transport/cancellable)) bundled(golang(github.com/docker/engine-api/types)) bundled(golang(github.com/docker/engine-api/types/blkiodev)) bundled(golang(github.com/docker/engine-api/types/container)) bundled(golang(github.com/docker/engine-api/types/events)) bundled(golang(github.com/docker/engine-api/types/filters)) bundled(golang(github.com/docker/engine-api/types/network)) bundled(golang(github.com/docker/engine-api/types/reference)) bundled(golang(github.com/docker/engine-api/types/registry)) bundled(golang(github.com/docker/engine-api/types/strslice)) bundled(golang(github.com/docker/engine-api/types/swarm)) bundled(golang(github.com/docker/engine-api/types/time)) bundled(golang(github.com/docker/engine-api/types/versions)) bundled(golang(github.com/docker/go-connections/nat)) bundled(golang(github.com/docker/go-connections/sockets)) bundled(golang(github.com/docker/go-connections/tlsconfig)) bundled(golang(github.com/docker/go-units)) bundled(golang(github.com/docker/libcompose/config)) bundled(golang(github.com/docker/libcompose/docker)) bundled(golang(github.com/docker/libcompose/docker/builder)) bundled(golang(github.com/docker/libcompose/docker/client)) bundled(golang(github.com/docker/libcompose/docker/network)) bundled(golang(github.com/docker/libcompose/docker/volume)) bundled(golang(github.com/docker/libcompose/labels)) bundled(golang(github.com/docker/libcompose/logger)) bundled(golang(github.com/docker/libcompose/lookup)) bundled(golang(github.com/docker/libcompose/project)) bundled(golang(github.com/docker/libcompose/project/events)) bundled(golang(github.com/docker/libcompose/project/options)) bundled(golang(github.com/docker/libcompose/utils)) bundled(golang(github.com/docker/libcompose/version)) bundled(golang(github.com/docker/libcompose/yaml)) bundled(golang(github.com/docker/libtrust)) bundled(golang(github.com/emicklei/go-restful)) bundled(golang(github.com/emicklei/go-restful/log)) bundled(golang(github.com/emicklei/go-restful/swagger)) bundled(golang(github.com/evanphx/json-patch)) bundled(golang(github.com/fatih/structs)) bundled(golang(github.com/flynn/go-shlex)) bundled(golang(github.com/fsouza/go-dockerclient)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/Sirupsen/logrus)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/opts)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/archive)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/fileutils)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/homedir)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/idtools)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/ioutils)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/longpath)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/pools)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/promise)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/stdcopy)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/docker/pkg/system)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/docker/go-units)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/hashicorp/go-cleanhttp)) bundled(golang(github.com/fsouza/go-dockerclient/external/github.com/opencontainers/runc/libcontainer/user)) bundled(golang(github.com/fsouza/go-dockerclient/external/golang.org/x/net/context)) bundled(golang(github.com/fsouza/go-dockerclient/external/golang.org/x/sys/unix)) bundled(golang(github.com/ghodss/yaml)) bundled(golang(github.com/gogo/protobuf/proto)) bundled(golang(github.com/golang/glog)) bundled(golang(github.com/golang/groupcache/lru)) bundled(golang(github.com/golang/protobuf/proto)) bundled(golang(github.com/google/cadvisor/info/v1)) bundled(golang(github.com/google/gofuzz)) bundled(golang(github.com/gorilla/context)) bundled(golang(github.com/gorilla/mux)) bundled(golang(github.com/imdario/mergo)) bundled(golang(github.com/inconshreveable/mousetrap)) bundled(golang(github.com/jonboulle/clockwork)) bundled(golang(github.com/juju/ratelimit)) bundled(golang(github.com/matttproud/golang_protobuf_extensions/pbutil)) bundled(golang(github.com/opencontainers/runc/libcontainer/cgroups)) bundled(golang(github.com/opencontainers/runc/libcontainer/cgroups/fs)) bundled(golang(github.com/opencontainers/runc/libcontainer/configs)) bundled(golang(github.com/opencontainers/runc/libcontainer/system)) bundled(golang(github.com/opencontainers/runc/libcontainer/user)) bundled(golang(github.com/openshift/origin/pkg/api)) bundled(golang(github.com/openshift/origin/pkg/api/extension)) bundled(golang(github.com/openshift/origin/pkg/authorization/api)) bundled(golang(github.com/openshift/origin/pkg/build/api)) bundled(golang(github.com/openshift/origin/pkg/deploy/api)) bundled(golang(github.com/openshift/origin/pkg/deploy/api/install)) bundled(golang(github.com/openshift/origin/pkg/deploy/api/v1)) bundled(golang(github.com/openshift/origin/pkg/image/api)) bundled(golang(github.com/openshift/origin/pkg/oauth/api)) bundled(golang(github.com/openshift/origin/pkg/project/api)) bundled(golang(github.com/openshift/origin/pkg/route/api)) bundled(golang(github.com/openshift/origin/pkg/sdn/api)) bundled(golang(github.com/openshift/origin/pkg/security/api)) bundled(golang(github.com/openshift/origin/pkg/template/api)) bundled(golang(github.com/openshift/origin/pkg/user/api)) bundled(golang(github.com/openshift/origin/pkg/util/namer)) bundled(golang(github.com/pborman/uuid)) bundled(golang(github.com/prometheus/client_golang/prometheus)) bundled(golang(github.com/prometheus/client_model/go)) bundled(golang(github.com/prometheus/common/expfmt)) bundled(golang(github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg)) bundled(golang(github.com/prometheus/common/model)) bundled(golang(github.com/prometheus/procfs)) bundled(golang(github.com/spf13/cobra)) bundled(golang(github.com/spf13/pflag)) bundled(golang(github.com/ugorji/go/codec)) bundled(golang(github.com/urfave/cli)) bundled(golang(github.com/vbatts/tar-split/archive/tar)) bundled(golang(github.com/vbatts/tar-split/tar/asm)) bundled(golang(github.com/vbatts/tar-split/tar/storage)) bundled(golang(github.com/vdemeester/docker-events)) bundled(golang(github.com/xeipuuv/gojsonpointer)) bundled(golang(github.com/xeipuuv/gojsonreference)) bundled(golang(github.com/xeipuuv/gojsonschema)) bundled(golang(golang.org/x/net/context)) bundled(golang(golang.org/x/net/context/ctxhttp)) bundled(golang(golang.org/x/net/http2)) bundled(golang(golang.org/x/net/http2/hpack)) bundled(golang(golang.org/x/net/proxy)) bundled(golang(golang.org/x/oauth2)) bundled(golang(golang.org/x/oauth2/google)) bundled(golang(golang.org/x/oauth2/internal)) bundled(golang(golang.org/x/oauth2/jws)) bundled(golang(golang.org/x/oauth2/jwt)) bundled(golang(golang.org/x/sys/unix)) bundled(golang(google.golang.org/cloud/compute/metadata)) bundled(golang(google.golang.org/cloud/internal)) bundled(golang(gopkg.in/inf.v0)) bundled(golang(gopkg.in/yaml.v2)) bundled(golang(k8s.io/kubernetes/federation/apis/federation)) bundled(golang(k8s.io/kubernetes/federation/apis/federation/install)) bundled(golang(k8s.io/kubernetes/federation/apis/federation/v1beta1)) bundled(golang(k8s.io/kubernetes/federation/client/clientset_generated/federation_internalclientset)) bundled(golang(k8s.io/kubernetes/federation/client/clientset_generated/federation_internalclientset/typed/core/unversioned)) bundled(golang(k8s.io/kubernetes/federation/client/clientset_generated/federation_internalclientset/typed/federation/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/api)) bundled(golang(k8s.io/kubernetes/pkg/api/annotations)) bundled(golang(k8s.io/kubernetes/pkg/api/endpoints)) bundled(golang(k8s.io/kubernetes/pkg/api/errors)) bundled(golang(k8s.io/kubernetes/pkg/api/install)) bundled(golang(k8s.io/kubernetes/pkg/api/meta)) bundled(golang(k8s.io/kubernetes/pkg/api/meta/metatypes)) bundled(golang(k8s.io/kubernetes/pkg/api/pod)) bundled(golang(k8s.io/kubernetes/pkg/api/resource)) bundled(golang(k8s.io/kubernetes/pkg/api/rest)) bundled(golang(k8s.io/kubernetes/pkg/api/service)) bundled(golang(k8s.io/kubernetes/pkg/api/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/api/unversioned/validation)) bundled(golang(k8s.io/kubernetes/pkg/api/util)) bundled(golang(k8s.io/kubernetes/pkg/api/v1)) bundled(golang(k8s.io/kubernetes/pkg/api/validation)) bundled(golang(k8s.io/kubernetes/pkg/apimachinery)) bundled(golang(k8s.io/kubernetes/pkg/apimachinery/registered)) bundled(golang(k8s.io/kubernetes/pkg/apis/apps)) bundled(golang(k8s.io/kubernetes/pkg/apis/apps/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/apps/v1alpha1)) bundled(golang(k8s.io/kubernetes/pkg/apis/authentication.k8s.io)) bundled(golang(k8s.io/kubernetes/pkg/apis/authentication.k8s.io/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/authentication.k8s.io/v1beta1)) bundled(golang(k8s.io/kubernetes/pkg/apis/authorization)) bundled(golang(k8s.io/kubernetes/pkg/apis/authorization/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/authorization/v1beta1)) bundled(golang(k8s.io/kubernetes/pkg/apis/autoscaling)) bundled(golang(k8s.io/kubernetes/pkg/apis/autoscaling/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/autoscaling/v1)) bundled(golang(k8s.io/kubernetes/pkg/apis/batch)) bundled(golang(k8s.io/kubernetes/pkg/apis/batch/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/batch/v1)) bundled(golang(k8s.io/kubernetes/pkg/apis/batch/v2alpha1)) bundled(golang(k8s.io/kubernetes/pkg/apis/componentconfig)) bundled(golang(k8s.io/kubernetes/pkg/apis/componentconfig/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/componentconfig/v1alpha1)) bundled(golang(k8s.io/kubernetes/pkg/apis/extensions)) bundled(golang(k8s.io/kubernetes/pkg/apis/extensions/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/extensions/v1beta1)) bundled(golang(k8s.io/kubernetes/pkg/apis/extensions/validation)) bundled(golang(k8s.io/kubernetes/pkg/apis/policy)) bundled(golang(k8s.io/kubernetes/pkg/apis/policy/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/policy/v1alpha1)) bundled(golang(k8s.io/kubernetes/pkg/apis/rbac)) bundled(golang(k8s.io/kubernetes/pkg/apis/rbac/install)) bundled(golang(k8s.io/kubernetes/pkg/apis/rbac/v1alpha1)) bundled(golang(k8s.io/kubernetes/pkg/auth/authenticator)) bundled(golang(k8s.io/kubernetes/pkg/auth/user)) bundled(golang(k8s.io/kubernetes/pkg/capabilities)) bundled(golang(k8s.io/kubernetes/pkg/client/cache)) bundled(golang(k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset)) bundled(golang(k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/autoscaling/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/batch/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/extensions/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/rbac/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/client/metrics)) bundled(golang(k8s.io/kubernetes/pkg/client/record)) bundled(golang(k8s.io/kubernetes/pkg/client/restclient)) bundled(golang(k8s.io/kubernetes/pkg/client/transport)) bundled(golang(k8s.io/kubernetes/pkg/client/typed/discovery)) bundled(golang(k8s.io/kubernetes/pkg/client/unversioned)) bundled(golang(k8s.io/kubernetes/pkg/client/unversioned/adapters/internalclientset)) bundled(golang(k8s.io/kubernetes/pkg/client/unversioned/auth)) bundled(golang(k8s.io/kubernetes/pkg/client/unversioned/clientcmd)) bundled(golang(k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api)) bundled(golang(k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api/latest)) bundled(golang(k8s.io/kubernetes/pkg/client/unversioned/clientcmd/api/v1)) bundled(golang(k8s.io/kubernetes/pkg/controller)) bundled(golang(k8s.io/kubernetes/pkg/controller/framework)) bundled(golang(k8s.io/kubernetes/pkg/conversion)) bundled(golang(k8s.io/kubernetes/pkg/conversion/queryparams)) bundled(golang(k8s.io/kubernetes/pkg/credentialprovider)) bundled(golang(k8s.io/kubernetes/pkg/fieldpath)) bundled(golang(k8s.io/kubernetes/pkg/fields)) bundled(golang(k8s.io/kubernetes/pkg/kubectl)) bundled(golang(k8s.io/kubernetes/pkg/kubectl/cmd/util)) bundled(golang(k8s.io/kubernetes/pkg/kubectl/resource)) bundled(golang(k8s.io/kubernetes/pkg/kubelet/qos)) bundled(golang(k8s.io/kubernetes/pkg/kubelet/qos/util)) bundled(golang(k8s.io/kubernetes/pkg/labels)) bundled(golang(k8s.io/kubernetes/pkg/master/ports)) bundled(golang(k8s.io/kubernetes/pkg/registry/generic)) bundled(golang(k8s.io/kubernetes/pkg/registry/thirdpartyresourcedata)) bundled(golang(k8s.io/kubernetes/pkg/runtime)) bundled(golang(k8s.io/kubernetes/pkg/runtime/serializer)) bundled(golang(k8s.io/kubernetes/pkg/runtime/serializer/json)) bundled(golang(k8s.io/kubernetes/pkg/runtime/serializer/protobuf)) bundled(golang(k8s.io/kubernetes/pkg/runtime/serializer/recognizer)) bundled(golang(k8s.io/kubernetes/pkg/runtime/serializer/streaming)) bundled(golang(k8s.io/kubernetes/pkg/runtime/serializer/versioning)) bundled(golang(k8s.io/kubernetes/pkg/security/podsecuritypolicy/util)) bundled(golang(k8s.io/kubernetes/pkg/securitycontextconstraints/util)) bundled(golang(k8s.io/kubernetes/pkg/serviceaccount)) bundled(golang(k8s.io/kubernetes/pkg/storage)) bundled(golang(k8s.io/kubernetes/pkg/types)) bundled(golang(k8s.io/kubernetes/pkg/util)) bundled(golang(k8s.io/kubernetes/pkg/util/crypto)) bundled(golang(k8s.io/kubernetes/pkg/util/deployment)) bundled(golang(k8s.io/kubernetes/pkg/util/diff)) bundled(golang(k8s.io/kubernetes/pkg/util/errors)) bundled(golang(k8s.io/kubernetes/pkg/util/flag)) bundled(golang(k8s.io/kubernetes/pkg/util/flowcontrol)) bundled(golang(k8s.io/kubernetes/pkg/util/framer)) bundled(golang(k8s.io/kubernetes/pkg/util/hash)) bundled(golang(k8s.io/kubernetes/pkg/util/homedir)) bundled(golang(k8s.io/kubernetes/pkg/util/integer)) bundled(golang(k8s.io/kubernetes/pkg/util/intstr)) bundled(golang(k8s.io/kubernetes/pkg/util/json)) bundled(golang(k8s.io/kubernetes/pkg/util/jsonpath)) bundled(golang(k8s.io/kubernetes/pkg/util/labels)) bundled(golang(k8s.io/kubernetes/pkg/util/net)) bundled(golang(k8s.io/kubernetes/pkg/util/net/sets)) bundled(golang(k8s.io/kubernetes/pkg/util/parsers)) bundled(golang(k8s.io/kubernetes/pkg/util/pod)) bundled(golang(k8s.io/kubernetes/pkg/util/rand)) bundled(golang(k8s.io/kubernetes/pkg/util/replicaset)) bundled(golang(k8s.io/kubernetes/pkg/util/runtime)) bundled(golang(k8s.io/kubernetes/pkg/util/sets)) bundled(golang(k8s.io/kubernetes/pkg/util/slice)) bundled(golang(k8s.io/kubernetes/pkg/util/strategicpatch)) bundled(golang(k8s.io/kubernetes/pkg/util/validation)) bundled(golang(k8s.io/kubernetes/pkg/util/validation/field)) bundled(golang(k8s.io/kubernetes/pkg/util/wait)) bundled(golang(k8s.io/kubernetes/pkg/util/yaml)) bundled(golang(k8s.io/kubernetes/pkg/version)) bundled(golang(k8s.io/kubernetes/pkg/watch)) bundled(golang(k8s.io/kubernetes/pkg/watch/versioned)) bundled(golang(k8s.io/kubernetes/plugin/pkg/client/auth)) bundled(golang(k8s.io/kubernetes/plugin/pkg/client/auth/gcp)) bundled(golang(k8s.io/kubernetes/plugin/pkg/client/auth/oidc)) bundled(golang(k8s.io/kubernetes/third_party/forked/json)) bundled(golang(k8s.io/kubernetes/third_party/forked/reflect)) bundled(golang(k8s.io/kubernetes/third_party/golang/template)) kompose kompose(x86-64) kompose-debuginfo: kompose-debuginfo kompose-debuginfo(x86-64) Source checksums ---------------- https://github.com/skippbox/kompose/archive/822768446621d71ffd02eafd138db0d8ab4a7d0e/kompose-8227684.tar.gz : CHECKSUM(SHA256) this package : 5d144d91a859533283c4f8e3dec276616924d084cf484a116febbda5521ca090 CHECKSUM(SHA256) upstream package : 5d144d91a859533283c4f8e3dec276616924d084cf484a116febbda5521ca090 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :./run.py -n kompose Buildroot used: fedora-24-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
> $ rpmlint kompose-0.1.0-0.1.git8227684.fc24.src.rpm kompose-0.1.0-0.1.git8227684.fc24.x86_64.rpm kompose-debuginfo-0.1.0-0.1.git8227684.fc24.x86_64.rpm > kompose.src:596: W: macro-in-comment %{buildroot} > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/CONTRIBUTING.md > kompose.x86_64: E: script-without-shebang /usr/share/licenses/kompose/LICENSE > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/RELEASE.md > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/README.md > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/code-of-conduct.md > kompose.x86_64: W: no-manual-page-for-binary kompose > 3 packages and 0 specfiles checked; 1 errors, 6 warnings. Permissions of the affected files need to be altered. Man page is optional. The macro should be removed are changed to %%{buildroot} > ===== MUST items ===== > > C/C++: > [ ]: Package does not contain kernel modules. True > [ ]: Package contains no static executables. Go binary is static binary, known fact > Generic: > [ ]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. ASL 2.0 > [ ]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)", > "*No copyright* MPL (v2.0)", "ISC", "BSD (3 clause)", "BSD (2 > clause)", "BSD (3 clause) MIT/X11 (BSD like)". 1590 files have unknown > license. Detailed output of licensecheck in /tmp/tmpOV_NQ5/review- > kompose/licensecheck.txt non ASL 2.0 licenses are licences of dependencies in the vendor directory, not the project itself > [ ]: License file installed when any subpackage combination is installed. True > [ ]: %build honors applicable compiler flags or justifies otherwise. True, Go specific > [ ]: Package contains no bundled libraries without FPC exception. It contains bundled libraries, all of them are listed as "Provides: bundles(library) = %{version}-COMMIT" > [ ]: Changelog in prescribed format. True > [ ]: Sources contain only permissible code or content. True > [ ]: Package contains desktop file if it is a GUI application. No GUI application > [ ]: Development files must be in a -devel package No devel subpackage, only sources > [ ]: Package uses nothing in %doc for runtime. True > [ ]: Package consistently uses macros (instead of hard-coded directory > names). That is true > [ ]: Package is named according to the Package Naming Guidelines. It is > [ ]: Package does not generate any conflict. It does not > [ ]: Package obeys FHS, except libexecdir and /usr/target. It does > [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. No applicable > [ ]: Requires correct, justified where necessary. True > [ ]: Spec file is legible and written in American English. The spec file is readable > [ ]: Package contains systemd file(s) if in need. No systemd > [ ]: Useful -debuginfo package or justification otherwise. Present > [ ]: Package is not known to require an ExcludeArch tag. Not applicable > [ ]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 30720 bytes in 5 files. Not applicable > [ ]: Package complies to the Packaging Guidelines It does > ===== SHOULD items ===== > > Generic: > [ ]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. Not applicable > [ ]: Final provides and requires are sane (see attachments). True > [ ]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kompose- > debuginfo True, debuginfo is generated automatically by rpmbuild > [ ]: Package functions as described. Not applicable > [ ]: Latest version is packaged. True > [ ]: Package does not include license text files separate from upstream. True > [ ]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. Not applicable > [ ]: %check is present and all tests pass. True > [ ]: Packages should try to preserve timestamps of original installed > files. Not applicable, devel is not generated > [ ]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define gobuild(o:) go build > -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d > ' \\n')" -a -v -x %{?**}; I prefer using %define for functions and %global for constants (constant variables). Meaning, the spec file was automatically generated by provided tool.
Up to the file permissions and the macro the spec file complies to packaging guidelines. Once updated the spec file can be approved.
(In reply to Jan Chaloupka from comment #5) > > $ rpmlint kompose-0.1.0-0.1.git8227684.fc24.src.rpm kompose-0.1.0-0.1.git8227684.fc24.x86_64.rpm kompose-debuginfo-0.1.0-0.1.git8227684.fc24.x86_64.rpm > > kompose.src:596: W: macro-in-comment %{buildroot} > > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/CONTRIBUTING.md > > kompose.x86_64: E: script-without-shebang /usr/share/licenses/kompose/LICENSE > > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/RELEASE.md > > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/README.md > > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/code-of-conduct.md > > kompose.x86_64: W: no-manual-page-for-binary kompose > > 3 packages and 0 specfiles checked; 1 errors, 6 warnings. > > Permissions of the affected files need to be altered. I sent a patch upstream for the executable files yesterday, but I can't change what was released in 0.1.0. I guess I'll add code to the rpm to make them not executable as well. > Man page is optional. no work to be done here :) > The macro should be removed are changed to %%{buildroot} I changed to comment to not have '%{buildroot}' latest versions at: Spec URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose.spec SRPM URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose-0.1.0-0.1.git8227684.fc24.src.rpm
Approved
kompose-0.1.0-0.1.git8227684.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-26445cfcfe
kompose-0.1.0-0.1.git8227684.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.