Bug 1379544 - glusterd creates all rpc_clnts with the same name
Summary: glusterd creates all rpc_clnts with the same name
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-27 05:56 UTC by Kaushal
Modified: 2023-09-14 03:31 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-05-09 20:15:36 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaushal 2016-09-27 05:56:41 UTC
Description of problem:
GlusterD create rpc_clnts for every peer it connects to. But all the rpc_clnts are created with `this->name`, ie. GlusterD's xlator name '0-management', as the name.

This makes it problematic when attempting to identify socket_connect failures of GlusterD rpc_clnts. `socket_connect()` logs connect failures with,
```
gf_log (this->name, ((sa_family == AF_UNIX) ? GF_LOG_DEBUG : GF_LOG_ERROR), "connection attempt on %s failed, (%s)", this->peerinfo.identifier, strerror (errno));
```

This log is basically useless for identifying connect to which remote endpoint failed, as `this->name` is the same for all GlusterD rpc_clnt transports and `peerinfo->identifier` is only filled after a successful connect.

Comment 2 Yaniv Kaul 2019-04-17 11:47:15 UTC
Current status?

Comment 3 Amar Tumballi 2019-05-09 20:15:36 UTC
This bug is not valid, as what we are logging with 'this->peerinfo.identifier' is what matters here.

Comment 4 Red Hat Bugzilla 2023-09-14 03:31:26 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.