Bug 1379754 - Host can't be removed (FE exception)
Summary: Host can't be removed (FE exception)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0.2
Assignee: Ramesh N
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-27 15:10 UTC by jniederm
Modified: 2017-04-27 09:36 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-04-27 09:36:08 UTC
oVirt Team: Gluster
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
rule-engine: devel_ack+
sasundar: testing_ack+


Attachments (Terms of Use)
stacktrace.txt (7.86 KB, text/plain)
2016-09-27 15:10 UTC, jniederm
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 64890 0 master MERGED webadmin: fix confirmation popup issue in host remove 2016-10-03 12:13:55 UTC

Description jniederm 2016-09-27 15:10:58 UTC
Created attachment 1205267 [details]
stacktrace.txt

Description of problem:
FE exception is thrown when "Remove" button is clicked on a host.

Version-Release number of selected component (if applicable):
4.1 master, commit 0e71dd7

How reproducible:
100%

Steps to Reproduce:
1. Make sure there is a cluster with only one host in maintenance state.
2. Select the host in webadmin
3. Click "Remove" in toolbar

Actual results:
FE exception is thrown (pink box on upstream, message in browser console)

Expected results:
Host is removed

Additional info:

Comment 1 jniederm 2016-09-27 16:18:34 UTC
The problem relates to patch https://gerrit.ovirt.org/#/c/59102/. Method HostListModel.remote() creates confirmation model as instance of `ConfirmationModel` however HostModule.getHostListProvider() declares that confirmation will be processed by HostMaintenanceConfirmationPopupPresenterWidget that expects instance of HostMaintenanceConfirmationModel.

Assigning to author of the patch.

Comment 2 Tal Nisan 2016-09-27 16:32:43 UTC
The root cause is indeed that patch but Ramesh is from the Gluster team, not storage :)

Comment 3 Ramesh N 2016-09-28 04:26:39 UTC
(In reply to jniederm from comment #1)
> The problem relates to patch https://gerrit.ovirt.org/#/c/59102/. Method
> HostListModel.remote() creates confirmation model as instance of
> `ConfirmationModel` however HostModule.getHostListProvider() declares that
> confirmation will be processed by
> HostMaintenanceConfirmationPopupPresenterWidget that expects instance of
> HostMaintenanceConfirmationModel.
> 
> Assigning to author of the patch.

Sorry for the regression. Let me send a patch to fix it ASAP.

Comment 4 Sandro Bonazzola 2016-12-12 13:54:04 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 5 SATHEESARAN 2017-04-05 10:36:46 UTC
Tested with RHV 4.1.1-6.

When the hosts is already in maintenance, trying to remove the host doesn't generate any FE exception


Note You need to log in before you can comment on or make changes to this bug.