Bug 1379987 – CVE-2016-7567 openslp: memory corruption due to possible overflow in SLPFoldWhiteSpace in common/slp_compare.c

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1379987 - (CVE-2016-7567) CVE-2016-7567 openslp: memory corruption due to possible overflow in SLPFoldWhiteSpace in common/slp_compare.c

Summary:	CVE-2016-7567 openslp: memory corruption due to possible overflow in SLPFoldW...

Status:	CLOSED WONTFIX

Aliases:	CVE-2016-7567

Product:	Security Response
Classification:	Other
Component:	vulnerability (Show other bugs)
Sub Component:
Version:	unspecified
Hardware:	All Linux

Priority	low Severity low
Target Milestone:	---
Target Release:	---
Assigned To:	Red Hat Product Security
QA Contact:
Docs Contact:

URL:
Whiteboard:	impact=low,public=20160927,reported=2...
Keywords:	Security

Depends On:	1379988 1379989
Blocks:
	Show dependency tree / graph

Reported:	2016-09-28 07:22 EDT by Martin Prpič
Modified:	2016-09-28 07:24 EDT (History)
CC List:	2 users (show)

See Also:
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-09-28 07:24:32 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Martin Prpič 2016-09-28 07:22:42 EDT

A memory corruption issue was discovered in OpenSLP:

https://sourceforge.net/p/openslp/mercurial/ci/34fb3aa5e6b4997fa21cb614e480de36da5dbc9a/

Details:

static int SLPFoldWhiteSpace(size_t len, char * str)
{
      char * p = str, * ep = str + len;
      while (p < ep)
      {
            if (isspace(*p))
            {
                char * ws2p = ++p;
                while (isspace(*p))
                     p++;
                len -= p - ws2p;
                memmove(ws2p, p, ep - p);

The outer while loop checks for p < ep, but lack of bound check in inner while loop could result in p > ep. This will result in passing a very large 'size_t len' (ep - p) parameter for memmove().

CVE assignment:

http://seclists.org/oss-sec/2016/q3/633

Comment 1 Martin Prpič 2016-09-28 07:23:38 EDT

Created openslp tracking bugs for this issue:

Affects: fedora-all [bug 1379988]
Affects: epel-5 [bug 1379989]

Note You need to log in before you can comment on or make changes to this bug.