Bug 1380419 – gNFS: Revalidate lookup of a file in case of gfid mismatch

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1380419 - gNFS: Revalidate lookup of a file in case of gfid mismatch

Summary:	gNFS: Revalidate lookup of a file in case of gfid mismatch

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Gluster Storage
Classification:	Red Hat
Component:	gluster-nfs (Show other bugs)
Sub Component:
Version:	3.2
Hardware:	All All

Priority	unspecified Severity high
Target Milestone:	---
Target Release:	RHGS 3.2.0
Assigned To:	Mohammed Rafi KC
QA Contact:	surabhi
Docs Contact:

URL:
Whiteboard:
Keywords:	Triaged

Depends On:
Blocks:	1351528 1358096
	Show dependency tree / graph

Reported:	2016-09-29 10:36 EDT by Soumya Koduri
Modified:	2017-03-23 02:06 EDT (History)
CC List:	6 users (show)

See Also:
Fixed In Version:	glusterfs-3.8.4-6
Doc Type:	If docs needed, set a value
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-03-23 02:06:14 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2017:0486	normal	SHIPPED_LIVE	Moderate: Red Hat Gluster Storage 3.2.0 security, bug fix, and enhancement update	2017-03-23 05:18:45 EDT

Groups: None (edit)

Description Soumya Koduri 2016-09-29 10:36:25 EDT

Description of problem:

As mentioned in the https://bugzilla.redhat.com/show_bug.cgi?id=1358096#c55 ,

>>>>

In case of any lookup sent on a file, if the file already exists but with a different gfid, clients should revalidate/re-issue the lookup to correct the gfid.

nfs_lookup() fop starts with setting lookuptype to GF_NFS3_REVALIDATE. But as per the code changes done in the patch mentioned in the comment#52, before doing STACK_WIND on the child xlator lookup, in case if we find cached inode for that file/entry name in the inode table but with inode_ctx not set, we reset lookuptype to GF_NFS3_FRESH. This may have led to nfs xlator not sending fresh lookup on receiving ESTALE.
<<<

This bug is to track the fix for the above mentioned issue.

Version-Release number of selected component (if applicable):
3.1.2

How reproducible:
From code-inspection

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Soumya Koduri 2016-10-13 09:45:23 EDT

Patch posted upstream for review -
   http://review.gluster.org/15580

Comment 6 Mohammed Rafi KC 2016-11-16 00:56:19 EST

upstream master patch : http://review.gluster.org/15580
upstream 3.9 patch : http://review.gluster.org/#/c/15839/
upstream 3.8 patch : http://review.gluster.org/#/c/15840/
downstream patch : https://code.engineering.redhat.com/gerrit/90281

Comment 7 Atin Mukherjee 2016-11-16 04:00:14 EST

Please note upstream 3.9 & 3.8 patches are yet to be merged as for both of them the merge windows are not yet open.

Comment 10 surabhi 2017-02-07 01:40:59 EST

Tried following test as per discussion with Soumya:

Mount with nfs on two clients

c1 : create dir/f1
Restart gnfs on server
ls dir

From c2:
rm dir/f1
touch dir/f1

From c1
ls dir/f1

There are no issues seen while listing the file which is recreated with the same name after removal from another client.

Marking the BZ verified.

Comment 12 errata-xmlrpc 2017-03-23 02:06:14 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2017-0486.html

Note You need to log in before you can comment on or make changes to this bug.