Spec URL: https://lsm5.fedorapeople.org/gomtree/gomtree.spec SRPM URL: https://lsm5.fedorapeople.org/gomtree/SRPMS/gomtree-0-0.1.git8c6b32c.fc26.src.rpm Description: Go CLI tool for mtree support Fedora Account System Username: lsm5 koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15860784
Change %gobuild -o bin/%{name} %{import_path} to %gobuild -o bin/%{name} %{import_path}/cmd/gomtree Otherwise rpmlint complains about shebang. Otherwise LGTM: After the change: $ rpmlint gomtree-0-0.1.git8c6b32c.fc20.src.rpm gomtree-0-0.1.git8c6b32c.fc20.x86_64.rpm gomtree-devel-0-0.1.git8c6b32c.fc20.noarch.rpm gomtree-unit-test-devel-0-0.1.git8c6b32c.fc20.x86_64.rpm gomtree.src: W: spelling-error Summary(en_US) mtree -> tree, m tree gomtree.src: W: spelling-error %description -l en_US mtree -> tree, m tree gomtree.x86_64: W: spelling-error Summary(en_US) mtree -> tree, m tree gomtree.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree gomtree.x86_64: W: unstripped-binary-or-object /usr/bin/gomtree gomtree.x86_64: W: no-manual-page-for-binary gomtree gomtree-devel.noarch: W: spelling-error Summary(en_US) mtree -> tree, m tree gomtree-devel.noarch: W: spelling-error %description -l en_US mtree -> tree, m tree gomtree-devel.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree 4 packages and 0 specfiles checked; 0 errors, 11 warnings. $ gofed lint W: Incorrect package name gomtree, should be golang-github-vbatts-go-mtree 1 golang specfile checked; 0 errors, 1 warnings. You can ignore the warning, it is recommendation only.
(In reply to Jan Chaloupka from comment #1) > Change > > %gobuild -o bin/%{name} %{import_path} > > to > > %gobuild -o bin/%{name} %{import_path}/cmd/gomtree > > Otherwise rpmlint complains about shebang. Otherwise LGTM: No big deal to me either way, but just curious where you're seeing this in rpmlint. I don't seem to see this anywhere. I'm on rawhide if it matters. See: $ rpmlint SRPMS/gomtree-0-0.1.git8c6b32c.fc26.src.rpm RPMS/* gomtree.spec gomtree.src: W: spelling-error Summary(en_US) mtree -> tree, m tree gomtree.src: W: spelling-error %description -l en_US mtree -> tree, m tree gomtree-devel.noarch: W: spelling-error Summary(en_US) mtree -> tree, m tree gomtree-devel.noarch: W: spelling-error %description -l en_US mtree -> tree, m tree gomtree-devel.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub gomtree.x86_64: W: spelling-error Summary(en_US) mtree -> tree, m tree gomtree.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree gomtree.x86_64: W: binaryinfo-readelf-failed /usr/bin/gomtree gomtree.x86_64: W: no-manual-page-for-binary gomtree gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree 4 packages and 1 specfiles checked; 0 errors, 11 warnings.
$ rpmlint gomtree-0-0.1.git8c6b32c.fc20.x86_64.rpm gomtree.x86_64: W: spelling-error Summary(en_US) mtree -> tree, m tree gomtree.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree gomtree.x86_64: W: binaryinfo-readelf-failed /usr/bin/gomtree gomtree.x86_64: E: script-without-shebang /usr/bin/gomtree gomtree.x86_64: W: no-manual-page-for-binary gomtree 1 packages and 0 specfiles checked; 1 errors, 4 warnings. No sure if %gobuild -o bin/%{name} %{import_path} does anything good. I have always assumed you need to specify entire path to the main package file, i.e. %{import_path}/cmd/gomtree. Checking the compiled binary: $ ./usr/bin/gomtree ./usr/bin/gomtree: line 1: syntax error near unexpected token `newline' ./usr/bin/gomtree: line 1: `!<arch>' $ file ./usr/bin/gomtree ./usr/bin/gomtree: current ar archive
yup I'm seeing this too, weird. Anyway, changed build step like you mentioned. Spec URL: https://lsm5.fedorapeople.org/gomtree/gomtree.spec SRPM URL: https://lsm5.fedorapeople.org/gomtree/SRPMS/gomtree-0-0.2.git8c6b32c.fc26.src.rpm PTAL
Approved
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gomtree
gomtree-0-0.2.git8c6b32c.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3f4edf70de
gomtree-0-0.2.git8c6b32c.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8cdf84f347
gomtree-0-0.2.git8c6b32c.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
gomtree-0-0.2.git8c6b32c.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.