(In reply to Nathaniel McCallum from bug 1378160 comment #1) > Review PASSED > [...] > ===== MUST items ===== > [x]: %build honors applicable compiler flags or justifies otherwise. > [...] > ===== EXTRA items ===== > [...] > [x]: Rpmlint is run on debuginfo package(s). > Note: There are rpmlint messages (see attachment). > [...] > jitterentropy-rngd-debuginfo.x86_64: E: debuginfo-without-sources This should not have passed the review; it's not built with appropriate compiler flags. The specfile contains a comment that it must be built with -O0, but that's not a reason to drop all other compiler flags. https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags Here's one way to fix it: -# Build must be done with -O0 - so ignore buildin make falgs -make +CFLAGS="$RPM_OPT_FLAGS" %make_build
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'.
No comments, so I've pushed and built the fix plus another including license files to rawhide. All earlier distro versions need the fix, too, will leave taking care of that to maintainers.
Your fix is wrong. As can be seen, your change causes a compile with -O2: gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -Wextra -Wall -pedantic -fPIE -pie -O0 -fstack-protector-strong -fwrapv --param ssp-buffer-size=4 -c -o jitterentropy-rngd.o jitterentropy-rngd.c I'm discussing with upstream to see if the -O0 is still needed. If so, I will update your fix to re-introduce -o0.
(In reply to Paul Wouters from comment #3) > your change causes a compile with -O2: No, it doesn't. Look closer into the command line: "gcc -O2 ... -O0 ..."
This message is a reminder that Fedora 26 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '26'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 26 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.